New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775242 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: 2017-12-21
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

system_health.memory_mobile failing on chromium.perf/Android One Perf

Project Member Reported by zh...@chromium.org, Oct 16 2017

Issue description

system_health.memory_mobile failing on chromium.perf/Android One Perf

Builders failed on: 
- Android One Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf



 
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Oct 17 2017


=== BISECT JOB RESULTS ===
NO Test failure found

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:dump_count:background_avg/memory:chrome:all_processes:dump_count:background_avg

Revision             Exit Code      N
chromium@503116      1 +- N/A       5      good
chromium@503197      1 +- N/A       5      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8965538300657826096


For feedback, file a bug with component Speed>Bisection
Cc: nedngu...@google.com
Spent a little time looking at this today. The issue is that the bot is consistently timing out, so results are never saved or uploaded.

Will try to come back at this, hopefully tomorrow, and dig a bit further.
Cc: mariakho...@chromium.org
Maria: I think just keeping system_health.memory_mobile passing on low end devices would get us quite far with memory benchmarking. Should we have your team be the point of triage for system_health.memory_mobile's breakage on Android one?
Cc: charliea@chromium.org
 Issue 795048  has been merged into this issue.
Owner: perezju@chromium.org
This is an ongoing issue, and seems to lead to cause system_health.memory_mobile to fail 10-20% of the time on Android One. 

I'm the current bot health sheriff and responsible for keeping the bots green. I'm assuming that we don't just want to disable system_health.memory_mobile on this platform, so I'm going to bump up the timeout from 3h to 4h given that successful runs of this benchmark regularly take around 2h50m.

Juan, Maria, can you work together to come up with a long-term plan for how we should address this?
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a79793994cb8f772fd9f6039a4c45535d53091d6

commit a79793994cb8f772fd9f6039a4c45535d53091d6
Author: Charlie Andrews <charliea@chromium.org>
Date: Thu Dec 14 19:50:43 2017

Increase the system_health.memory_mobile timeout from 3h to 4h

The benchmark regularly takes around 2h50m-3h on Android One, and has
been regularly timing out for the past several months on the waterfall.

NOTRY=true
TBR=nednguyen@google.com

Bug:  775242 
Change-Id: I2945eef4c12bcf9540c93760c33f54df66dffc9a
Reviewed-on: https://chromium-review.googlesource.com/827605
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524150}
[modify] https://crrev.com/a79793994cb8f772fd9f6039a4c45535d53091d6/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/a79793994cb8f772fd9f6039a4c45535d53091d6/tools/perf/core/perf_data_generator.py

Labels: -Pri-1 Pri-2
NextAction: 2017-12-21
Increasing the timeout did help (thanks Charlie!), and the benchmark has been running a lot better after fixing  issue 785446 . Not sure if there is much else left to do here?

I'll check again in a few days, and close if the benchmark remains relatively happy.
Status: Assigned (was: Available)
Great! Thanks for fixing  issue 785446  Juan - that was a big one.
The NextAction date has arrived: 2017-12-21
Status: Fixed (was: Assigned)

Sign in to add a comment