New issue
Advanced search Search tips

Issue 775236 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 725683


Participants' hotlists:
Fixing-touch


Sign in to add a comment

cros splitview - If there is only one snapped window, start doing the fade-out animation when the divider achieve the window's minimum size

Project Member Reported by x...@chromium.org, Oct 16 2017

Issue description

Modified the expected behavior based on comment#2: 

It's possible that there is only one snapped window (e.g., the other side of the screen is occupied by the overview window grid), when the user drags the split view divider, beyond the minimum bounds of the window it starts doing the fade-out animation towards closing the app.
 

Comment 1 by x...@chromium.org, Oct 18 2017

Omri, what's the expected behavior here? 
If one side of the screen is occupied by a snapped window, and the other side is overview grid, and if the snapped window has a minimal size, can the user drag the divider to pass over the minimal bounds line to close the snapped window? Or we should not allow that? 
Cc: mccanny@chromium.org
Beyond the minimum bounds of the window it starts doing the fade-out animation (darkening app and minimizing viewable area as you drag) towards closing the app.

Ben, please correct me if I'm wrong.
That sounds right to me.

Comment 4 by x...@chromium.org, Oct 27 2017

Description: Show this description

Comment 5 by minch@chromium.org, Oct 28 2017

Status: Started (was: Assigned)
Summary: cros splitview - If there is only one snapped window, start doing the fade-out animation when the divider achieve the window's minimum size (was: cros splitview - If there is only one snapped window, do not allow the divider pass over its minimal bound line)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bfcbd34dee3edc1f2a6fbb07d5682023dfa32b0

commit 8bfcbd34dee3edc1f2a6fbb07d5682023dfa32b0
Author: MinChen <minch@chromium.org>
Date: Wed Nov 01 02:40:04 2017

Allowing the snapped window can be moved outside of work area.

Changes:
1. Allowing the snapped window that next to the origin of the work area
   can be moved outside of the bounds of work area.
2. Delete RestackWindows in SplitViewController, since left and right
   snapped window will not overlap now.

Bug:  775236 
Change-Id: Ib1d12443f8b9965544014590b8eff37ed8b3f665
Reviewed-on: https://chromium-review.googlesource.com/741489
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513052}
[modify] https://crrev.com/8bfcbd34dee3edc1f2a6fbb07d5682023dfa32b0/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/8bfcbd34dee3edc1f2a6fbb07d5682023dfa32b0/ash/wm/splitview/split_view_controller.h
[modify] https://crrev.com/8bfcbd34dee3edc1f2a6fbb07d5682023dfa32b0/ash/wm/splitview/split_view_controller_unittest.cc

Comment 7 by minch@chromium.org, Nov 1 2017

Status: Fixed (was: Started)

Sign in to add a comment