Cros splitview - Do not allow a window snap to a position where its size is smaller than the window's minimal size |
||||
Issue descriptionCurrently we have 3 fixed snapped position ratio: 0.33, 0.5, 0.67. But it's possible that a window's minimal width is larger than 0.33 * screen_width but smaller than 0.5 * screen_width (in landscape orientation). In this case we still allow the window enter into split view mode, but not allow it snap to a position that make its size smaller than its minimal size. - When the divider passes over the middle of the screen (or the window's minimal bounds), show the black scrim. - When the gesture is released, snap to a position where its size is larger than its minimal size.
,
Oct 16 2017
,
Oct 28 2017
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1d132951382f1189ea06d6e76be2f04f5db0a04 commit d1d132951382f1189ea06d6e76be2f04f5db0a04 Author: MinChen <minch@chromium.org> Date: Wed Nov 01 19:42:24 2017 Don't allow the window be snapped to a position that is smaller than its minimum size. Changes: 1. Update the optional divider ratios (0.33f, 0.67f) according to the minimum size of the snapped windows. 2. Show the black scrim when the divider passes over the window's minimum size. Test: SplitViewControllerTest.DividerPositionWithWindowMinimumSizeTest Bug: 775227 Change-Id: Ia7ca6b42639a2e8963d5bfb95eb449e520f048fa Reviewed-on: https://chromium-review.googlesource.com/735980 Commit-Queue: min c <minch@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#513222} [modify] https://crrev.com/d1d132951382f1189ea06d6e76be2f04f5db0a04/ash/wm/splitview/split_view_controller.cc [modify] https://crrev.com/d1d132951382f1189ea06d6e76be2f04f5db0a04/ash/wm/splitview/split_view_controller.h [modify] https://crrev.com/d1d132951382f1189ea06d6e76be2f04f5db0a04/ash/wm/splitview/split_view_controller_unittest.cc
,
Nov 1 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by x...@chromium.org
, Oct 16 2017