Make insets in ShelfWindowTargeter work correctly |
||||||
Issue descriptionShelfWindowTargeter may end up setting positive insets. Mus expects all insets to be zero or negative (anything else is ignored). Positive insets are effectively a hit test mask. There are two options here: 1. Wait for hit test work to be enabled, at which point the code in ShelfWindowTargeter to call to mus can be removed. 2. Have ShelfWindowTargeter set a hit test mask for the positive case. (1) is ideal, but I'm not sure what the timeline is to turn on hit test. Filing for completeness.
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bac1a9c478228a9a0df9c8ad24049499797ba75a commit bac1a9c478228a9a0df9c8ad24049499797ba75a Author: Scott Violet <sky@chromium.org> Date: Tue Oct 17 04:00:56 2017 chromeos: ensure insets are 0 or negative WindowTree::SetExtendedHitRegionForChildren() only takes negative values (or 0). Anything else is ignored (and logged) This code can go away once hit testing is in place, so in the mean time force positive values to zero. Additionally makes sure we only call to the server when something actually changed. BUG= 775223 TEST=none Change-Id: I92642c6ef7fc3effe6976e700d03af50bffc0ad8 Reviewed-on: https://chromium-review.googlesource.com/722069 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#509276} [modify] https://crrev.com/bac1a9c478228a9a0df9c8ad24049499797ba75a/ui/aura/window_targeter.cc [modify] https://crrev.com/bac1a9c478228a9a0df9c8ad24049499797ba75a/ui/aura/window_targeter.h [modify] https://crrev.com/bac1a9c478228a9a0df9c8ad24049499797ba75a/ui/wm/core/easy_resize_window_targeter.cc [modify] https://crrev.com/bac1a9c478228a9a0df9c8ad24049499797ba75a/ui/wm/core/easy_resize_window_targeter.h
,
Nov 3 2017
Ria, I'm passing your way given this is blocked on event targetting. If that isn't appropriate, let me know.
,
Nov 27 2017
,
Dec 13 2017
I'm going to implement this without hit testing for now.
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a024b0d37fcfc9e1411718f3bd0f3e9cb0e5442 commit 7a024b0d37fcfc9e1411718f3bd0f3e9cb0e5442 Author: Scott Violet <sky@chromium.org> Date: Thu Dec 14 07:22:57 2017 chromeos: makes EasyResizeWindowTargeter apply a hit mask if appropriate EasyResizeWindowTargeter may be used to shrink the region of a window you can interact with (the shelf uses this in certain modes). For mus we only support this with a hit-test mask. This patch wires up EasyResizeWindowTargeter to use a hit-test mask when necessary. BUG= 775223 TEST=covered by test Change-Id: I3e1b494e890f0f8366ce4a8a1fc64f839a61542f Reviewed-on: https://chromium-review.googlesource.com/826032 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#524019} [modify] https://crrev.com/7a024b0d37fcfc9e1411718f3bd0f3e9cb0e5442/ui/aura/mus/window_port_mus.cc [modify] https://crrev.com/7a024b0d37fcfc9e1411718f3bd0f3e9cb0e5442/ui/aura/mus/window_port_mus.h [modify] https://crrev.com/7a024b0d37fcfc9e1411718f3bd0f3e9cb0e5442/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/7a024b0d37fcfc9e1411718f3bd0f3e9cb0e5442/ui/aura/mus/window_tree_client.h [modify] https://crrev.com/7a024b0d37fcfc9e1411718f3bd0f3e9cb0e5442/ui/aura/mus/window_tree_host_mus.cc [modify] https://crrev.com/7a024b0d37fcfc9e1411718f3bd0f3e9cb0e5442/ui/aura/mus/window_tree_host_mus.h [modify] https://crrev.com/7a024b0d37fcfc9e1411718f3bd0f3e9cb0e5442/ui/aura/mus/window_tree_host_mus_delegate.h [modify] https://crrev.com/7a024b0d37fcfc9e1411718f3bd0f3e9cb0e5442/ui/aura/mus/window_tree_host_mus_unittest.cc [modify] https://crrev.com/7a024b0d37fcfc9e1411718f3bd0f3e9cb0e5442/ui/views/mus/desktop_window_tree_host_mus.cc [modify] https://crrev.com/7a024b0d37fcfc9e1411718f3bd0f3e9cb0e5442/ui/wm/BUILD.gn [modify] https://crrev.com/7a024b0d37fcfc9e1411718f3bd0f3e9cb0e5442/ui/wm/core/easy_resize_window_targeter.cc [modify] https://crrev.com/7a024b0d37fcfc9e1411718f3bd0f3e9cb0e5442/ui/wm/core/easy_resize_window_targeter.h [add] https://crrev.com/7a024b0d37fcfc9e1411718f3bd0f3e9cb0e5442/ui/wm/core/easy_resize_window_targeter_unittest.cc
,
Dec 14 2017
,
Jul 30
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sky@chromium.org
, Oct 16 2017