pack_firmware should use libcros_config_host |
|||||||
Issue descriptionNow that we have a Python library for host-based config access, we should use it in pack_firmware instead of direct FDT access
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/211ad147d19f7f93f1adf96e36a353d579c0139b commit 211ad147d19f7f93f1adf96e36a353d579c0139b Author: Simon Glass <sjg@chromium.org> Date: Tue Oct 31 17:42:04 2017 chromeos-config: Move default master config into library We should not have logic in the host tool for locating the master config since users of the library cannot access it. Move this code in to the library instead. Then both the host tool and any library clients can obtain the master configuration without providing an explicit config file. BUG= chromium:775220 TEST=(in chroot) ./run_tests Change-Id: Id0b4a933d1c7d9e99afe3261b1fc32fdcc3b0f2e Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/742476 [modify] https://crrev.com/211ad147d19f7f93f1adf96e36a353d579c0139b/chromeos-config/cros_config_host.py [modify] https://crrev.com/211ad147d19f7f93f1adf96e36a353d579c0139b/chromeos-config/libcros_config_host/libcros_config_host.py [modify] https://crrev.com/211ad147d19f7f93f1adf96e36a353d579c0139b/chromeos-config/libcros_config_host_unittest.py
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/b6ca70e7e6b69f530ef2b6d3f4e64b3a73d9bb03 commit b6ca70e7e6b69f530ef2b6d3f4e64b3a73d9bb03 Author: Simon Glass <sjg@chromium.org> Date: Tue Oct 31 22:15:18 2017 chromeos-config: Update the list-models command (v2) This command is currently implemented with (admittedly simple) logic in the CLI. We want all logic to be in the library itself, so that users of the library can have the same functions. Adjust the code for this, and enhance the command to support sorting the output (for reproducibility). BUG= chromium:775220 TEST=FEATURES=test sudo -E emerge --nodeps chromeos-config-tools Change-Id: I84c56f5bd41b6b0936ad30a627dd9fda3617a493 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/742475 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/b6ca70e7e6b69f530ef2b6d3f4e64b3a73d9bb03/chromeos-config/cros_config_host.py [modify] https://crrev.com/b6ca70e7e6b69f530ef2b6d3f4e64b3a73d9bb03/chromeos-config/libcros_config_host/libcros_config_host.py [modify] https://crrev.com/b6ca70e7e6b69f530ef2b6d3f4e64b3a73d9bb03/chromeos-config/cros_config_host_unittest.py [modify] https://crrev.com/b6ca70e7e6b69f530ef2b6d3f4e64b3a73d9bb03/chromeos-config/libcros_config_host_unittest.py
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/8ffea2a4704c3ed9d23b4a85ae8cbcf3611dc485 commit 8ffea2a4704c3ed9d23b4a85ae8cbcf3611dc485 Author: Simon Glass <sjg@chromium.org> Date: Wed Nov 01 00:31:02 2017 pack_firmware: Add initial use of libcros_config_host Now that this library is available and useful we should use it in this script instead of directly reading the master configuration. For now just open the config as a demonstration of how to do it. BUG= chromium:775220 TEST=PYTHONPATH=~/c python pack_firmware_unittest.py Change-Id: I260c80aab8f51a8f6847111584f24f4a4fec493d Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/742471 [modify] https://crrev.com/8ffea2a4704c3ed9d23b4a85ae8cbcf3611dc485/pack_firmware.py
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/8a7f3293ffbb22e4359cbaad1986b97fcd233823 commit 8a7f3293ffbb22e4359cbaad1986b97fcd233823 Author: Simon Glass <sjg@chromium.org> Date: Wed Nov 01 04:01:53 2017 pack_firmware: Accept a -L flag We plan to add a flag to enable 'legacy' mode for firmware updates, with the default mode being unibuild. This will allow us to drop the list of models passed into pack_firmware, since it can obtain it more easily from libcros_config_host. Add a -L flag which is currently ignored, so that we can start passing this flag from the ebuild. BUG= chromium:775220 TEST=emerge-reef-uni --nodeps chromeos-firmware-reef Change-Id: I87cada8184f581527f1e410122b2257ceeac0376 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/742377 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/8a7f3293ffbb22e4359cbaad1986b97fcd233823/pack_firmware.py
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/154c416ffd85aee4d33bb7f017583ed155ac7688 commit 154c416ffd85aee4d33bb7f017583ed155ac7688 Author: Simon Glass <sjg@chromium.org> Date: Fri Nov 03 03:47:11 2017 cros-firmware: Pass --legacy to pack_firmware for non-unibuild At present the firmware packer uses the presense of --models to detect that it should create a unibuild firmware update. We want to stop passing this list since it is a pain to create it in the ebuild, and we want the packer to always pack all firmware. As a starting point, pass this flag to pack_firmware when building a non-unbuild firmware update. BUG= chromium:775220 TEST=emerge-reef-uni --nodeps chromeos-firmware-reef emerge-reef --nodeps chromeos-firmware-reef Change-Id: I7d3d4e06a3f3805cd19b0195ff9daa94d3f66659 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/743181 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/154c416ffd85aee4d33bb7f017583ed155ac7688/eclass/cros-firmware.eclass
,
Nov 4 2017
,
Nov 4 2017
,
Nov 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1e3af13b2eeeaba828614d700b1c1b320f1e2cd5 commit 1e3af13b2eeeaba828614d700b1c1b320f1e2cd5 Author: Simon Glass <sjg@chromium.org> Date: Sun Nov 05 00:42:06 2017 cros-firmware: Pass --legacy for local firmware also We must pass this flag when generating local firmware as well, due to an arguments check in the firmware packer when using local firmware. BUG= chromium:775220 TEST=emerge-reef-uni --nodeps chromeos-firmware-reef Change-Id: I565621004e957ca383bc4ddd092ddef0a75124c4 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/754113 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/1e3af13b2eeeaba828614d700b1c1b320f1e2cd5/eclass/cros-firmware.eclass
,
Nov 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/8ee6e8201fdcad6dc82e8cc3968860b98ef0d959 commit 8ee6e8201fdcad6dc82e8cc3968860b98ef0d959 Author: Simon Glass <sjg@chromium.org> Date: Sun Nov 05 04:49:16 2017 pack_firmware: Get the model list from libcros_config_host We don't want to use the model list provided to us, since we want to drop this from cros-firmware.eclass. Update the firmware packer to obtain the model list itself, from libcros_config_host. BUG= chromium:775220 TEST=emerge-reef-uni --nodeps chromeos-firmware-reef Change-Id: I4aaf263bd65df01f0eb809b77f45223a65eeddfe Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/742378 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: Lann Martin <lannm@chromium.org> [modify] https://crrev.com/8ee6e8201fdcad6dc82e8cc3968860b98ef0d959/pack_firmware_functest.py [modify] https://crrev.com/8ee6e8201fdcad6dc82e8cc3968860b98ef0d959/pack_firmware.py [modify] https://crrev.com/8ee6e8201fdcad6dc82e8cc3968860b98ef0d959/pack_firmware_unittest.py
,
Nov 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8fc9760ef80facb7ab83e3f675b80f27f2a80b90 commit 8fc9760ef80facb7ab83e3f675b80f27f2a80b90 Author: Simon Glass <sjg@chromium.org> Date: Mon Nov 06 08:40:05 2017 cros-firmware: Don't pass the model list to pack_firmware Now that pack_firmware can obtain its own model list, don't bother passing one to it. BUG= chromium:775220 TEST=emerge-reef-uni --nodeps chromeos-firmware-reef Change-Id: I2396e646af7cb95c9aaea859374f188521b379fa Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/743182 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/8fc9760ef80facb7ab83e3f675b80f27f2a80b90/eclass/cros-firmware.eclass
,
Nov 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/cafd827c129ee1df7805418b4cc684a91a9a63e3 commit cafd827c129ee1df7805418b4cc684a91a9a63e3 Author: Simon Glass <sjg@chromium.org> Date: Mon Nov 06 08:40:06 2017 cros-firmware: Don't bother handling missing firmware We can drop this code now as the master configuration can always be assumed to tell us what to build, on ToT and firmware branches. If it does not, we want to generate an error. BUG= chromium:775220 TEST=emerge-reef-uni --nodeps chromeos-firmware-reef Change-Id: Ie031663d0b588cbe72be830b2e0ca7b8e2c75b87 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/743183 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/cafd827c129ee1df7805418b4cc684a91a9a63e3/eclass/cros-firmware.eclass
,
Nov 6 2017
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/b61618a6899b369c5c2836ff06d63d172512d819 commit b61618a6899b369c5c2836ff06d63d172512d819 Author: Simon Glass <sjg@chromium.org> Date: Fri Nov 10 03:16:37 2017 libcros_config: Add access to firmware information We want to adjust pack_firmware so that it does not directly read the master configuration itself, but rather go through CrosConfig. Add a function which figures out the information needed by the firmware packer and returns it. Some of the config has to be processed to produce the required fields. This should give us a good basis for adjusting the schema as needed. For example we want to support an alternative whitelabel schema. BUG= chromium:775220 TEST=PYTHONPATH=~/c python libcros_config_host/fdt_unittest.py Change-Id: Id201af1a1949ae4f8ef6ac7c408638ddb02be311 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/760441 Commit-Ready: Lann Martin <lannm@chromium.org> Tested-by: Lann Martin <lannm@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: Lann Martin <lannm@chromium.org> [modify] https://crrev.com/b61618a6899b369c5c2836ff06d63d172512d819/chromeos-config/libcros_config_host/libcros_config_host.py [modify] https://crrev.com/b61618a6899b369c5c2836ff06d63d172512d819/chromeos-config/libcros_config_host_unittest.py
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/ae4f9fe0a6cdabfa353007e0b6082e7c03e1ddd4 commit ae4f9fe0a6cdabfa353007e0b6082e7c03e1ddd4 Author: Simon Glass <sjg@chromium.org> Date: Fri Nov 10 14:51:05 2017 libcros_config: Add more property-access functions Add a few simple methods to access string lists and booleans. BUG= chromium:775220 TEST=PYTHONPATH=~/c python libcros_config_host/fdt_unittest.py Change-Id: Ic34c653b974bc00720472ef6a27ddfbc51b9103c Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/760440 Tested-by: Lann Martin <lannm@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/ae4f9fe0a6cdabfa353007e0b6082e7c03e1ddd4/chromeos-config/libcros_config/test.dts [modify] https://crrev.com/ae4f9fe0a6cdabfa353007e0b6082e7c03e1ddd4/chromeos-config/libcros_config_host/fdt_unittest.py [modify] https://crrev.com/ae4f9fe0a6cdabfa353007e0b6082e7c03e1ddd4/chromeos-config/libcros_config_host/libcros_config_host.py
,
Nov 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/4654a8b3e88b32da2cabbeecc5078edbee80305e commit 4654a8b3e88b32da2cabbeecc5078edbee80305e Author: Simon Glass <sjg@chromium.org> Date: Sun Nov 12 16:46:57 2017 pack_firmware: Get the script name from CrosConfig Use CrosConfig to obtain the firmware script name instead of digging in the config ourselves. BUG= chromium:775220 TEST=PYTHONPATH=~/c:~/c/src/platform2/chromeos-config \ python pack_firmware_unittest.py Change-Id: Ia79131ff6ca98b41a4097bafb33d2d3f0fe9d4e6 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/759876 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/4654a8b3e88b32da2cabbeecc5078edbee80305e/pack_firmware.py
,
Nov 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/4b4c5858cd26544abafbdcf89546e391f181bb17 commit 4b4c5858cd26544abafbdcf89546e391f181bb17 Author: Simon Glass <sjg@chromium.org> Date: Sun Nov 12 18:49:50 2017 pack_firmware: Drop the unused GetParentNode() This is not needed after recent feature additions. Drop it. BUG= chromium:775220 TEST=PYTHONPATH=~/c:~/c/src/platform2/chromeos-config \ python pack_firmware_unittest.py Change-Id: I12bac8ee007b9484462943333435fac4fee0aad1 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/759877 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/4b4c5858cd26544abafbdcf89546e391f181bb17/pack_firmware.py
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/6e708ed439f7123673e8a0d87384369ed9b79368 commit 6e708ed439f7123673e8a0d87384369ed9b79368 Author: Simon Glass <sjg@chromium.org> Date: Mon Nov 13 01:44:28 2017 chromeos-config: Adjust sig_id and add documentation The signature ID in the firmware updater's setvars.sh which used to indicate a zero-touch whitelabel is currently 'use-vpd'. But this has been changed to 'sig-id-in-customization-id' now. Update this and also add some missing documentation. BUG= chromium:775220 TEST=PYTHONPATH=~/c python libcros_config_host_unittest.py Change-Id: I14e7ba24951db88fa1e7951185a86bff3896282f Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/764959 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/6e708ed439f7123673e8a0d87384369ed9b79368/chromeos-config/libcros_config_host/libcros_config_host.py
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/6aab1aaacc7db993c4a4d92ea0c4308d26c5e9a5 commit 6aab1aaacc7db993c4a4d92ea0c4308d26c5e9a5 Author: Simon Glass <sjg@chromium.org> Date: Mon Nov 13 01:44:29 2017 chromeos-config: Switch test to zero-touch whitelabel Update the test to use this feature for whitetip. At present we have no test coverage on it, and we don't expect to use SKU IDs to distinguish white label devices. BUG= chromium:775220 TEST=PYTHONPATH=~/c python libcros_config_host_unittest.py Change-Id: I7913f850da7eddf657a81f8a5fc58043c6969675 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/764960 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/6aab1aaacc7db993c4a4d92ea0c4308d26c5e9a5/chromeos-config/libcros_config/test.dts [modify] https://crrev.com/6aab1aaacc7db993c4a4d92ea0c4308d26c5e9a5/chromeos-config/libcros_config_host_unittest.py
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/f51b42d53fee105c393ff88c38fe53430d46e0ce commit f51b42d53fee105c393ff88c38fe53430d46e0ce Author: Simon Glass <sjg@chromium.org> Date: Mon Nov 13 01:44:29 2017 chromeos-config: Refactor firmware test to reduce duplication Pull out the common fields into a separate variable so we don't need to specify them each time. BUG= chromium:775220 TEST=PYTHONPATH=~/c python libcros_config_host_unittest.py Change-Id: I3d70fe4b1262487217b5ba0990838534256301ad Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/764961 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/f51b42d53fee105c393ff88c38fe53430d46e0ce/chromeos-config/libcros_config_host_unittest.py
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/5263d33b32fcd20420c5f9d00d0299a7c69418c2 commit 5263d33b32fcd20420c5f9d00d0299a7c69418c2 Author: Simon Glass <sjg@chromium.org> Date: Mon Nov 13 06:15:00 2017 pack_firmware: Switch over to using libcros_config_host Use the new firmware info feature in libcros_config_host instead of reading the master config in this tool. This provides us with some separation from the schema format. BUG= chromium:775220 TEST=Run pack_firmware_functest.py and pack_firmware_unittest.py Change-Id: I732f034314270e9b5d2733277e1bf6dac8ca9ede Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/759879 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/5263d33b32fcd20420c5f9d00d0299a7c69418c2/pack_firmware_unittest.py [modify] https://crrev.com/5263d33b32fcd20420c5f9d00d0299a7c69418c2/pack_firmware.py
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/29f7925bdbc9f95ec110c93b39ec69cdd1c8c975 commit 29f7925bdbc9f95ec110c93b39ec69cdd1c8c975 Author: Simon Glass <sjg@chromium.org> Date: Mon Nov 13 06:15:00 2017 pack_firmware: Drop direct use of config We don't use the master configuration directly now, so drop all reference to it. BUG= chromium:775220 TEST=Run pack_firmware_functest.py and pack_firmware_unittest.py Change-Id: I944c5ea81247938d7bd5011550fae92018b2e168 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/759880 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/29f7925bdbc9f95ec110c93b39ec69cdd1c8c975/pack_firmware_unittest.py [modify] https://crrev.com/29f7925bdbc9f95ec110c93b39ec69cdd1c8c975/pack_firmware.py
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/c2349c6b91223869292faefcb694787d053ed7e3 commit c2349c6b91223869292faefcb694787d053ed7e3 Author: Simon Glass <sjg@chromium.org> Date: Tue Nov 14 08:42:45 2017 pack_firmware: Obtain all instructions from CrosConfig Rather than requesting the firmware information by model, required it all in one chunk and process it. This allows CrosConfig more control over what is processed. BUG= chromium:775220 TEST=Run pack_firmware_functest.py and pack_firmware_unittest.py Change-Id: I24228197215501be8e89b8f7e8d2cfbca30d0bdf Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/766519 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: C Shapiro <shapiroc@google.com> [modify] https://crrev.com/c2349c6b91223869292faefcb694787d053ed7e3/pack_firmware.py
,
Nov 17 2017
,
Nov 17 2017
This is done now I think
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/384f52c6dccf55b5d5bdc54513c6a5b4878b806d commit 384f52c6dccf55b5d5bdc54513c6a5b4878b806d Author: Simon Glass <sjg@chromium.org> Date: Mon Dec 11 09:01:56 2017 chromeos-config: Adjust sig_id and add documentation The signature ID in the firmware updater's setvars.sh which used to indicate a zero-touch whitelabel is currently 'use-vpd'. But this has been changed to 'sig-id-in-customization-id' now. Update this and also add some missing documentation. BUG= chromium:775220 TEST=PYTHONPATH=~/c python libcros_config_host_unittest.py Change-Id: I14e7ba24951db88fa1e7951185a86bff3896282f Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/764959 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/794065 Commit-Queue: Marco Chen <marcochen@chromium.org> Tested-by: Marco Chen <marcochen@chromium.org> [modify] https://crrev.com/384f52c6dccf55b5d5bdc54513c6a5b4878b806d/chromeos-config/libcros_config_host/libcros_config_host.py
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/3a03d2a1ceb031879748a7ceda48a61407de6a24 commit 3a03d2a1ceb031879748a7ceda48a61407de6a24 Author: Simon Glass <sjg@chromium.org> Date: Mon Dec 11 09:01:56 2017 pack_firmware: Drop the unused GetParentNode() This is not needed after recent feature additions. Drop it. BUG= chromium:775220 TEST=PYTHONPATH=~/c:~/c/src/platform2/chromeos-config \ python pack_firmware_unittest.py Change-Id: I12bac8ee007b9484462943333435fac4fee0aad1 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/759877 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/794602 Commit-Queue: Marco Chen <marcochen@chromium.org> Tested-by: Marco Chen <marcochen@chromium.org> [modify] https://crrev.com/3a03d2a1ceb031879748a7ceda48a61407de6a24/pack_firmware.py
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/6d1138427da88b6f0d558570051e2a0b041d224b commit 6d1138427da88b6f0d558570051e2a0b041d224b Author: Simon Glass <sjg@chromium.org> Date: Mon Dec 11 09:02:00 2017 chromeos-config: Switch test to zero-touch whitelabel Update the test to use this feature for whitetip. At present we have no test coverage on it, and we don't expect to use SKU IDs to distinguish white label devices. BUG= chromium:775220 TEST=PYTHONPATH=~/c python libcros_config_host_unittest.py Change-Id: I7913f850da7eddf657a81f8a5fc58043c6969675 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/764960 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/794066 Commit-Queue: Marco Chen <marcochen@chromium.org> Tested-by: Marco Chen <marcochen@chromium.org> [modify] https://crrev.com/6d1138427da88b6f0d558570051e2a0b041d224b/chromeos-config/libcros_config/test.dts [modify] https://crrev.com/6d1138427da88b6f0d558570051e2a0b041d224b/chromeos-config/libcros_config_host_unittest.py
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/301496f4184a060721013215a4b7a4a56d64a785 commit 301496f4184a060721013215a4b7a4a56d64a785 Author: Simon Glass <sjg@chromium.org> Date: Mon Dec 11 09:02:03 2017 chromeos-config: Refactor firmware test to reduce duplication Pull out the common fields into a separate variable so we don't need to specify them each time. BUG= chromium:775220 TEST=PYTHONPATH=~/c python libcros_config_host_unittest.py Change-Id: I3d70fe4b1262487217b5ba0990838534256301ad Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/764961 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/794067 Commit-Queue: Marco Chen <marcochen@chromium.org> Tested-by: Marco Chen <marcochen@chromium.org> [modify] https://crrev.com/301496f4184a060721013215a4b7a4a56d64a785/chromeos-config/libcros_config_host_unittest.py
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/06b60174952ce42f750ae78c04b2e539085c0362 commit 06b60174952ce42f750ae78c04b2e539085c0362 Author: Simon Glass <sjg@chromium.org> Date: Mon Dec 11 09:02:11 2017 pack_firmware: Switch over to using libcros_config_host Use the new firmware info feature in libcros_config_host instead of reading the master config in this tool. This provides us with some separation from the schema format. BUG= chromium:775220 TEST=Run pack_firmware_functest.py and pack_firmware_unittest.py Change-Id: I732f034314270e9b5d2733277e1bf6dac8ca9ede Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/759879 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/794604 Commit-Queue: Marco Chen <marcochen@chromium.org> Tested-by: Marco Chen <marcochen@chromium.org> [modify] https://crrev.com/06b60174952ce42f750ae78c04b2e539085c0362/pack_firmware_unittest.py [modify] https://crrev.com/06b60174952ce42f750ae78c04b2e539085c0362/pack_firmware.py
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/969e4edb9c2b844cdae4f23131ba2132ecc54005 commit 969e4edb9c2b844cdae4f23131ba2132ecc54005 Author: Simon Glass <sjg@chromium.org> Date: Mon Dec 11 09:02:13 2017 pack_firmware: Drop direct use of config We don't use the master configuration directly now, so drop all reference to it. BUG= chromium:775220 TEST=Run pack_firmware_functest.py and pack_firmware_unittest.py Change-Id: I944c5ea81247938d7bd5011550fae92018b2e168 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/759880 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/794605 Commit-Queue: Marco Chen <marcochen@chromium.org> Tested-by: Marco Chen <marcochen@chromium.org> [modify] https://crrev.com/969e4edb9c2b844cdae4f23131ba2132ecc54005/pack_firmware_unittest.py [modify] https://crrev.com/969e4edb9c2b844cdae4f23131ba2132ecc54005/pack_firmware.py
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/bf28a09f0f64455e4e6011c20c6a7d8ad71e06ed commit bf28a09f0f64455e4e6011c20c6a7d8ad71e06ed Author: Simon Glass <sjg@chromium.org> Date: Mon Dec 11 09:06:25 2017 pack_firmware: Obtain all instructions from CrosConfig Rather than requesting the firmware information by model, required it all in one chunk and process it. This allows CrosConfig more control over what is processed. BUG= chromium:775220 TEST=Run pack_firmware_functest.py and pack_firmware_unittest.py Change-Id: I24228197215501be8e89b8f7e8d2cfbca30d0bdf Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/766519 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: C Shapiro <shapiroc@google.com> Reviewed-on: https://chromium-review.googlesource.com/794606 Commit-Queue: Marco Chen <marcochen@chromium.org> Tested-by: Marco Chen <marcochen@chromium.org> [modify] https://crrev.com/bf28a09f0f64455e4e6011c20c6a7d8ad71e06ed/pack_firmware.py |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Oct 31 2017