[MD settings] local data will sometimes show a double scroll bar |
|||||||
Issue descriptionIn chrome://settings/localData there should be one scroll bar on the far right of the page. Occasionally an additional scroll bar will be shown on the iron-list as well. The scroll bar on the iron-list within the card should not show.
,
Oct 17 2017
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13ea87b2521c7d21cf5f9d7e1fd5bea64ca428f2 commit 13ea87b2521c7d21cf5f9d7e1fd5bea64ca428f2 Author: Dave Schuyler <dschuyler@chromium.org> Date: Tue Oct 17 19:19:58 2017 [MD settings] fix scrolling in siteData page. This CL applies GlobalScrollTargetBehavior to the siteData iron-list so that the list only shows one scroll bar (rather than two) and the list scrolls properly. Bug: 775215 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7b21f099446dabdf3e356dd66898352d8bc73610 Reviewed-on: https://chromium-review.googlesource.com/722340 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#509480} [modify] https://crrev.com/13ea87b2521c7d21cf5f9d7e1fd5bea64ca428f2/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp [modify] https://crrev.com/13ea87b2521c7d21cf5f9d7e1fd5bea64ca428f2/chrome/browser/resources/settings/site_settings/site_data.html [modify] https://crrev.com/13ea87b2521c7d21cf5f9d7e1fd5bea64ca428f2/chrome/browser/resources/settings/site_settings/site_data.js
,
Oct 18 2017
Please add appropriate OSs.
,
Oct 18 2017
,
Oct 18 2017
,
Oct 19 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 19 2017
Please merge your change to M63 branch 3239 by 4:00 PM PT today, Thursday so we can take it in for next M63 dev release. Thank you.
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f1546d60ed4a9efe71031649a2eee17b24ec25f commit 2f1546d60ed4a9efe71031649a2eee17b24ec25f Author: Dave Schuyler <dschuyler@chromium.org> Date: Thu Oct 19 18:23:18 2017 [MD settings] fix scrolling in siteData page. This CL applies GlobalScrollTargetBehavior to the siteData iron-list so that the list only shows one scroll bar (rather than two) and the list scrolls properly. Bug: 775215 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7b21f099446dabdf3e356dd66898352d8bc73610 Reviewed-on: https://chromium-review.googlesource.com/722340 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509480}(cherry picked from commit 13ea87b2521c7d21cf5f9d7e1fd5bea64ca428f2) Reviewed-on: https://chromium-review.googlesource.com/728402 Cr-Commit-Position: refs/branch-heads/3239@{#77} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/2f1546d60ed4a9efe71031649a2eee17b24ec25f/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp [modify] https://crrev.com/2f1546d60ed4a9efe71031649a2eee17b24ec25f/chrome/browser/resources/settings/site_settings/site_data.html [modify] https://crrev.com/2f1546d60ed4a9efe71031649a2eee17b24ec25f/chrome/browser/resources/settings/site_settings/site_data.js
,
Oct 19 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dschuyler@chromium.org
, Oct 17 2017