New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775212 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue angleproject:2188



Sign in to add a comment

Command buffer decoder micro-benchmark

Project Member Reported by piman@chromium.org, Oct 16 2017

Issue description

Write a micro-benchmark to measure performance and overhead of command buffer decoders using various options (GLES2DecoderImpl + GL, GLES2DecoderImpl + ANGLE, GLES2DecoderPasstrhoughImpl + ANGLE, possibly stubbing out the driver). Goals:
1- measure performance of various options
2- measure overhead of command buffers vs driver
3- provide an isolated benchmark to find optimization opportunities using benchmarking tools (e.g. linux-perf, vtune, etc.)

It is possible to write a CommandBuffer implementation that would provide a way to record and replay stateless/idempotent command streams.

 

Comment 1 by piman@chromium.org, Oct 16 2017

Cc: geoffl...@chromium.org vmi...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/739de36a178fecbb92f4aebe4ee478cbacb9e212

commit 739de36a178fecbb92f4aebe4ee478cbacb9e212
Author: Antoine Labour <piman@chromium.org>
Date: Tue Oct 17 03:49:00 2017

Introduce DecoderPerfTest

This is a microbenchmark that measures the raw throughput of the GLES2 decoders.

Bug:  775212 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic701af8c5e83a5eee347f481ee5319dfa6fc0ffc
Reviewed-on: https://chromium-review.googlesource.com/719462
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509270}
[modify] https://crrev.com/739de36a178fecbb92f4aebe4ee478cbacb9e212/gpu/BUILD.gn
[modify] https://crrev.com/739de36a178fecbb92f4aebe4ee478cbacb9e212/gpu/command_buffer/service/command_buffer_direct.h
[modify] https://crrev.com/739de36a178fecbb92f4aebe4ee478cbacb9e212/gpu/command_buffer/service/command_buffer_service.h
[add] https://crrev.com/739de36a178fecbb92f4aebe4ee478cbacb9e212/gpu/command_buffer/tests/decoder_perftest.cc
[modify] https://crrev.com/739de36a178fecbb92f4aebe4ee478cbacb9e212/gpu/perftests/run_all_tests.cc
[modify] https://crrev.com/739de36a178fecbb92f4aebe4ee478cbacb9e212/gpu/perftests/texture_upload_perftest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a33566861a91e696b373cf8b05be7a4509c509c

commit 8a33566861a91e696b373cf8b05be7a4509c509c
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Tue Oct 17 05:31:10 2017

Revert "Introduce DecoderPerfTest"

This reverts commit 739de36a178fecbb92f4aebe4ee478cbacb9e212.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 509270 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzczOWRlMzZhMTc4ZmVjYmI5MmY0YWViZTRlZTQ3OGNiYWNiOWUyMTIM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Mac/33774

Original change's description:
> Introduce DecoderPerfTest
> 
> This is a microbenchmark that measures the raw throughput of the GLES2 decoders.
> 
> Bug:  775212 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Ic701af8c5e83a5eee347f481ee5319dfa6fc0ffc
> Reviewed-on: https://chromium-review.googlesource.com/719462
> Commit-Queue: Antoine Labour <piman@chromium.org>
> Reviewed-by: Victor Miura <vmiura@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#509270}

Change-Id: Ic43322e66b1968ab2a8e30de6c20e7935f528e64
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  775212 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/721894
Cr-Commit-Position: refs/heads/master@{#509280}
[modify] https://crrev.com/8a33566861a91e696b373cf8b05be7a4509c509c/gpu/BUILD.gn
[modify] https://crrev.com/8a33566861a91e696b373cf8b05be7a4509c509c/gpu/command_buffer/service/command_buffer_direct.h
[modify] https://crrev.com/8a33566861a91e696b373cf8b05be7a4509c509c/gpu/command_buffer/service/command_buffer_service.h
[delete] https://crrev.com/017a9d867cd706c0d4112edb08b506f6bd43664a/gpu/command_buffer/tests/decoder_perftest.cc
[modify] https://crrev.com/8a33566861a91e696b373cf8b05be7a4509c509c/gpu/perftests/run_all_tests.cc
[modify] https://crrev.com/8a33566861a91e696b373cf8b05be7a4509c509c/gpu/perftests/texture_upload_perftest.cc

Cc: jmad...@chromium.org
Blocking: angleproject:2188
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6ade2549eae4bd912c23c1887979404aa83de13

commit c6ade2549eae4bd912c23c1887979404aa83de13
Author: Antoine Labour <piman@chromium.org>
Date: Thu Oct 19 01:01:16 2017

Reland: Introduce DecoderPerfTest

This is a microbenchmark that measures the raw throughput of the GLES2 decoders.

Bug:  775212 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ifbb183c51c498dc497e273b59d6c79849969d021
Reviewed-on: https://chromium-review.googlesource.com/723799
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509954}
[modify] https://crrev.com/c6ade2549eae4bd912c23c1887979404aa83de13/BUILD.gn
[modify] https://crrev.com/c6ade2549eae4bd912c23c1887979404aa83de13/gpu/BUILD.gn
[modify] https://crrev.com/c6ade2549eae4bd912c23c1887979404aa83de13/gpu/command_buffer/service/command_buffer_direct.h
[modify] https://crrev.com/c6ade2549eae4bd912c23c1887979404aa83de13/gpu/command_buffer/service/command_buffer_service.h
[add] https://crrev.com/c6ade2549eae4bd912c23c1887979404aa83de13/gpu/command_buffer/tests/decoder_perftest.cc
[modify] https://crrev.com/c6ade2549eae4bd912c23c1887979404aa83de13/gpu/perftests/run_all_tests.cc
[modify] https://crrev.com/c6ade2549eae4bd912c23c1887979404aa83de13/gpu/perftests/texture_upload_perftest.cc

Comment 7 by piman@chromium.org, Oct 19 2017

Status: Fixed (was: Started)
We can add test cases, but the infra is there.

Comment 8 by kbr@chromium.org, May 10 2018

Cc: danakj@chromium.org piman@chromium.org aelias@chromium.org kbr@chromium.org enne@chromium.org shannonwoods@chromium.org
 Issue 339251  has been merged into this issue.

Sign in to add a comment