Changing the extent of a radial-gradient doesn't do anything
Reported by
abor...@hotmail.com,
Oct 16 2017
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36 Steps to reproduce the problem: 1. Go to https://jsfiddle.net/0vdmp23o/ 2. Click "Changed extent" to change only the extent keyword of the gradient. 3. Observe that nothing changes. 4. Click any of the last two buttons, and then back to "Changed extent". The gradient is now correct. What is the expected behavior? What went wrong? While trying to build a radial-gradient generator, I noticed that changing only the extent keyword on a radial-gradient doesn't update the background on an element. In this JSFiddle (https://jsfiddle.net/0vdmp23o/), toggling between "Original"/"Changed extent", or between "Changed shape"/"Changed extent+shape" doesn't update the gradient (because the only part that changes is the extent). Toggling between any other combination of buttons does update the gradient as expected. Did this work before? N/A Does this work in other browsers? Yes Chrome version: 61.0.3163.100 Channel: stable OS Version: 10.0 Flash Version:
,
Oct 17 2017
,
Oct 17 2017
Able to reproduce the issue on the reported chrome version stable 61.0.3163.100 and on the latest canary 64.0.3241.0 on Ubuntu 14.04, Windows10 and on Mac 10.12.6. As the issue is seen from M50[50.0.2634.0] triaging this as non-regression, hence marking it as untriaged.
,
Oct 17 2017
,
Oct 17 2017
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd46dbc8a70160b9d8cd416a10d3cb8d4bf0cf96 commit bd46dbc8a70160b9d8cd416a10d3cb8d4bf0cf96 Author: Fredrik Söderquist <fs@opera.com> Date: Wed Oct 18 08:49:18 2017 Fix size keyword comparison in CSSRadialGradientValue::Equals Said function would ignore any size keyword or explicit size specification if there was a shape keyword. Adjust the comparisons so that first any explicit size checked, followed by checking the size keyword and the shape value. Also rewrite the if-ladder for the center point (|first_x_| and |first_y_|) to just use two DataEquivalent. Bug: 775201 Change-Id: I44686b54d3e02e1fd4682c4288eec3aca0e3e441 Reviewed-on: https://chromium-review.googlesource.com/723460 Reviewed-by: meade_UTC10 <meade@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#509718} [modify] https://crrev.com/bd46dbc8a70160b9d8cd416a10d3cb8d4bf0cf96/third_party/WebKit/Source/core/BUILD.gn [modify] https://crrev.com/bd46dbc8a70160b9d8cd416a10d3cb8d4bf0cf96/third_party/WebKit/Source/core/css/CSSGradientValue.cpp [add] https://crrev.com/bd46dbc8a70160b9d8cd416a10d3cb8d4bf0cf96/third_party/WebKit/Source/core/css/CSSGradientValueTest.cpp
,
Oct 18 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ligim...@chromium.org
, Oct 16 2017