New issue
Advanced search Search tips

Issue 775179 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Import now failing due to lint error in service-workers/.../resource-timing-worker.js

Project Member Reported by qyears...@chromium.org, Oct 16 2017

Issue description

Example log:
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.infra.cron%2Fwpt-importer%2F3341%2F%2B%2Frecipes%2Fsteps%2FImport_changes_from_WPT_to_Chromium%2F0%2Fstdout

Log excerpt:
Traceback (most recent call last):
  File "/mnt/data/b/rr/tmp_JTMS4/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 25, in <module>
    main()
  File "/mnt/data/b/rr/tmp_JTMS4/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 18, in main
    host.exit(importer.main())
  File "/mnt/data/b/rr/tmp_JTMS4/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 130, in main
    self._upload_cl()
  File "/mnt/data/b/rr/tmp_JTMS4/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 441, in _upload_cl
    'robertma@chromium.org',
  File "/mnt/data/b/rr/tmp_JTMS4/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py", line 51, in run
    return self._host.executive.run_command(command, cwd=self._cwd)
  File "/mnt/data/b/rr/tmp_JTMS4/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 326, in run_command
    (error_handler or self.default_error_handler)(script_error)
  File "/mnt/data/b/rr/tmp_JTMS4/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 234, in default_error_handler
    raise error
webkitpy.common.system.executive.ScriptError: Failed to run "['git', 'cl', 'upload', '-f', '--gerrit', '-m', u'Import wpt@e54fe8fd5fe185ff422811b075de3de1fdc1c9ba\n\nUsing wpt-import in Chromium 5da6600b57b7644f3c7d1269c797874f4396405c.\n\nBuild: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/3341\n\nNote to sheriffs: This CL imports external tests and adds\nexpectations for those tests; if this CL is large and causes\na few new failures, please fix the failures by adding new\nlines to TestExpectations rather than reverting. See:\nhttps://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md\n\nDirectory owners for changes in this CL:\ndcheng@chromium.org, scottmg@chromium.org:\n  external/wpt/domparsing\necobos@igalia.com:\n  external/wpt/css/css-display-3\njsbell@chromium.org:\n  external/wpt/IndexedDB\nmeade@chromium.org:\n  external/wpt/web-animations\nrego@igalia.com:\n  external/wpt/css/selectors4\nworker-dev@chromium.org:\n  external/wpt/service-workers\n\nNo-Export: true', '--tbrs', 'qyearsley@chromium.org', '--cc', 'robertma@chromium.org']" exit_code: 1
output: Last 500 characters of output:
ixing a particular error, it's sometimes
OK to add a line to the lint.whitelist file in the root of the
web-platform-tests directory to make the lint tool ignore it.
For example, to make the lint tool ignore all 'SET TIMEOUT'
errors in the service-workers/service-worker/resources/resource-timing-worker.js file,
you could add the following line to the lint.whitelist file.
SET TIMEOUT:service-workers/service-worker/resources/resource-timing-worker.js
Presubmit checks took 32.5s to calculate.
 
Status: Started (was: Assigned)
PR: https://github.com/w3c/web-platform-tests/pull/7852
Status: Fixed (was: Started)
Was fixed.

Sign in to add a comment