New issue
Advanced search Search tips

Issue 775177 link

Starred by 1 user
Status: Fixed
Owner:
msw@chromium.org
Closed: Feb 2018
Cc:
jamescook@chromium.org
sky@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Convert mus and mash test early exits to filter file exclusions.

Project Member Reported by msw@chromium.org, Oct 16 2017 
Convert mus and mash test early returns to filter file exclusions.

We have a number of tests that exit early based on the ash::Config. eg:
  if (Shell::GetAshConfig() == Config::MASH)
    return;

Most of these should be converted to filter file entries instead, see:
 testing/buildbot/filters/ash_unittests_mash.filter
 testing/buildbot/filters/ash_unittests_mus.filter
 testing/buildbot/filters/mash.browser_tests.filter
 testing/buildbot/filters/mojo.fyi.mus.browser_tests.filter
 testing/buildbot/filters/mojo.fyi.single.mash.browser_tests.filter
 testing/buildbot/filters/mus.browser_tests.filter
 testing/buildbot/filters/single.mash.browser_tests.filter

Early exits are okay for tests that are not applicable to a config, etc.
(filter files should be used to track failing tests that need attention)

I'm actively auditing early exits and addressing this issue now.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1de4bccb0ea32f5c5bd82d7d48553c11f88659a3

commit 1de4bccb0ea32f5c5bd82d7d48553c11f88659a3
Author: Mike Wasserman <msw@chromium.org>
Date: Thu Oct 19 01:24:16 2017

mash: Fix and enable AppListButton unit test.

The app list button test should start drags on the app list button.
It was actually targetting the ShelfBezelEventHandler.
Fix and enable the test, make other cleanup changes.

Enable ShelfLayoutManager test fixtures that work as-is in mash.
Move remaining ShelfLayoutManager test failures to filter file.

Bug:  695686 ,  775177 
Change-Id: I7638c6294bc8ce6e2c6b91d459d462a5b357db5d
Reviewed-on: https://chromium-review.googlesource.com/723863
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509959}
[modify] https://crrev.com/1de4bccb0ea32f5c5bd82d7d48553c11f88659a3/ash/shelf/app_list_button_unittest.cc
[modify] https://crrev.com/1de4bccb0ea32f5c5bd82d7d48553c11f88659a3/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/1de4bccb0ea32f5c5bd82d7d48553c11f88659a3/testing/buildbot/filters/ash_unittests_mash.filter
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67827ab7ae7a329bcb7aa10fab37154f58363db3

commit 67827ab7ae7a329bcb7aa10fab37154f58363db3
Author: Mike Wasserman <msw@chromium.org>
Date: Wed Feb 07 00:29:54 2018

Enable shelf and panel ash_unittests in mash

These tests appear to pass as-is on ToT @ #534716.

Bug:  695563 ,  698887 ,  775177 
Test: Automated
Change-Id: I6d3979aec6738e4d14c2119faa3488d0ee1c596e
Reviewed-on: https://chromium-review.googlesource.com/905687
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534850}
[modify] https://crrev.com/67827ab7ae7a329bcb7aa10fab37154f58363db3/ash/shelf/shelf_tooltip_manager_unittest.cc
[modify] https://crrev.com/67827ab7ae7a329bcb7aa10fab37154f58363db3/ash/wm/panels/panel_layout_manager_unittest.cc

Comment 3 by msw@chromium.org, Feb 7 2018

Status: Fixed (was: Started)
I'm going to mark this generally fixed, (James did the vast majority of the work).
Most of the remaining early exits are for config-specific features, or they really limit the scope of an otherwise valid test.
►

Sign in to add a comment