New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 775168 link

Starred by 1 user
Status: Fixed
Owner:
█ huangml@chromium.org
Last visit > 30 days ago
Closed: May 2018
Cc:
█ baxley@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Improve iOS CQ test coverage

Project Member Reported by huangml@chromium.org, Oct 16 2017 
iOS are running mostly unittests on CQ. We want to add full EarlGrey test coverage on CQ. However there're large amounts of EG tests,  and the CQ has capacity issues.

Some proposals:
1.  Unit tests are running on CQ under different type of simulator configurations.  Reduce the configurations and put them on main waterfall but not CQ bot.
2. Improve EG test shards.
3. Consider applying multi-simulators.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a7dd7a8debbd56dc3cd6a9d3511fd85d7538c1b

commit 6a7dd7a8debbd56dc3cd6a9d3511fd85d7538c1b
Author: Menglu Huang <huangml@chromium.org>
Date: Wed Oct 18 20:28:54 2017

Create an empty config for the new-added bot to split ios-simulator.

The new bot would run tests with multiple simulator configurations.

Bug:  775168 
Change-Id: I6a852b880097317557cca16b4bb345d39467d5be
Reviewed-on: https://chromium-review.googlesource.com/721841
Commit-Queue: Menglu Huang <huangml@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509853}
[add] https://crrev.com/6a7dd7a8debbd56dc3cd6a9d3511fd85d7538c1b/ios/build/bots/chromium.mac/ios-simulator-full-configs.json
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/174f62e715dac60da5cbc05472529b6b9d5e577e

commit 174f62e715dac60da5cbc05472529b6b9d5e577e
Author: Menglu Huang <huangml@chromium.org>
Date: Wed Oct 18 21:50:13 2017

Add a new iOS main waterfall bot to hold tests under different simulator configs.

The new bot is supposed to hold the tests split from ios-simulator bot.  We're
going to reduce the simulator configurations on ios-simulator and put on the 
new one.

Bug:775168
Change-Id: I81384ac7844038ad4d3a279fe9f4605cf3c529a6
Reviewed-on: https://chromium-review.googlesource.com/721611
Commit-Queue: Menglu Huang <huangml@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>

[modify] https://crrev.com/174f62e715dac60da5cbc05472529b6b9d5e577e/masters/master.tryserver.chromium.mac/master.cfg
[modify] https://crrev.com/174f62e715dac60da5cbc05472529b6b9d5e577e/tests/masters_recipes_test.py
[modify] https://crrev.com/174f62e715dac60da5cbc05472529b6b9d5e577e/masters/master.tryserver.chromium.mac/slaves.cfg
[modify] https://crrev.com/174f62e715dac60da5cbc05472529b6b9d5e577e/masters/master.chromium.mac/slaves.cfg
[modify] https://crrev.com/174f62e715dac60da5cbc05472529b6b9d5e577e/masters/master.chromium.mac/master_ios_cfg.py

Comment 3 by kkhorimoto@chromium.org, Oct 19 2017

Components: Infra>Client>Chrome
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/dacf606382555b098d7a2e18f7fe9f617622ed87

commit dacf606382555b098d7a2e18f7fe9f617622ed87
Author: Menglu Huang <huangml@chromium.org>
Date: Fri Oct 27 00:29:19 2017

Add ios-simulator-full-configs bot to branch scheduler.

Bug:775168
Change-Id: Icd2f45ba77f2963d9bef6a360e60867a08fbecdb
Reviewed-on: https://chromium-review.googlesource.com/739223
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>

[modify] https://crrev.com/dacf606382555b098d7a2e18f7fe9f617622ed87/masters/master.chromium.mac/master_ios_cfg.py
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed84a8aeabdf334cfd6007a9e6b9449c7d52e4f1

commit ed84a8aeabdf334cfd6007a9e6b9449c7d52e4f1
Author: Menglu Huang <huangml@chromium.org>
Date: Mon Nov 06 19:57:09 2017

Move earlgrey tests from FYI to main waterfall

Move tests around in upstream bot configuration files. Move eg 
tests to run on main waterfall.

1. Put EG test suite not running on cq right now into 
eg_tests.json.  Rename the eg tests running on cq as
eg_cq_tests.json
2. Run non-cq egtests with iPhone6s Plus iOS11, iPhone 7 iOS10, 
iPad Air2 iOS10&11 and iPhone X iOS11 on main waterfall bot 
ios-simulator-full-configs
3. Run cq egtests on iPad Air2 iOS10 on ios-simulator-full-configs
4. Update cq tests to run on iOS10 instead of 9
5. Keep integration tests with add credential manager flag
in FYI
6. Remove the other tests on FYI EarlGreyiOS and ios-simulator

Bug:  775168 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I935b3178d3cda96808fe28a4d06e8a37a14139f6
Reviewed-on: https://chromium-review.googlesource.com/752508
Commit-Queue: Menglu Huang <huangml@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514214}
[modify] https://crrev.com/ed84a8aeabdf334cfd6007a9e6b9449c7d52e4f1/ios/build/bots/chromium.fyi/EarlGreyiOS.json
[modify] https://crrev.com/ed84a8aeabdf334cfd6007a9e6b9449c7d52e4f1/ios/build/bots/chromium.fyi/ios-simulator.json
[modify] https://crrev.com/ed84a8aeabdf334cfd6007a9e6b9449c7d52e4f1/ios/build/bots/chromium.mac/ios-simulator-full-configs.json
[modify] https://crrev.com/ed84a8aeabdf334cfd6007a9e6b9449c7d52e4f1/ios/build/bots/chromium.mac/ios-simulator.json
[add] https://crrev.com/ed84a8aeabdf334cfd6007a9e6b9449c7d52e4f1/ios/build/bots/tests/eg_cq_tests.json
[modify] https://crrev.com/ed84a8aeabdf334cfd6007a9e6b9449c7d52e4f1/ios/build/bots/tests/eg_tests.json
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd38fc781ea3718f304fdb7a965f8f9a402a1a11

commit dd38fc781ea3718f304fdb7a965f8f9a402a1a11
Author: Menglu Huang <huangml@chromium.org>
Date: Wed Nov 08 20:53:22 2017

Split Bookmarks egtests out of ios_chrome_ui_egtests

ios_chrome_ui_egtests take ~38min to run on bots.  Split
Bookmarks tests out to reduce the suite size an improve 
swarming.

Bug:  775168 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib47fd165b3d6eb43f14079d3f20dd4ab248ec3f6
Reviewed-on: https://chromium-review.googlesource.com/756198
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Reviewed-by: Marti Wong <martiw@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514931}
[modify] https://crrev.com/dd38fc781ea3718f304fdb7a965f8f9a402a1a11/ios/build/bots/chromium.mac/ios-simulator-eg.json
[modify] https://crrev.com/dd38fc781ea3718f304fdb7a965f8f9a402a1a11/ios/build/bots/tests/eg_tests.json
[modify] https://crrev.com/dd38fc781ea3718f304fdb7a965f8f9a402a1a11/ios/chrome/test/earl_grey/BUILD.gn
[modify] https://crrev.com/dd38fc781ea3718f304fdb7a965f8f9a402a1a11/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/dd38fc781ea3718f304fdb7a965f8f9a402a1a11/testing/buildbot/manage.py
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f5696102a244ef87825997ad22d470655232256

commit 0f5696102a244ef87825997ad22d470655232256
Author: Menglu Huang <huangml@chromium.org>
Date: Fri Dec 08 06:35:07 2017

Modify iOS test_runner to accept shards of EarlGrey tests

Modify iOS test_runner to understand the isolated EarlGrey test shards.

Bug:  775168 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If82fe7d4f0e0358b1d10d3916ab9b5ed7f36ebdd
Reviewed-on: https://chromium-review.googlesource.com/807356
Commit-Queue: Menglu Huang <huangml@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: smut <smut@google.com>
Cr-Commit-Position: refs/heads/master@{#522722}
[modify] https://crrev.com/0f5696102a244ef87825997ad22d470655232256/ios/build/bots/scripts/run.py
[modify] https://crrev.com/0f5696102a244ef87825997ad22d470655232256/ios/build/bots/scripts/test_runner.py
[modify] https://crrev.com/0f5696102a244ef87825997ad22d470655232256/ios/build/bots/scripts/test_runner_test.py
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00

commit b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00
Author: Menglu Huang <huangml@chromium.org>
Date: Fri Dec 08 23:24:56 2017

Modify iOS recipe to isolate EarlGrey tests into smaller shards

EarlGrey test targets are not size balanced. Some targets like
ios_chrome_ui_egtest suite take more than 25 mins to run, while some take
only a few minutes.  We want to allow test suite to be isolated into
smaller shards.
Bug:775168
Change-Id: I477c48b85176010c109223a74238d93366d66815
Reviewed-on: https://chromium-review.googlesource.com/804399
Commit-Queue: Menglu Huang <huangml@chromium.org>
Reviewed-by: smut <smut@google.com>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>

[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipe_modules/ios/examples/full.expected/explain.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipes/webrtc/ios.expected/no_tests.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipe_modules/ios/examples/full.expected/timed_out.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipe_modules/ios/examples/full.expected/errors.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipe_modules/ios/examples/full.expected/clobber_build.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipes/ios/try.expected/icu_patch.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipe_modules/ios/examples/full.expected/expiration_test.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipe_modules/ios/examples/full.expected/expired.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipe_modules/ios/examples/full.expected/xcode_build_version.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipe_modules/ios/api.py
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipe_modules/ios/examples/full.expected/basic.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipe_modules/ios/examples/full.expected/no_exit_code.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipes/ios/try.expected/gn.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipe_modules/ios/examples/full.expected/test_failure.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipe_modules/ios/examples/full.expected/infra_failure.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipes/ios/try.expected/basic.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipes/ios/try.expected/parent.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipes/ios/unified_builder_tester.expected/basic.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipes/ios/unified_builder_tester.expected/goma_canary.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipe_modules/ios/examples/full.expected/fyi.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipes/ios/unified_builder_tester.expected/goma.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipe_modules/ios/examples/full.expected/clobber_checkout.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipe_modules/ios/examples/full.expected/perf_test.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipes/webrtc/ios.expected/basic.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipes/ios/try.expected/additional_compile_targets.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/README.recipes.md
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipes/ios/try.expected/no_tests.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipes/webrtc/ios.expected/trybot.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipes/ios/try.expected/no_compilation.json
[modify] https://crrev.com/b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00/scripts/slave/recipe_modules/ios/examples/full.py
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded

commit ff3a8cb62cfff59520aacca6e9f7f009f7d96ded
Author: Menglu Huang <huangml@chromium.org>
Date: Sat Dec 09 00:44:58 2017

Revert "Modify iOS recipe to isolate EarlGrey tests into smaller shards"

This reverts commit b08cea6e2c73ef1d68d0c9fe71f8d75ee4336d00.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Modify iOS recipe to isolate EarlGrey tests into smaller shards
> 
> EarlGrey test targets are not size balanced. Some targets like
> ios_chrome_ui_egtest suite take more than 25 mins to run, while some take
> only a few minutes.  We want to allow test suite to be isolated into
> smaller shards.
> Bug:775168
> Change-Id: I477c48b85176010c109223a74238d93366d66815
> Reviewed-on: https://chromium-review.googlesource.com/804399
> Commit-Queue: Menglu Huang <huangml@chromium.org>
> Reviewed-by: smut <smut@google.com>
> Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>

TBR=smut@google.com,sergeyberezin@chromium.org,huangml@chromium.org

Change-Id: I9df1afd3dedea95587f2b51207991547fed85778
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  775168 
Reviewed-on: https://chromium-review.googlesource.com/817581
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>

[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipe_modules/ios/examples/full.expected/explain.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipes/webrtc/ios.expected/no_tests.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipe_modules/ios/examples/full.expected/timed_out.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipe_modules/ios/examples/full.expected/errors.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipe_modules/ios/examples/full.expected/clobber_build.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipes/ios/try.expected/icu_patch.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipe_modules/ios/examples/full.expected/expiration_test.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipe_modules/ios/examples/full.expected/expired.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipe_modules/ios/examples/full.expected/xcode_build_version.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipe_modules/ios/api.py
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipe_modules/ios/examples/full.expected/basic.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipe_modules/ios/examples/full.expected/no_exit_code.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipes/ios/try.expected/gn.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipe_modules/ios/examples/full.expected/test_failure.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipe_modules/ios/examples/full.expected/infra_failure.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipes/ios/try.expected/basic.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipes/ios/try.expected/parent.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipes/ios/unified_builder_tester.expected/basic.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipes/ios/unified_builder_tester.expected/goma_canary.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipe_modules/ios/examples/full.expected/fyi.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipes/ios/unified_builder_tester.expected/goma.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipe_modules/ios/examples/full.expected/clobber_checkout.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipe_modules/ios/examples/full.expected/perf_test.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipes/webrtc/ios.expected/basic.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipes/ios/try.expected/additional_compile_targets.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/README.recipes.md
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipes/ios/try.expected/no_tests.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipes/webrtc/ios.expected/trybot.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipes/ios/try.expected/no_compilation.json
[modify] https://crrev.com/ff3a8cb62cfff59520aacca6e9f7f009f7d96ded/scripts/slave/recipe_modules/ios/examples/full.py
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/eeffdc597193fb94fc2b28771053494a72b0d861

commit eeffdc597193fb94fc2b28771053494a72b0d861
Author: Menglu Huang <huangml@chromium.org>
Date: Wed Dec 13 01:56:44 2017

Reland "Modify iOS recipe to isolate EarlGrey tests into smaller shardsi"

Bug:  775168 
Change-Id: I81c0c451c6aae46ac75c825800707995bfc1b6b0
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Reviewed-on: https://chromium-review.googlesource.com/820106
Commit-Queue: Menglu Huang <huangml@chromium.org>
Reviewed-by: smut <smut@google.com>

[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipe_modules/ios/examples/full.expected/explain.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipes/webrtc/ios.expected/no_tests.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipe_modules/ios/examples/full.expected/timed_out.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipe_modules/ios/examples/full.expected/errors.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipe_modules/ios/examples/full.expected/clobber_build.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipes/ios/try.expected/icu_patch.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipe_modules/ios/examples/full.expected/expiration_test.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipe_modules/ios/examples/full.expected/expired.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipe_modules/ios/examples/full.expected/xcode_build_version.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipe_modules/ios/api.py
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipe_modules/ios/examples/full.expected/basic.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipe_modules/ios/examples/full.expected/no_exit_code.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipes/ios/try.expected/gn.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipe_modules/ios/examples/full.expected/test_failure.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipe_modules/ios/examples/full.expected/infra_failure.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipes/ios/try.expected/basic.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipes/ios/try.expected/parent.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipes/ios/unified_builder_tester.expected/basic.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipes/ios/unified_builder_tester.expected/goma_canary.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipe_modules/ios/examples/full.expected/fyi.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipes/ios/unified_builder_tester.expected/goma.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipe_modules/ios/examples/full.expected/clobber_checkout.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipe_modules/ios/examples/full.expected/perf_test.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipes/webrtc/ios.expected/basic.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipes/ios/try.expected/additional_compile_targets.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/README.recipes.md
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipes/ios/try.expected/no_tests.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipes/webrtc/ios.expected/trybot.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipes/ios/try.expected/no_compilation.json
[modify] https://crrev.com/eeffdc597193fb94fc2b28771053494a72b0d861/scripts/slave/recipe_modules/ios/examples/full.py
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b79b2fcd76dbab3a4eceae494384ed96f7b0cb42

commit b79b2fcd76dbab3a4eceae494384ed96f7b0cb42
Author: Menglu Huang <huangml@chromium.org>
Date: Thu Dec 14 18:35:55 2017

Assign unique task_id to each task when sharding a big EG test target.

We used to use test['id'] to identify the ['isolate hash'].  When we shard
a big EarlGrey test target into multiple pieces. they are different tasks
but share the same test['id'] since the test is the same one. Add a
'task_id' variable in an task object to help identify different tasks. The
value will be the test['id'] if the current test doesn't require additional
sharding.  Otherwise it equals to '%s_%s' % (test['id'], shard_num).

Bug:775168
Change-Id: Icc0c12e86e9106794396c93d5ef86cab0ad4efa4

Recipe-Manual-Change: build_limited_scripts_slave
Change-Id: Icc0c12e86e9106794396c93d5ef86cab0ad4efa4
Reviewed-on: https://chromium-review.googlesource.com/826145
Reviewed-by: smut <smut@google.com>
Commit-Queue: Menglu Huang <huangml@chromium.org>

[modify] https://crrev.com/b79b2fcd76dbab3a4eceae494384ed96f7b0cb42/scripts/slave/README.recipes.md
[modify] https://crrev.com/b79b2fcd76dbab3a4eceae494384ed96f7b0cb42/scripts/slave/recipe_modules/ios/api.py
[modify] https://crrev.com/b79b2fcd76dbab3a4eceae494384ed96f7b0cb42/scripts/slave/recipe_modules/ios/examples/full.expected/basic.json
[modify] https://crrev.com/b79b2fcd76dbab3a4eceae494384ed96f7b0cb42/scripts/slave/recipe_modules/ios/examples/full.py
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 15 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/b38815bc1fc4182a3fa343164873e37e919c4110

commit b38815bc1fc4182a3fa343164873e37e919c4110
Author: Zhiling Huang <hzl@chromium.org>
Date: Fri Dec 15 20:24:04 2017

Comment 14 by huangml@chromium.org, May 31 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment