Support comment signed WebAPK with larger gaps between files. |
||||||
Issue descriptionFor comment-signed WebAPKs (which there are currently none in the wild), we permit only a small 'extra field' APK zip of 8 bytes. Because of .so files and other uses of the extra-field we need to support much larger fields, on the order of 4kb+ a bit.
,
Oct 18 2017
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c6868ce0a5fe7fbfa60029594274c141d36f4c7 commit 4c6868ce0a5fe7fbfa60029594274c141d36f4c7 Author: Andrew Grieve <agrieve@chromium.org> Date: Wed Oct 18 14:54:10 2017 Add new limits for extra field, updated test file. TBR=scottkirkwood@chromium.org (cherry picked from commit 8c0020b092996ef5e3d95c415c86006ca1a2e55a) Bug: 775160 Change-Id: Ic0f2a818386c78cf7b610035f7841f08e5477ab9 Reviewed-on: https://chromium-review.googlesource.com/723783 Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Scott Kirkwood <scottkirkwood@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509491} Reviewed-on: https://chromium-review.googlesource.com/725999 Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#711} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/4c6868ce0a5fe7fbfa60029594274c141d36f4c7/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVerifySignature.java [modify] https://crrev.com/4c6868ce0a5fe7fbfa60029594274c141d36f4c7/chrome/test/data/webapks/extra-field-too-large.apk
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9a91c48e6f2c466e6f6785d93970820f92a5d15 commit f9a91c48e6f2c466e6f6785d93970820f92a5d15 Author: Andrew Grieve <agrieve@chromium.org> Date: Wed Oct 18 16:01:46 2017 Add new limits for extra field, updated test file. TBR=scottkirkwood@chromium.org (cherry picked from commit 8c0020b092996ef5e3d95c415c86006ca1a2e55a) Bug: 775160 Change-Id: Ic0f2a818386c78cf7b610035f7841f08e5477ab9 Reviewed-on: https://chromium-review.googlesource.com/723783 Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Scott Kirkwood <scottkirkwood@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509491} Reviewed-on: https://chromium-review.googlesource.com/725526 Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#52} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/f9a91c48e6f2c466e6f6785d93970820f92a5d15/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVerifySignature.java [modify] https://crrev.com/f9a91c48e6f2c466e6f6785d93970820f92a5d15/chrome/test/data/webapks/extra-field-too-large.apk
,
Oct 18 2017
,
Oct 18 2017
I tried verifying the issue with Maps WebApk from https://b.corp.google.com/issues/67907879#comment8 on latest M64 build 64.0.3243.0, but it still repros there. Tot change list: https://chromium.googlesource.com/chromium/src/+log/64.0.3242.0..64.0.3243.0?pretty=fuller&n=10000
,
Oct 18 2017
For testing please take a look at b/67907879
,
Oct 20 2017
verified the issue with Maps WebApk from https://b.corp.google.com/issues/67907879#comment8 on 61.0.3163.128 on Android Go / OMB1.171017.003 and issue is fixed. 1. Install Maps Webapk 2. Install Chrome 61.0.3163.128 3. Tapping on Maps Webapk launches MapsWebapp. - I had to pick up MonochromeStable.apk from NEXT folder, apks from non Next folder gives [INSTALL_FAILED_VERSION_DOWNGRADE] error.
,
Oct 24 2017
scottkirkwood@ please mark as fixed
,
Oct 24 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Oct 17 2017