Issue metadata
Sign in to add a comment
|
[vr] Calculate frameCycleDurationMetric for VR AnimationExpectation only |
||||||||||||||||||||||||
Issue descriptionCurrently, the frameCycleDurationMetric is calculated for all trace events. Filter out the events in the VR ResponseExpectation since these values are usually not reliable.
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/5e0388c4511538a8d1b2d5a44bed77943d3467c4 commit 5e0388c4511538a8d1b2d5a44bed77943d3467c4 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Thu Oct 19 15:39:34 2017 [vr] Calculate frameCycleDurationMetric based on VR AnimationExpectation Only take events from the VR AnimationExpectation to calculate the frameCycleDurationMetric. Also, add support for range of interest to frameCycleDurationMetric. Furthermore, remove the trace events VrShellGl::DrawWorldElements and VrShellGl::DrawUiView because they don't exist anymore / are no longer useful. This CL is based on bsheedy@'s https://chromium-review.googlesource.com/c/catapult/+/713461. Credit is due. Bug: chromium:775157 Change-Id: I145a5d711f58024d41c804fc4874c3bb6893274e Reviewed-on: https://chromium-review.googlesource.com/721571 Reviewed-by: Ben Hayden <benjhayden@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> [modify] https://crrev.com/5e0388c4511538a8d1b2d5a44bed77943d3467c4/tracing/tracing/metrics/vr/frame_cycle_duration_metric_test.html [modify] https://crrev.com/5e0388c4511538a8d1b2d5a44bed77943d3467c4/tracing/tracing/metrics/vr/frame_cycle_duration_metric.html [modify] https://crrev.com/5e0388c4511538a8d1b2d5a44bed77943d3467c4/tracing/tracing/importer/user_model_builder_test.html [modify] https://crrev.com/5e0388c4511538a8d1b2d5a44bed77943d3467c4/tracing/tracing/importer/find_input_expectations.html
,
Oct 20 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by tiborg@chromium.org
, Oct 16 2017