CQ Status Report incorrectly shows no bad CLs rejected. |
|||||
Issue descriptionThis CL is an example of one that broke multiple CQ runs: https://crrev.com/c/559225 But the CQ status report emailed on 10/13/17 shows: 71 CQ runs included, from build 16504 to 16574. The CQ committed 808 changes this week. The CQ correctly rejected 0 unique changes this week, which would otherwise have broken the tree and required investigation and revert.
,
Oct 16 2017
+xixuan +pprabhu did somebody deploy a new version of the cq_stats appengine app lately?
,
Oct 16 2017
Nope. I've been trying to, but haven't managed it yet. New dependencies etc.
,
Oct 16 2017
I investigated and I think the reasons of 0 bad CLs are multiple: 1) the blame url is too long and so is truncated: e.g. https://chromiumos-build-annotator.googleplex.com/build_annotations/edit_annotations/master-paladin/1943187/? 2) many bad CLs were not rejected by CQ master: 1) CQ master hit the GOB issue 774368 before kicking it out; 2) sheriffs and deputies marked the bad CL and developers uploaded new patches. 3) the key reason is the blame URLs aren't in the right format: the script doesn't support https://crrev.com/c/* http://shortn/_Vmhstkzdez I added http://crosreview.com/711296 to https://chromiumos-build-annotator.googleplex.com/build_annotations/edit_annotations/master-paladin/1933296/ and re-run the script, the report showed "The CQ correctly rejected 1 unique changes this week". Passing to the previous deputy to correct the annotation list.
,
Oct 16 2017
Ah... I've been using the Addon "Linkable" to generate short URLs for bugs/CLs. I'd like to add support that for format to the script.
,
Oct 16 2017
Yep, it's because no support for crrev.com. Fix: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/721961
,
Oct 16 2017
Xixuan has the fix ready, we can re-run the report after it's landed to verify.
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ec6f81cf4a392266ddd79acbaa202611f34e914b commit ec6f81cf4a392266ddd79acbaa202611f34e914b Author: Xixuan Wu <xixuan@chromium.org> Date: Tue Oct 17 20:02:51 2017 build_annotator: add support for CL format: crrev.com/ BUG= chromium:775152 TEST=ran bin/summarize_build_stats. Change-Id: I8fb4071f193f21ef784ee97aafceb6341f83a0cf Reviewed-on: https://chromium-review.googlesource.com/721961 Commit-Ready: Xixuan Wu <xixuan@chromium.org> Tested-by: Xixuan Wu <xixuan@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/ec6f81cf4a392266ddd79acbaa202611f34e914b/scripts/summarize_build_stats.py
,
Oct 17 2017
Please reopen if deputy see this problem again this week. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by akes...@chromium.org
, Oct 16 2017