New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775149 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Add better documentation to SelectionController

Project Member Reported by xiaoche...@chromium.org, Oct 16 2017

Issue description

SelectionController is the class that changes text selection as the default handling of mouse events.

The class stores several states, which are transitioned on mouse events that arrive asynchronously. However, we don't have clear documentation of these states, and don't have a clear idea which transitions are allowed or not allowed. As a result, we are not sure if certain code in it is ever reachable or not (see discussion in crrev.com/c/713074).

We should document SelectionController as a state machine, with states and transitions clearly defined. With the state machine, we should eliminate dead code and ensure full test coverage.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Oct 17

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment