New issue
Advanced search Search tips

Issue 775140 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

autotest: xfstest: add more tests that use xfstest

Project Member Reported by gwendal@chromium.org, Oct 16 2017

Issue description

xfstests has been merged in chromeos to test ext4 crypto (see third_party/autotest/files/client/tests/xfstests/control).

That test enable ext4 crypto dummy mode.
For every xfstests test specified, it creates a job. It fits nicely with the autotest framework (we see at the end of the job how many xfstests tests pass/failed), but it is time and server space consuming.

- Add more tests:
 + split boiler plate code from the huge control file away in a library.
 + ability to test ext4 plain as well as ext4 crypto by adding a simple control file.
 + tune control file to ensure the smallest amount of data is copied to the server between test.

- Add standalone test mode:
 for speed purpose have a mode where xfstests tests are all run in a single job. That job would probably fail, it will be user responsibility to go in the result files to see which tests failed. However it will be faster to run and we let xfstest choose which tests to run based on the control file argument, like the group(s) to run. 
 
Current script to run xfstest in standalone mode.
xfstest_standalone.sh
663 bytes View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/08b9b41f4ff1a8c1673f1e52748198e4c13e974b

commit 08b9b41f4ff1a8c1673f1e52748198e4c13e974b
Author: Alexis Savery <asavery@chromium.org>
Date: Wed Nov 08 23:10:16 2017

xfstests: Update xfstests and add new tests.

Split boiler plate code from control file into library.
Add control file to test ext4 plain in addition to ext4 crypto.
Add standalone test mode where xfstests are run in a single job,
making use of an added group parameter to specify which group of
tests to run.

BUG=chromium:775140
TEST=Ran xfsFilesystemTestSuiteExt4Crypto,
xfsFilesystemTestSuiteExt4Plain,
xfsFilesystemTestSuiteStandaloneExt4Crypto,
xfsFilesystemTestSuiteStandaloneExt4Plain

Change-Id: I6dc47987a5ae717990f096b86f49e354f3ef3e74
Reviewed-on: https://chromium-review.googlesource.com/745327
Commit-Ready: Gwendal Grignou <gwendal@chromium.org>
Tested-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>

[add] https://crrev.com/08b9b41f4ff1a8c1673f1e52748198e4c13e974b/client/tests/xfstests/control.standalone_plain
[modify] https://crrev.com/08b9b41f4ff1a8c1673f1e52748198e4c13e974b/client/tests/xfstests/xfstests.py
[add] https://crrev.com/08b9b41f4ff1a8c1673f1e52748198e4c13e974b/client/tests/xfstests/control.standalone_crypto
[add] https://crrev.com/08b9b41f4ff1a8c1673f1e52748198e4c13e974b/client/tests/xfstests/control.plain
[add] https://crrev.com/08b9b41f4ff1a8c1673f1e52748198e4c13e974b/client/bin/xfstest_util.py
[modify] https://crrev.com/08b9b41f4ff1a8c1673f1e52748198e4c13e974b/client/tests/xfstests/control

Sign in to add a comment