New issue
Advanced search Search tips

Issue 775138 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Potential issues with MHTMLExtraParts implementation

Project Member Reported by carlosk@chromium.org, Oct 16 2017

Issue description

While reviewing a related CL I found two potential issues with the MHTMLExtraParts implementation. They might not reflect into actual problems -- or might even be WAI -- but I wanted to make sure they were known:

* MHTMLExtraParts data is never cleared from the instance held by WebContents. If a second MHTML save happens using the same WebContents instance new data will be appended along with what was already there and that later save would store both the old and new data.

* A single instance is shared among all potential users of that same WebContents. This would be a problem in the less likely (but possible) case of two MHTML save operations happening in parallel, causing more extra data to be added and then saved.
 

Comment 1 by dim...@chromium.org, Oct 25 2017

Labels: -Pri-3 Pri-2
Status: Assigned (was: Untriaged)
Assignign to Pete. We need to fix this.
Cc: carlosk@chromium.org
Status: Fixed (was: Assigned)
I believe that this is WAI.

With the BackgroundLoaderOffliner, we always get a fresh web contents for every render operation, they don't get re-used.  We only do one save per BackgroundLoading operation, after which the WebContents is closed.

So, I believe there is no need to clear it out after every save.

Sign in to add a comment