The basic idea is: -> {session: <SessionId>, id: <number>, method: <Domain.Command>, params: *} <- {session: <SessionId>, id: <number>, result: *} <- {session: <SessionId>, method: <Domain.Event>, params: *} More details to come.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88732c37ab8bc9dce15cd908748b55d163e22fb9 commit 88732c37ab8bc9dce15cd908748b55d163e22fb9 Author: Dmitry Gozman <dgozman@chromium.org> Date: Wed Feb 07 23:32:34 2018 [DevTools] Make devtools worker token accessible on WorkerThread. Also clarify that token on WorkerGlobalScope is a parent's one as opposite to the worker itself. Bug: 775132 Change-Id: Id4fed6d652ea44d56324ac6d9e8636dfc983ec09 Reviewed-on: https://chromium-review.googlesource.com/907539 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#535187} [modify] https://crrev.com/88732c37ab8bc9dce15cd908748b55d163e22fb9/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp [modify] https://crrev.com/88732c37ab8bc9dce15cd908748b55d163e22fb9/third_party/WebKit/Source/core/workers/GlobalScopeCreationParams.cpp [modify] https://crrev.com/88732c37ab8bc9dce15cd908748b55d163e22fb9/third_party/WebKit/Source/core/workers/GlobalScopeCreationParams.h [modify] https://crrev.com/88732c37ab8bc9dce15cd908748b55d163e22fb9/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp [modify] https://crrev.com/88732c37ab8bc9dce15cd908748b55d163e22fb9/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h [modify] https://crrev.com/88732c37ab8bc9dce15cd908748b55d163e22fb9/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp [modify] https://crrev.com/88732c37ab8bc9dce15cd908748b55d163e22fb9/third_party/WebKit/Source/core/workers/WorkerThread.cpp [modify] https://crrev.com/88732c37ab8bc9dce15cd908748b55d163e22fb9/third_party/WebKit/Source/core/workers/WorkerThread.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6358ee53852c438506371f4865f843e4c946e01a commit 6358ee53852c438506371f4865f843e4c946e01a Author: Dmitry Gozman <dgozman@chromium.org> Date: Thu Feb 08 21:58:58 2018 [DevTools] Remove extra functionality from WorkerInspectorProxy Tracing stuff goes to InspectorTracingAgent. Console stuff goes to ConsoleMessage. Drive-by: helper method IdentifiersFactory::IdFromToken. Bug: 775132 Change-Id: I5eb5733042a886fc9ff41861cfed849f6075bff5 Reviewed-on: https://chromium-review.googlesource.com/907647 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#535535} [modify] https://crrev.com/6358ee53852c438506371f4865f843e4c946e01a/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/6358ee53852c438506371f4865f843e4c946e01a/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp [modify] https://crrev.com/6358ee53852c438506371f4865f843e4c946e01a/third_party/WebKit/Source/core/inspector/ConsoleMessage.h [modify] https://crrev.com/6358ee53852c438506371f4865f843e4c946e01a/third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp [modify] https://crrev.com/6358ee53852c438506371f4865f843e4c946e01a/third_party/WebKit/Source/core/inspector/IdentifiersFactory.h [modify] https://crrev.com/6358ee53852c438506371f4865f843e4c946e01a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp [modify] https://crrev.com/6358ee53852c438506371f4865f843e4c946e01a/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp [modify] https://crrev.com/6358ee53852c438506371f4865f843e4c946e01a/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h [modify] https://crrev.com/6358ee53852c438506371f4865f843e4c946e01a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp [modify] https://crrev.com/6358ee53852c438506371f4865f843e4c946e01a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h [modify] https://crrev.com/6358ee53852c438506371f4865f843e4c946e01a/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp [modify] https://crrev.com/6358ee53852c438506371f4865f843e4c946e01a/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h [modify] https://crrev.com/6358ee53852c438506371f4865f843e4c946e01a/third_party/WebKit/Source/core/probe/CoreProbes.json5 [modify] https://crrev.com/6358ee53852c438506371f4865f843e4c946e01a/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp [modify] https://crrev.com/6358ee53852c438506371f4865f843e4c946e01a/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp [modify] https://crrev.com/6358ee53852c438506371f4865f843e4c946e01a/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91e7363273f4b95ba2666c59370aa469cb88155d commit 91e7363273f4b95ba2666c59370aa469cb88155d Author: Dmitry Gozman <dgozman@chromium.org> Date: Wed Feb 21 00:25:44 2018 [DevTools] Move all logic about debugger tasks to InspectorTaskRunner This patch moves both post-tasking and v8 interruption logic to InspectorTaskRunner and exposes a tiny API to use in WorkerThread and WebDevToolsAgentImpl. InspectorTaskRunner is now also per-frame (to support separate per-frame task queues provided by scheduler) instead of a singleton. InspectorTaskRunner is made ref counted (thread safe) so that it can be accessed from any thread without worrying about lifetime. Since it will be disposed from the owning thread when the time comes, it's safe to continue to use it from other threads. Also fixed a race between worker context creation and debugger's resume from startup pausing. The race was due to worker context failing to initialize sometimes. See comment in WorkerThread.cpp for details. Bug: 775132 Change-Id: I6e1f70f7b940e36614954d3300c15a41eeb1f08d Reviewed-on: https://chromium-review.googlesource.com/919528 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#537954} [modify] https://crrev.com/91e7363273f4b95ba2666c59370aa469cb88155d/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp [modify] https://crrev.com/91e7363273f4b95ba2666c59370aa469cb88155d/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/91e7363273f4b95ba2666c59370aa469cb88155d/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/91e7363273f4b95ba2666c59370aa469cb88155d/third_party/WebKit/Source/core/frame/LocalFrame.h [modify] https://crrev.com/91e7363273f4b95ba2666c59370aa469cb88155d/third_party/WebKit/Source/core/inspector/InspectorTaskRunner.cpp [modify] https://crrev.com/91e7363273f4b95ba2666c59370aa469cb88155d/third_party/WebKit/Source/core/inspector/InspectorTaskRunner.h [modify] https://crrev.com/91e7363273f4b95ba2666c59370aa469cb88155d/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp [modify] https://crrev.com/91e7363273f4b95ba2666c59370aa469cb88155d/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h [modify] https://crrev.com/91e7363273f4b95ba2666c59370aa469cb88155d/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp [modify] https://crrev.com/91e7363273f4b95ba2666c59370aa469cb88155d/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h [modify] https://crrev.com/91e7363273f4b95ba2666c59370aa469cb88155d/third_party/WebKit/Source/core/workers/WorkerThread.cpp [modify] https://crrev.com/91e7363273f4b95ba2666c59370aa469cb88155d/third_party/WebKit/Source/core/workers/WorkerThread.h [modify] https://crrev.com/91e7363273f4b95ba2666c59370aa469cb88155d/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3be811e75f173d0bb874b86df1e878800fa03d15 commit 3be811e75f173d0bb874b86df1e878800fa03d15 Author: Pavel Feldman <pfeldman@chromium.org> Date: Wed Jul 04 15:24:09 2018 DevTools: introduce flattened protocol operation. Bug: 775132 Change-Id: I0cd43942e4cf1c8347332e3c22fae5555b490e4b Reviewed-on: https://chromium-review.googlesource.com/1124936 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#572575} [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/content/browser/BUILD.gn [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/content/browser/devtools/browser_devtools_agent_host.cc [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/content/browser/devtools/browser_devtools_agent_host.h [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/content/browser/devtools/devtools_session.cc [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/content/browser/devtools/devtools_session.h [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/content/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/content/browser/devtools/protocol/target_handler.h [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/content/browser/devtools/render_frame_devtools_agent_host.h [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/content/browser/devtools/service_worker_devtools_agent_host.cc [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/content/browser/devtools/service_worker_devtools_agent_host.h [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/content/browser/devtools/shared_worker_devtools_agent_host.cc [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/content/browser/devtools/shared_worker_devtools_agent_host.h [add] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/content/browser/devtools/target_registry.cc [add] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/content/browser/devtools/target_registry.h [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/headless/BUILD.gn [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/headless/lib/browser/headless_devtools_client_impl.cc [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/headless/lib/headless_devtools_client_browsertest.cc [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/headless/public/headless_devtools_client.h [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/headless/public/internal/headless_devtools_client_impl.h [add] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/headless/test/headless_client_browsertest.cc [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/inspector-protocol-test.js [modify] https://crrev.com/3be811e75f173d0bb874b86df1e878800fa03d15/third_party/blink/renderer/core/inspector/browser_protocol.pdl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/246110ed126ecb520bc7808e092414f236369887 commit 246110ed126ecb520bc7808e092414f236369887 Author: Dmitry Gozman <dgozman@chromium.org> Date: Mon Sep 10 23:09:23 2018 Roll third_party/inspector_protocol to 1c471db574e6252b65df9b7b42e726185a9d8fa6 Bug: 775132 Change-Id: Ib31b7e9e5ef031abd47b4608bec5accb9181311e Reviewed-on: https://chromium-review.googlesource.com/1217592 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#590108} [modify] https://crrev.com/246110ed126ecb520bc7808e092414f236369887/third_party/inspector_protocol/README.chromium [modify] https://crrev.com/246110ed126ecb520bc7808e092414f236369887/third_party/inspector_protocol/lib/DispatcherBase_cpp.template [modify] https://crrev.com/246110ed126ecb520bc7808e092414f236369887/third_party/inspector_protocol/lib/DispatcherBase_h.template [modify] https://crrev.com/246110ed126ecb520bc7808e092414f236369887/third_party/inspector_protocol/lib/Maybe_h.template
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed commit 3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed Author: Dmitry Gozman <dgozman@chromium.org> Date: Tue Sep 11 22:19:06 2018 [DevTools] Do not interrupt worker for most of the debugger tasks This follows the page's logic of only interrupting for some of the debugger commands. To achieve this, we switch from running a tight loop with only inspector tasks to a nested message loop (again, similar to the main frame). This requires making some operations respect PausableObject semantics, noticeably worker's ResourceFetcher, post message and evaluating initial scripts. WorkerInspectorProxy now either posts a regular task or interrupting task similar to how DevToolsSession does it. This is a preparation to unifying workers and page debugging experience and implementation. Bug: 775132 Change-Id: I1c8ccd98c2c9a35fa7ab0b91017b924a81a297b1 Reviewed-on: https://chromium-review.googlesource.com/1205802 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#590505} [modify] https://crrev.com/3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-pause-dedicated-worker-loop-expected.txt [modify] https://crrev.com/3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-pause-dedicated-worker-loop.js [modify] https://crrev.com/3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc [modify] https://crrev.com/3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed/third_party/blink/renderer/core/inspector/inspector_session.cc [modify] https://crrev.com/3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed/third_party/blink/renderer/core/inspector/inspector_session.h [modify] https://crrev.com/3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed/third_party/blink/renderer/core/inspector/worker_inspector_controller.cc [modify] https://crrev.com/3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed/third_party/blink/renderer/core/inspector/worker_thread_debugger.cc [modify] https://crrev.com/3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed/third_party/blink/renderer/core/inspector/worker_thread_debugger.h [modify] https://crrev.com/3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed/third_party/blink/renderer/core/loader/worker_fetch_context.cc [modify] https://crrev.com/3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed/third_party/blink/renderer/core/loader/worker_fetch_context.h [modify] https://crrev.com/3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed/third_party/blink/renderer/core/workers/dedicated_worker_object_proxy.cc [modify] https://crrev.com/3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed/third_party/blink/renderer/core/workers/worker_global_scope.cc [modify] https://crrev.com/3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed/third_party/blink/renderer/core/workers/worker_global_scope.h [modify] https://crrev.com/3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed/third_party/blink/renderer/core/workers/worker_inspector_proxy.cc [modify] https://crrev.com/3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc [modify] https://crrev.com/3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h [modify] https://crrev.com/3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed/third_party/blink/renderer/core/workers/worker_thread.cc [modify] https://crrev.com/3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed/third_party/blink/renderer/core/workers/worker_thread.h [modify] https://crrev.com/3384067b2b1e7cc89cc5311d8d3e4b36da10c6ed/third_party/blink/renderer/core/workers/worker_thread_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8139c8f9eb3adb919e8df52e7c64b1c749a143dd commit 8139c8f9eb3adb919e8df52e7c64b1c749a143dd Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Sep 21 01:12:31 2018 DevTools: make shared worker connect pausable.. ..otherwise we ignore connection event when we paused at shared worker initialization. This bug was introduced by workers refactoring [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1205802 R=dgozman@chromium.org Bug: chromium:775132 Change-Id: I1d7c68d0c6339eaae4bd74c7a1953273f5ce8f2b Reviewed-on: https://chromium-review.googlesource.com/1237249 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#593037} [modify] https://crrev.com/8139c8f9eb3adb919e8df52e7c64b1c749a143dd/chrome/test/data/workers/debug_shared_worker_initialization.js [modify] https://crrev.com/8139c8f9eb3adb919e8df52e7c64b1c749a143dd/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc [modify] https://crrev.com/8139c8f9eb3adb919e8df52e7c64b1c749a143dd/third_party/blink/renderer/core/workers/shared_worker_global_scope.cc [modify] https://crrev.com/8139c8f9eb3adb919e8df52e7c64b1c749a143dd/third_party/blink/renderer/core/workers/shared_worker_global_scope.h [modify] https://crrev.com/8139c8f9eb3adb919e8df52e7c64b1c749a143dd/third_party/blink/renderer/core/workers/worker_global_scope.cc [modify] https://crrev.com/8139c8f9eb3adb919e8df52e7c64b1c749a143dd/third_party/blink/renderer/core/workers/worker_global_scope.h [modify] https://crrev.com/8139c8f9eb3adb919e8df52e7c64b1c749a143dd/third_party/blink/renderer/devtools/front_end/Tests.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b27efd1ebe2751e19553e2508e4450eabb6c3c06 commit b27efd1ebe2751e19553e2508e4450eabb6c3c06 Author: Dmitry Gozman <dgozman@chromium.org> Date: Mon Oct 01 22:08:11 2018 [DevTools] Introduce DevToolsRendererChannel This entity manages the blink::mojom::DevToolsAgent pointer exposed by the renderer, it's process id and frame host for different DevToolsAgentHostImpl subclasses. Putting it into a single entity simplifies the lifetime management, and will also aid with blink::mojom::DevToolsAgentHost when we'll add one. Bug: 775132 Change-Id: Ifc8e55995bff2eac813bb694ddc55ed7d0c9400c Reviewed-on: https://chromium-review.googlesource.com/1247702 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#595562} [modify] https://crrev.com/b27efd1ebe2751e19553e2508e4450eabb6c3c06/content/browser/BUILD.gn [modify] https://crrev.com/b27efd1ebe2751e19553e2508e4450eabb6c3c06/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/b27efd1ebe2751e19553e2508e4450eabb6c3c06/content/browser/devtools/devtools_agent_host_impl.h [add] https://crrev.com/b27efd1ebe2751e19553e2508e4450eabb6c3c06/content/browser/devtools/devtools_renderer_channel.cc [add] https://crrev.com/b27efd1ebe2751e19553e2508e4450eabb6c3c06/content/browser/devtools/devtools_renderer_channel.h [modify] https://crrev.com/b27efd1ebe2751e19553e2508e4450eabb6c3c06/content/browser/devtools/devtools_session.cc [modify] https://crrev.com/b27efd1ebe2751e19553e2508e4450eabb6c3c06/content/browser/devtools/devtools_session.h [modify] https://crrev.com/b27efd1ebe2751e19553e2508e4450eabb6c3c06/content/browser/devtools/protocol/devtools_domain_handler.cc [modify] https://crrev.com/b27efd1ebe2751e19553e2508e4450eabb6c3c06/content/browser/devtools/protocol/devtools_domain_handler.h [modify] https://crrev.com/b27efd1ebe2751e19553e2508e4450eabb6c3c06/content/browser/devtools/protocol/emulation_handler.cc [modify] https://crrev.com/b27efd1ebe2751e19553e2508e4450eabb6c3c06/content/browser/devtools/protocol/emulation_handler.h [modify] https://crrev.com/b27efd1ebe2751e19553e2508e4450eabb6c3c06/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/b27efd1ebe2751e19553e2508e4450eabb6c3c06/content/browser/devtools/render_frame_devtools_agent_host.h [modify] https://crrev.com/b27efd1ebe2751e19553e2508e4450eabb6c3c06/content/browser/devtools/service_worker_devtools_agent_host.cc [modify] https://crrev.com/b27efd1ebe2751e19553e2508e4450eabb6c3c06/content/browser/devtools/service_worker_devtools_agent_host.h [modify] https://crrev.com/b27efd1ebe2751e19553e2508e4450eabb6c3c06/content/browser/devtools/shared_worker_devtools_agent_host.cc [modify] https://crrev.com/b27efd1ebe2751e19553e2508e4450eabb6c3c06/content/browser/devtools/shared_worker_devtools_agent_host.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08a40e2f53cb53a307b9a265d3dddab7048ead0e commit 08a40e2f53cb53a307b9a265d3dddab7048ead0e Author: Dmitry Gozman <dgozman@chromium.org> Date: Tue Oct 02 21:16:41 2018 [DevTools] Cleanup passing renderer parameters around This patch shuffles the code a bit, so that DevToolsSession does not have to know about render process id and frame host anymore. Bug: 775132 Change-Id: I3a3f778ebb42769c8ebb7c165f4343a9940afa42 Reviewed-on: https://chromium-review.googlesource.com/c/1255147 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#595986} [modify] https://crrev.com/08a40e2f53cb53a307b9a265d3dddab7048ead0e/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/08a40e2f53cb53a307b9a265d3dddab7048ead0e/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/08a40e2f53cb53a307b9a265d3dddab7048ead0e/content/browser/devtools/devtools_renderer_channel.cc [modify] https://crrev.com/08a40e2f53cb53a307b9a265d3dddab7048ead0e/content/browser/devtools/devtools_session.cc [modify] https://crrev.com/08a40e2f53cb53a307b9a265d3dddab7048ead0e/content/browser/devtools/devtools_session.h [modify] https://crrev.com/08a40e2f53cb53a307b9a265d3dddab7048ead0e/content/browser/devtools/protocol/emulation_handler.cc [modify] https://crrev.com/08a40e2f53cb53a307b9a265d3dddab7048ead0e/content/browser/devtools/protocol/input_handler.cc [modify] https://crrev.com/08a40e2f53cb53a307b9a265d3dddab7048ead0e/content/browser/devtools/protocol/inspector_handler.cc [modify] https://crrev.com/08a40e2f53cb53a307b9a265d3dddab7048ead0e/content/browser/devtools/protocol/network_handler.cc [modify] https://crrev.com/08a40e2f53cb53a307b9a265d3dddab7048ead0e/content/browser/devtools/protocol/page_handler.cc [modify] https://crrev.com/08a40e2f53cb53a307b9a265d3dddab7048ead0e/content/browser/devtools/protocol/security_handler.cc [modify] https://crrev.com/08a40e2f53cb53a307b9a265d3dddab7048ead0e/content/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/08a40e2f53cb53a307b9a265d3dddab7048ead0e/content/browser/devtools/protocol/tracing_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22e08cb7ca4835e6c919de55006fc38f562cb6cf commit 22e08cb7ca4835e6c919de55006fc38f562cb6cf Author: Dmitry Gozman <dgozman@chromium.org> Date: Wed Oct 03 00:51:56 2018 [DevTools] Split DevToolsAgent out of WebDevToolsAgentImpl This is an implementation of mojom::DevToolsAgent which will be reused for workers in WorkerInspectorController. After switching workers to mojo, we'll merge InspectorSession into DevToolsAgent::Session. Bug: 775132 Change-Id: I180e62df147b6f256e09eeb1a44779151920471a Reviewed-on: https://chromium-review.googlesource.com/c/1258209 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#596075} [modify] https://crrev.com/22e08cb7ca4835e6c919de55006fc38f562cb6cf/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc [modify] https://crrev.com/22e08cb7ca4835e6c919de55006fc38f562cb6cf/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.h [modify] https://crrev.com/22e08cb7ca4835e6c919de55006fc38f562cb6cf/third_party/blink/renderer/core/inspector/BUILD.gn [add] https://crrev.com/22e08cb7ca4835e6c919de55006fc38f562cb6cf/third_party/blink/renderer/core/inspector/devtools_agent.cc [add] https://crrev.com/22e08cb7ca4835e6c919de55006fc38f562cb6cf/third_party/blink/renderer/core/inspector/devtools_agent.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9 commit 6adf95bcbaa9231dd6b91e7a5988d378fb81fed9 Author: Dmitry Gozman <dgozman@chromium.org> Date: Wed Oct 10 22:12:19 2018 [DevTools] Plumb mojom::DevToolsAgentHost around This is a preparation to worker debugging over mojom::DevToolsAgent interface. To properly report child workers and establish connection to them, we need a host which will be notified about children. For now, just plumb an empty interface to separate concerns. See https://chromium-review.googlesource.com/c/chromium/src/+/1183589 for the full implementation. Bug: 775132 Change-Id: Iac8b94309cc431baf18871b3355d817b326e51ac Reviewed-on: https://chromium-review.googlesource.com/c/1265030 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#598535} [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/browser/devtools/devtools_renderer_channel.cc [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/browser/devtools/devtools_renderer_channel.h [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/browser/devtools/service_worker_devtools_agent_host.cc [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/browser/devtools/service_worker_devtools_agent_host.h [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/browser/devtools/service_worker_devtools_manager.cc [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/browser/devtools/service_worker_devtools_manager.h [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/browser/devtools/shared_worker_devtools_agent_host.cc [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/browser/frame_host/render_frame_host_impl.h [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/browser/service_worker/embedded_worker_instance.cc [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/browser/service_worker/embedded_worker_test_helper.h [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/browser/shared_worker/mock_shared_worker.cc [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/browser/shared_worker/mock_shared_worker.h [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/browser/shared_worker/shared_worker_host.cc [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/browser/shared_worker/shared_worker_host.h [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/common/frame.mojom [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/common/service_worker/embedded_worker.mojom [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/common/shared_worker/shared_worker.mojom [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/renderer/render_frame_impl.cc [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/renderer/render_frame_impl.h [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/renderer/service_worker/embedded_worker_instance_client_impl.cc [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/renderer/service_worker/embedded_worker_instance_client_impl.h [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/renderer/shared_worker/embedded_shared_worker_stub.cc [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/content/renderer/shared_worker/embedded_shared_worker_stub.h [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/third_party/blink/public/web/devtools_agent.mojom [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/third_party/blink/public/web/web_embedded_worker.h [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/third_party/blink/public/web/web_local_frame.h [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/third_party/blink/public/web/web_shared_worker.h [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.h [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/third_party/blink/renderer/core/exported/web_shared_worker_impl.h [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/third_party/blink/renderer/core/exported/worker_shadow_page.cc [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/third_party/blink/renderer/core/exported/worker_shadow_page.h [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/third_party/blink/renderer/core/frame/web_local_frame_impl.cc [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/third_party/blink/renderer/core/frame/web_local_frame_impl.h [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/third_party/blink/renderer/core/inspector/devtools_agent.cc [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/third_party/blink/renderer/core/inspector/devtools_agent.h [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/6adf95bcbaa9231dd6b91e7a5988d378fb81fed9/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be2073bda20c503d1afd8bc513e7b79300e09838 commit be2073bda20c503d1afd8bc513e7b79300e09838 Author: Dmitry Gozman <dgozman@chromium.org> Date: Mon Oct 29 22:15:46 2018 [DevTools] Implement mojom::DevToolsAgent for workers 1) Use blink::DevToolsAgent in WorkerInspectorController. This replaces the ad-hoc interface for communicating with worker's debugger with a mojo interface used for frames and shared/service worker's shadow pages. 2) Create WorkerDevToolsAgentHost. This is similar to other agent hosts, keeps itself alive while the corresponding worker is alive, and reuses DevToolsSession machinery for inspection. 3) Report dedicated workers to the browser process when auto attach is on. mojom::DevToolsAgentHost is now notified about child workers and gets their DevToolsAgent interfaces to debug in the future. 4) Add TargetHandler to service/shared/dedicated worker sessions, to handle communication with nested dedicated workers. 5) Retire WorkerInspectorProxy and ExecutionContextWorkerRegistry. These are covered by DevToolsAgent now, which reports to it's host. 6) Retire InspectorWorkerAgent, which is replaced by WorkerDevToolsAgentHost on the browser side. The benefits are: - unified interface for inspecting any entity including workers; - workers now support flatten mode of operations; - all inspection targets are now listed on the browser side and represented with DevToolsAgentHost, which allows for further simplification; - less abstractions - we can even get rid of InspectorSession now. Bug: 775132 Change-Id: Ib4f58677a81ce48d4c2382f05d1166f730a2e2c3 Reviewed-on: https://chromium-review.googlesource.com/c/1183589 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603652} [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/content/browser/BUILD.gn [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/content/browser/devtools/browser_devtools_agent_host.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/content/browser/devtools/devtools_renderer_channel.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/content/browser/devtools/devtools_renderer_channel.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/content/browser/devtools/protocol/target_auto_attacher.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/content/browser/devtools/protocol/target_auto_attacher.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/content/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/content/browser/devtools/protocol/target_handler.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/content/browser/devtools/service_worker_devtools_agent_host.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/content/browser/devtools/shared_worker_devtools_agent_host.cc [add] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/content/browser/devtools/worker_devtools_agent_host.cc [add] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/content/browser/devtools/worker_devtools_agent_host.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/content/public/browser/devtools_agent_host.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/WebKit/LayoutTests/http/tests/devtools/workers-on-navigation.js [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-pause-dedicated-worker.js [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-terminate-dedicated-worker-while-paused.js [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/WebKit/LayoutTests/inspector-protocol/target/target-send-message-expected.txt [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/WebKit/LayoutTests/inspector-protocol/worker/exception-from-worker-contains-stack-expected.txt [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/WebKit/LayoutTests/inspector-protocol/worker/exception-from-worker-contains-stack.js [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console-expected.txt [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console.js [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/public/web/devtools_agent.mojom [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/exported/web_shared_worker_impl.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/inspector/BUILD.gn [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/inspector/devtools_agent.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/inspector/devtools_agent.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/inspector/inspector_emulation_agent.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/inspector/inspector_protocol_config.json [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/inspector/inspector_session.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/inspector/inspector_session.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/inspector/inspector_task_runner.cc [delete] https://crrev.com/e4f6ea1d83094af84b5a8cc90e6f206274ac6b0d/third_party/blink/renderer/core/inspector/inspector_worker_agent.cc [delete] https://crrev.com/e4f6ea1d83094af84b5a8cc90e6f206274ac6b0d/third_party/blink/renderer/core/inspector/inspector_worker_agent.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/inspector/worker_inspector_controller.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/inspector/worker_inspector_controller.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/probe/core_probes.json5 [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/probe/core_probes.pidl [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/workers/BUILD.gn [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/workers/dedicated_worker.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/workers/dedicated_worker_messaging_proxy.cc [delete] https://crrev.com/e4f6ea1d83094af84b5a8cc90e6f206274ac6b0d/third_party/blink/renderer/core/workers/execution_context_worker_registry.cc [delete] https://crrev.com/e4f6ea1d83094af84b5a8cc90e6f206274ac6b0d/third_party/blink/renderer/core/workers/execution_context_worker_registry.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/workers/shared_worker_reporting_proxy.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/workers/shared_worker_reporting_proxy.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/workers/threaded_messaging_proxy_base.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/workers/threaded_messaging_proxy_base.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/workers/threaded_object_proxy_base.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/workers/threaded_object_proxy_base.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/workers/threaded_worklet_messaging_proxy.cc [delete] https://crrev.com/e4f6ea1d83094af84b5a8cc90e6f206274ac6b0d/third_party/blink/renderer/core/workers/worker_inspector_proxy.cc [delete] https://crrev.com/e4f6ea1d83094af84b5a8cc90e6f206274ac6b0d/third_party/blink/renderer/core/workers/worker_inspector_proxy.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/workers/worker_reporting_proxy.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/workers/worker_thread.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/workers/worker_thread.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/workers/worker_thread_test.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/core/workers/worker_thread_test_helper.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/modules/animationworklet/animation_worklet_global_scope_test.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.h [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/modules/webaudio/audio_worklet_global_scope_test.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/modules/webaudio/audio_worklet_thread_test.cc [modify] https://crrev.com/be2073bda20c503d1afd8bc513e7b79300e09838/third_party/blink/renderer/modules/worklet/animation_and_paint_worklet_thread_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/491ed062f13f34b9d8dfa3951ebee4770317b47f commit 491ed062f13f34b9d8dfa3951ebee4770317b47f Author: Dmitry Gozman <dgozman@chromium.org> Date: Tue Oct 30 12:55:31 2018 [DevTools] Merge InspectorSession and DevToolsAgent::Session These are not needed as separate entities anymore, after making workers reuse DevToolsAgent::Session. We merge them into a single DevToolsSession class. Bug: 775132 Change-Id: I213de7e33c5b7ce12d4f58e1b2daa363ad563b12 Reviewed-on: https://chromium-review.googlesource.com/c/1282207 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#603869} [modify] https://crrev.com/491ed062f13f34b9d8dfa3951ebee4770317b47f/third_party/blink/renderer/build/scripts/make_instrumenting_probes.py [modify] https://crrev.com/491ed062f13f34b9d8dfa3951ebee4770317b47f/third_party/blink/renderer/core/core_initializer.h [modify] https://crrev.com/491ed062f13f34b9d8dfa3951ebee4770317b47f/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc [modify] https://crrev.com/491ed062f13f34b9d8dfa3951ebee4770317b47f/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.h [modify] https://crrev.com/491ed062f13f34b9d8dfa3951ebee4770317b47f/third_party/blink/renderer/core/inspector/BUILD.gn [modify] https://crrev.com/491ed062f13f34b9d8dfa3951ebee4770317b47f/third_party/blink/renderer/core/inspector/devtools_agent.cc [modify] https://crrev.com/491ed062f13f34b9d8dfa3951ebee4770317b47f/third_party/blink/renderer/core/inspector/devtools_agent.h [add] https://crrev.com/491ed062f13f34b9d8dfa3951ebee4770317b47f/third_party/blink/renderer/core/inspector/devtools_session.cc [rename] https://crrev.com/491ed062f13f34b9d8dfa3951ebee4770317b47f/third_party/blink/renderer/core/inspector/devtools_session.h [delete] https://crrev.com/52f1eca0bb9fbf690be28d6b8471ad83f9c6461b/third_party/blink/renderer/core/inspector/inspector_session.cc [modify] https://crrev.com/491ed062f13f34b9d8dfa3951ebee4770317b47f/third_party/blink/renderer/core/inspector/worker_inspector_controller.cc [modify] https://crrev.com/491ed062f13f34b9d8dfa3951ebee4770317b47f/third_party/blink/renderer/core/inspector/worker_inspector_controller.h [modify] https://crrev.com/491ed062f13f34b9d8dfa3951ebee4770317b47f/third_party/blink/renderer/core/probe/core_probes.json5 [modify] https://crrev.com/491ed062f13f34b9d8dfa3951ebee4770317b47f/third_party/blink/renderer/modules/modules_initializer.cc [modify] https://crrev.com/491ed062f13f34b9d8dfa3951ebee4770317b47f/third_party/blink/renderer/modules/modules_initializer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8af60f16a036ece5b6d73036c66d89ae6bba8f6e commit 8af60f16a036ece5b6d73036c66d89ae6bba8f6e Author: Owen Min <zmin@chromium.org> Date: Tue Oct 30 19:30:57 2018 Revert "[DevTools] Merge InspectorSession and DevToolsAgent::Session" This reverts commit 491ed062f13f34b9d8dfa3951ebee4770317b47f. Reason for revert: webkit_unit_tests failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/11027 Original change's description: > [DevTools] Merge InspectorSession and DevToolsAgent::Session > > These are not needed as separate entities anymore, after making > workers reuse DevToolsAgent::Session. We merge them into a single > DevToolsSession class. > > Bug: 775132 > Change-Id: I213de7e33c5b7ce12d4f58e1b2daa363ad563b12 > Reviewed-on: https://chromium-review.googlesource.com/c/1282207 > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603869} TBR=dgozman@chromium.org,caseq@chromium.org Change-Id: Iac3edc4bcd3d97e8ed67c5c35249ffd72c2ef1fc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775132 Reviewed-on: https://chromium-review.googlesource.com/c/1308659 Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603982} [modify] https://crrev.com/8af60f16a036ece5b6d73036c66d89ae6bba8f6e/third_party/blink/renderer/build/scripts/make_instrumenting_probes.py [modify] https://crrev.com/8af60f16a036ece5b6d73036c66d89ae6bba8f6e/third_party/blink/renderer/core/core_initializer.h [modify] https://crrev.com/8af60f16a036ece5b6d73036c66d89ae6bba8f6e/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc [modify] https://crrev.com/8af60f16a036ece5b6d73036c66d89ae6bba8f6e/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.h [modify] https://crrev.com/8af60f16a036ece5b6d73036c66d89ae6bba8f6e/third_party/blink/renderer/core/inspector/BUILD.gn [modify] https://crrev.com/8af60f16a036ece5b6d73036c66d89ae6bba8f6e/third_party/blink/renderer/core/inspector/devtools_agent.cc [modify] https://crrev.com/8af60f16a036ece5b6d73036c66d89ae6bba8f6e/third_party/blink/renderer/core/inspector/devtools_agent.h [delete] https://crrev.com/b77581ad3c136743e71dbc9c9c9c0e90d12c2687/third_party/blink/renderer/core/inspector/devtools_session.cc [add] https://crrev.com/8af60f16a036ece5b6d73036c66d89ae6bba8f6e/third_party/blink/renderer/core/inspector/inspector_session.cc [rename] https://crrev.com/8af60f16a036ece5b6d73036c66d89ae6bba8f6e/third_party/blink/renderer/core/inspector/inspector_session.h [modify] https://crrev.com/8af60f16a036ece5b6d73036c66d89ae6bba8f6e/third_party/blink/renderer/core/inspector/worker_inspector_controller.cc [modify] https://crrev.com/8af60f16a036ece5b6d73036c66d89ae6bba8f6e/third_party/blink/renderer/core/inspector/worker_inspector_controller.h [modify] https://crrev.com/8af60f16a036ece5b6d73036c66d89ae6bba8f6e/third_party/blink/renderer/core/probe/core_probes.json5 [modify] https://crrev.com/8af60f16a036ece5b6d73036c66d89ae6bba8f6e/third_party/blink/renderer/modules/modules_initializer.cc [modify] https://crrev.com/8af60f16a036ece5b6d73036c66d89ae6bba8f6e/third_party/blink/renderer/modules/modules_initializer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc13071370ae8904ae6d83e49174803a4fc5e14c commit dc13071370ae8904ae6d83e49174803a4fc5e14c Author: Dmitry Gozman <dgozman@chromium.org> Date: Wed Oct 31 16:56:57 2018 [DevTools] Fix a race when inspecting shared/service worker When pausing on initialization, we issue Debugger.enable immediately followed by Debugger.pause and expect the pause to happen. Because Debugger.pause can interrupt JS, it may actually run before Debugger.enable on the backend. That makes pause noop, and we never pause. The solution is to await for Debugger.enable before asking to pause. Bug: 775132, 900432 Change-Id: Ic2f504875b98312839235c6e32a10403757444f2 Reviewed-on: https://chromium-review.googlesource.com/c/1309213 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604299} [modify] https://crrev.com/dc13071370ae8904ae6d83e49174803a4fc5e14c/third_party/blink/renderer/devtools/front_end/sdk/ChildTargetManager.js [modify] https://crrev.com/dc13071370ae8904ae6d83e49174803a4fc5e14c/third_party/blink/renderer/devtools/front_end/sdk/DebuggerModel.js [modify] https://crrev.com/dc13071370ae8904ae6d83e49174803a4fc5e14c/third_party/blink/renderer/devtools/front_end/worker_main/WorkerMain.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/839129cc2cbee81391aacf7f84c5b6a1408170b6 commit 839129cc2cbee81391aacf7f84c5b6a1408170b6 Author: Dmitry Gozman <dgozman@chromium.org> Date: Wed Oct 31 18:31:54 2018 Reland "[DevTools] Merge InspectorSession and DevToolsAgent::Session" This is a reland of 491ed062f13f34b9d8dfa3951ebee4770317b47f Original change's description: > [DevTools] Merge InspectorSession and DevToolsAgent::Session > > These are not needed as separate entities anymore, after making > workers reuse DevToolsAgent::Session. We merge them into a single > DevToolsSession class. > > Bug: 775132 > Change-Id: I213de7e33c5b7ce12d4f58e1b2daa363ad563b12 > Reviewed-on: https://chromium-review.googlesource.com/c/1282207 > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603869} TBR=caseq@chromium.org Bug: 775132 Change-Id: I066cb72659bcbd7ad992735c5249503d34578d0d Reviewed-on: https://chromium-review.googlesource.com/c/1308983 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604343} [modify] https://crrev.com/839129cc2cbee81391aacf7f84c5b6a1408170b6/third_party/blink/renderer/build/scripts/make_instrumenting_probes.py [modify] https://crrev.com/839129cc2cbee81391aacf7f84c5b6a1408170b6/third_party/blink/renderer/core/core_initializer.h [modify] https://crrev.com/839129cc2cbee81391aacf7f84c5b6a1408170b6/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc [modify] https://crrev.com/839129cc2cbee81391aacf7f84c5b6a1408170b6/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.h [modify] https://crrev.com/839129cc2cbee81391aacf7f84c5b6a1408170b6/third_party/blink/renderer/core/inspector/BUILD.gn [modify] https://crrev.com/839129cc2cbee81391aacf7f84c5b6a1408170b6/third_party/blink/renderer/core/inspector/devtools_agent.cc [modify] https://crrev.com/839129cc2cbee81391aacf7f84c5b6a1408170b6/third_party/blink/renderer/core/inspector/devtools_agent.h [add] https://crrev.com/839129cc2cbee81391aacf7f84c5b6a1408170b6/third_party/blink/renderer/core/inspector/devtools_session.cc [rename] https://crrev.com/839129cc2cbee81391aacf7f84c5b6a1408170b6/third_party/blink/renderer/core/inspector/devtools_session.h [delete] https://crrev.com/80b2218c58bc9de49f65f56d5a5a805a03a47f62/third_party/blink/renderer/core/inspector/inspector_session.cc [modify] https://crrev.com/839129cc2cbee81391aacf7f84c5b6a1408170b6/third_party/blink/renderer/core/inspector/inspector_session_state_test.cc [modify] https://crrev.com/839129cc2cbee81391aacf7f84c5b6a1408170b6/third_party/blink/renderer/core/inspector/worker_inspector_controller.cc [modify] https://crrev.com/839129cc2cbee81391aacf7f84c5b6a1408170b6/third_party/blink/renderer/core/inspector/worker_inspector_controller.h [modify] https://crrev.com/839129cc2cbee81391aacf7f84c5b6a1408170b6/third_party/blink/renderer/core/probe/core_probes.json5 [modify] https://crrev.com/839129cc2cbee81391aacf7f84c5b6a1408170b6/third_party/blink/renderer/modules/modules_initializer.cc [modify] https://crrev.com/839129cc2cbee81391aacf7f84c5b6a1408170b6/third_party/blink/renderer/modules/modules_initializer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7925e2f382078b4ca778e6e886850aed64cedd32 commit 7925e2f382078b4ca778e6e886850aed64cedd32 Author: Dmitry Gozman <dgozman@chromium.org> Date: Tue Nov 06 03:02:45 2018 [DevTools] Rework flatten protocol handling - Merge TargetRegistry into DevToolsSession. - Allow flatten children on any targets. Bug: 775132 Change-Id: Idaafb019f9881a937f3e4b2d1abab7a3e89af06e Reviewed-on: https://chromium-review.googlesource.com/c/1316748 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605580} [modify] https://crrev.com/7925e2f382078b4ca778e6e886850aed64cedd32/content/browser/BUILD.gn [modify] https://crrev.com/7925e2f382078b4ca778e6e886850aed64cedd32/content/browser/devtools/browser_devtools_agent_host.cc [modify] https://crrev.com/7925e2f382078b4ca778e6e886850aed64cedd32/content/browser/devtools/browser_devtools_agent_host.h [modify] https://crrev.com/7925e2f382078b4ca778e6e886850aed64cedd32/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/7925e2f382078b4ca778e6e886850aed64cedd32/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/7925e2f382078b4ca778e6e886850aed64cedd32/content/browser/devtools/devtools_session.cc [modify] https://crrev.com/7925e2f382078b4ca778e6e886850aed64cedd32/content/browser/devtools/devtools_session.h [modify] https://crrev.com/7925e2f382078b4ca778e6e886850aed64cedd32/content/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/7925e2f382078b4ca778e6e886850aed64cedd32/content/browser/devtools/protocol/target_handler.h [modify] https://crrev.com/7925e2f382078b4ca778e6e886850aed64cedd32/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/7925e2f382078b4ca778e6e886850aed64cedd32/content/browser/devtools/render_frame_devtools_agent_host.h [modify] https://crrev.com/7925e2f382078b4ca778e6e886850aed64cedd32/content/browser/devtools/service_worker_devtools_agent_host.cc [modify] https://crrev.com/7925e2f382078b4ca778e6e886850aed64cedd32/content/browser/devtools/service_worker_devtools_agent_host.h [modify] https://crrev.com/7925e2f382078b4ca778e6e886850aed64cedd32/content/browser/devtools/shared_worker_devtools_agent_host.cc [modify] https://crrev.com/7925e2f382078b4ca778e6e886850aed64cedd32/content/browser/devtools/shared_worker_devtools_agent_host.h [delete] https://crrev.com/24c124f39f00bf5b62d3c573d19c2518f8b15b7e/content/browser/devtools/target_registry.cc [delete] https://crrev.com/24c124f39f00bf5b62d3c573d19c2518f8b15b7e/content/browser/devtools/target_registry.h [modify] https://crrev.com/7925e2f382078b4ca778e6e886850aed64cedd32/content/browser/devtools/worker_devtools_agent_host.cc [modify] https://crrev.com/7925e2f382078b4ca778e6e886850aed64cedd32/content/browser/devtools/worker_devtools_agent_host.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5937f13144493ed95bb74e48cfc2f4673c6b4f0 commit d5937f13144493ed95bb74e48cfc2f4673c6b4f0 Author: Dmitry Gozman <dgozman@chromium.org> Date: Wed Nov 07 01:12:37 2018 [DevTools] PageMock is always a main target now. Bug: 775132 Change-Id: I95a91e28bd67343c1b26c719edd0aaffc9fe9179 Reviewed-on: https://chromium-review.googlesource.com/c/1321089 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#605912} [modify] https://crrev.com/d5937f13144493ed95bb74e48cfc2f4673c6b4f0/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/scripts-panel.js [modify] https://crrev.com/d5937f13144493ed95bb74e48cfc2f4673c6b4f0/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/scripts-sorting-expected.txt [modify] https://crrev.com/d5937f13144493ed95bb74e48cfc2f4673c6b4f0/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/scripts-sorting.js [modify] https://crrev.com/d5937f13144493ed95bb74e48cfc2f4673c6b4f0/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/switch-file.js [modify] https://crrev.com/d5937f13144493ed95bb74e48cfc2f4673c6b4f0/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/navigator-view-expected.txt [modify] https://crrev.com/d5937f13144493ed95bb74e48cfc2f4673c6b4f0/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/navigator-view.js [modify] https://crrev.com/d5937f13144493ed95bb74e48cfc2f4673c6b4f0/third_party/blink/renderer/devtools/front_end/sdk_test_runner/PageMockTestRunner.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a079ebe818c533010c7e992a493f57c493407da commit 6a079ebe818c533010c7e992a493f57c493407da Author: Dmitry Gozman <dgozman@chromium.org> Date: Thu Nov 08 20:41:18 2018 [DevTools] Use PageMock in last-execution-context.js Bug: 775132 Change-Id: I7f7f58f56e437895afd91002e2316c4ef40c92ce Reviewed-on: https://chromium-review.googlesource.com/c/1324455 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#606592} [modify] https://crrev.com/6a079ebe818c533010c7e992a493f57c493407da/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/last-execution-context-expected.txt [modify] https://crrev.com/6a079ebe818c533010c7e992a493f57c493407da/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/last-execution-context.js [modify] https://crrev.com/6a079ebe818c533010c7e992a493f57c493407da/third_party/blink/renderer/devtools/front_end/sdk_test_runner/PageMockTestRunner.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea8b4707ffc2000756fd8bc2537c9994a9c2901f commit ea8b4707ffc2000756fd8bc2537c9994a9c2901f Author: Dmitry Gozman <dgozman@chromium.org> Date: Mon Nov 12 17:55:11 2018 [DevTools] Switch frontend to flatten protocol Introducing SessionRouter - a common router on top of raw connection which routes messages between multiple sessions based on sessionId. A couple of cleanups along the way. Bug: 775132 Change-Id: I3f773f7ead4d1729d9b936c69b4cdda2d6d20996 Reviewed-on: https://chromium-review.googlesource.com/c/1321854 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607286} [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/cached-sync-computed-styles.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/WebKit/LayoutTests/http/tests/devtools/inspector-backend-commands.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/agents-disabled-check-expected.txt [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/agents-disabled-check.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/WebKit/LayoutTests/http/tests/devtools/report-API-errors.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/WebKit/LayoutTests/http/tests/devtools/screen-orientation-override.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-agents-expected.txt [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-agents.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/async-callstack-network-initiator.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/blink/renderer/devtools/front_end/Tests.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/blink/renderer/devtools/front_end/audits2/Audits2ProtocolService.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/blink/renderer/devtools/front_end/inspector_main/InspectorMain.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/blink/renderer/devtools/front_end/js_main/JsMain.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/blink/renderer/devtools/front_end/main/Main.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/blink/renderer/devtools/front_end/node_main/NodeMain.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/blink/renderer/devtools/front_end/protocol/InspectorBackend.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/blink/renderer/devtools/front_end/protocol_monitor/ProtocolMonitor.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/blink/renderer/devtools/front_end/sdk/ChildTargetManager.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/blink/renderer/devtools/front_end/sdk/Connections.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/blink/renderer/devtools/front_end/sdk/Target.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/blink/renderer/devtools/front_end/sdk/TargetManager.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/blink/renderer/devtools/front_end/sdk_test_runner/PageMockTestRunner.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/blink/renderer/devtools/front_end/test_runner/TestRunner.js [modify] https://crrev.com/ea8b4707ffc2000756fd8bc2537c9994a9c2901f/third_party/blink/renderer/devtools/front_end/worker_main/WorkerMain.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3ceda740c6cfd1b86b6c43202424505ffcee466 commit e3ceda740c6cfd1b86b6c43202424505ffcee466 Author: Dmitry Gozman <dgozman@chromium.org> Date: Wed Dec 05 22:06:01 2018 [DevTools] Make Target.setAutoAttach respond after attaching to targets We currently respond to setAutoAttach synchronously, but report workers asynchronously after round-trip to renderer. Adding callback to ReportChildWorkers makes the protocol predictable, removing flakiness in all protocol clients. Bug: 775132 Change-Id: Ibf474622dc3a165c7d01e6450afbe72c13e4d945 Reviewed-on: https://chromium-review.googlesource.com/c/1359857 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#614119} [modify] https://crrev.com/e3ceda740c6cfd1b86b6c43202424505ffcee466/content/browser/devtools/devtools_renderer_channel.cc [modify] https://crrev.com/e3ceda740c6cfd1b86b6c43202424505ffcee466/content/browser/devtools/devtools_renderer_channel.h [modify] https://crrev.com/e3ceda740c6cfd1b86b6c43202424505ffcee466/content/browser/devtools/protocol/target_auto_attacher.cc [modify] https://crrev.com/e3ceda740c6cfd1b86b6c43202424505ffcee466/content/browser/devtools/protocol/target_auto_attacher.h [modify] https://crrev.com/e3ceda740c6cfd1b86b6c43202424505ffcee466/content/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/e3ceda740c6cfd1b86b6c43202424505ffcee466/content/browser/devtools/protocol/target_handler.h [modify] https://crrev.com/e3ceda740c6cfd1b86b6c43202424505ffcee466/content/browser/devtools/protocol_config.json [modify] https://crrev.com/e3ceda740c6cfd1b86b6c43202424505ffcee466/third_party/blink/public/web/devtools_agent.mojom [modify] https://crrev.com/e3ceda740c6cfd1b86b6c43202424505ffcee466/third_party/blink/renderer/core/inspector/devtools_agent.cc [modify] https://crrev.com/e3ceda740c6cfd1b86b6c43202424505ffcee466/third_party/blink/renderer/core/inspector/devtools_agent.h [add] https://crrev.com/e3ceda740c6cfd1b86b6c43202424505ffcee466/third_party/blink/web_tests/inspector-protocol/worker/worker-autoattach-order-expected.txt [add] https://crrev.com/e3ceda740c6cfd1b86b6c43202424505ffcee466/third_party/blink/web_tests/inspector-protocol/worker/worker-autoattach-order.js
Comment 1 by bugdroid1@chromium.org
, Feb 7 2018