Disable shapedetection layout tests on Linux |
||
Issue descriptionThere's currently no shapedetection implementation on Linux, yet we still run these layout tests. These tests should be explicitly disabled on Linux. Currently, a shapedetection related test timeout is disabled using: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/SlowTests?l=440 and https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/TestExpectations?l=99
,
Oct 16 2017
,
Oct 16 2017
Ok, so if we keep only [2] and can remove [3] and [4], it's already a good improvement. Note that, about [1], this is likely related to crbug.com/774567.
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7eb5b5b3cd0e077b49124cec469eaf3d52778f5e commit 7eb5b5b3cd0e077b49124cec469eaf3d52778f5e Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Tue Oct 17 18:52:23 2017 ShapeDetection: remove pixel-value comparison from detection-HTMLVideoElement LayoutTest This CL removes the pixel-value comparison from detection-HTMLVideoElement.html LayoutTest because it has platform quirks, e.g. in Linux the white colour is read back as 0xFFFFFEFF, breaking the comparison. Bug: 775127 Change-Id: I563f208bf858da80813631e0f2a66181bf94375b Reviewed-on: https://chromium-review.googlesource.com/721886 Reviewed-by: Emircan Uysaler <emircan@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#509463} [modify] https://crrev.com/7eb5b5b3cd0e077b49124cec469eaf3d52778f5e/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html |
||
►
Sign in to add a comment |
||
Comment 1 by mcasas@chromium.org
, Oct 16 2017Labels: ShapeDetection