Chrome crashes on startup if promo condition is enabled |
|||||||
Issue descriptionChrome Version: Latest Canary (can't get version as it won't run :) ) OS: Android What steps will reproduce the problem? (1) Enable Chrome Home promo flag + Chrome Home (2) Run Chrome What is the expected result? Chrome runs What happens instead? Chrome doesn't run (crashes instantly)
,
Oct 16 2017
Since we have the synthetic experiment, perhaps we can just remove that bit of code?
,
Oct 16 2017
Yeah, I'm moving it to cacheChromeHomeEnabled where it should have been in the first place.
,
Oct 16 2017
Issue 775170 has been merged into this issue.
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ef0c0c79c7e031b630db45867bfc4f849610d10 commit 7ef0c0c79c7e031b630db45867bfc4f849610d10 Author: Matthew Jones <mdjones@chromium.org> Date: Tue Oct 17 01:47:07 2017 [Home] Fix Chrome Home metrics crash This change fixes a crash that occurred as a result of native not being ready when trying to record metrics. The metrics recording has been moved to the same method that the Chrome Home state is cached in (which runs after native is ready). BUG= 775126 Change-Id: I11756265020ceb2bb0fbb59702cba3c9d9f8038a Reviewed-on: https://chromium-review.googlesource.com/721959 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#509209} [modify] https://crrev.com/7ef0c0c79c7e031b630db45867bfc4f849610d10/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
,
Oct 17 2017
,
Oct 17 2017
,
Oct 18 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 20 2017
Reminder to please merge to M63.
,
Oct 20 2017
Issue 775277 has been merged into this issue.
,
Oct 23 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/024ff4c4e840107f397f53792fdddb193aab3778 commit 024ff4c4e840107f397f53792fdddb193aab3778 Author: Matthew Jones <mdjones@chromium.org> Date: Mon Oct 23 21:11:18 2017 [Home] Fix Chrome Home metrics crash This change fixes a crash that occurred as a result of native not being ready when trying to record metrics. The metrics recording has been moved to the same method that the Chrome Home state is cached in (which runs after native is ready). BUG= 775126 TBR=mdjones@chromium.org (cherry picked from commit 7ef0c0c79c7e031b630db45867bfc4f849610d10) Change-Id: I11756265020ceb2bb0fbb59702cba3c9d9f8038a Reviewed-on: https://chromium-review.googlesource.com/721959 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509209} Reviewed-on: https://chromium-review.googlesource.com/734288 Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#165} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/024ff4c4e840107f397f53792fdddb193aab3778/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
,
Oct 23 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mdjones@chromium.org
, Oct 16 2017