New issue
Advanced search Search tips

Issue 775121 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

mash: Add test-only mojo interface for system tray

Project Member Reported by jamescook@chromium.org, Oct 16 2017

Issue description

Use it to make system tray browser tests work under mash.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bf4f34b088b147f6663ecee580eff8d75a7a1e9

commit 1bf4f34b088b147f6663ecee580eff8d75a7a1e9
Author: James Cook <jamescook@chromium.org>
Date: Mon Oct 16 21:19:14 2017

cros: Convert browser tests to use mojo generated AsyncWaiter

The mojo bindings generator produces FooAsyncWaiter for interface Foo.
Convert the 2 tests that were using mojo::test::Waiter to use the
new approach and eliminate mojo::test::Waiter.

Bug:  775121 
Test: browser_tests
Change-Id: I2c570fed5902fb185ebc1fcdd328c8c755d4afbe
Reviewed-on: https://chromium-review.googlesource.com/721695
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509175}
[modify] https://crrev.com/1bf4f34b088b147f6663ecee580eff8d75a7a1e9/chrome/browser/ui/ash/networking_config_delegate_chromeos_browsertest.cc
[modify] https://crrev.com/1bf4f34b088b147f6663ecee580eff8d75a7a1e9/chrome/browser/ui/ash/system_tray_client_browsertest.cc
[modify] https://crrev.com/1bf4f34b088b147f6663ecee580eff8d75a7a1e9/chrome/test/BUILD.gn
[modify] https://crrev.com/1bf4f34b088b147f6663ecee580eff8d75a7a1e9/mojo/public/cpp/test_support/BUILD.gn
[delete] https://crrev.com/1cecd8d86765712d5853646b7ac2392d7d436dae/mojo/public/cpp/test_support/waiter.cc
[delete] https://crrev.com/1cecd8d86765712d5853646b7ac2392d7d436dae/mojo/public/cpp/test_support/waiter.h

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a79c9bb9b0e66830f8c2cac81d03257dad7ed40

commit 8a79c9bb9b0e66830f8c2cac81d03257dad7ed40
Author: James Cook <jamescook@chromium.org>
Date: Tue Oct 17 23:37:14 2017

cros: Make SystemTrayClient browser tests work under mash

The eliminates non-public ash dependencies from the tests.

* Convert the tests to use the mojo system tray test API
* Clean up the test api, always use the same SystemTray*, remove some
  unnecessary RunLoop spins
* Put the tests on the mojo FYI bot. I'll move them to the main
  waterfall when I'm confident they are stable.

Bug:  775121 
Test: browser_tests --mash --gtest_filter="SystemTrayClient*"
Change-Id: Id790ca77aa179db499c45825a1466e18cc9f78d7
Reviewed-on: https://chromium-review.googlesource.com/723604
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509596}
[modify] https://crrev.com/8a79c9bb9b0e66830f8c2cac81d03257dad7ed40/ash/ash_view_ids.h
[modify] https://crrev.com/8a79c9bb9b0e66830f8c2cac81d03257dad7ed40/ash/public/interfaces/system_tray_test_api.mojom
[modify] https://crrev.com/8a79c9bb9b0e66830f8c2cac81d03257dad7ed40/ash/system/tray/system_tray.h
[modify] https://crrev.com/8a79c9bb9b0e66830f8c2cac81d03257dad7ed40/ash/system/tray/system_tray_test_api.cc
[modify] https://crrev.com/8a79c9bb9b0e66830f8c2cac81d03257dad7ed40/ash/system/tray/system_tray_test_api.h
[modify] https://crrev.com/8a79c9bb9b0e66830f8c2cac81d03257dad7ed40/ash/system/update/tray_update.cc
[modify] https://crrev.com/8a79c9bb9b0e66830f8c2cac81d03257dad7ed40/ash/system/update/tray_update.h
[modify] https://crrev.com/8a79c9bb9b0e66830f8c2cac81d03257dad7ed40/chrome/browser/ui/ash/system_tray_client_browsertest.cc
[modify] https://crrev.com/8a79c9bb9b0e66830f8c2cac81d03257dad7ed40/testing/buildbot/filters/mojo.fyi.browser_tests.filter

Status: Fixed (was: Started)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment