mash: Add test-only mojo interface for system tray |
|||||
Issue descriptionUse it to make system tray browser tests work under mash.
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a79c9bb9b0e66830f8c2cac81d03257dad7ed40 commit 8a79c9bb9b0e66830f8c2cac81d03257dad7ed40 Author: James Cook <jamescook@chromium.org> Date: Tue Oct 17 23:37:14 2017 cros: Make SystemTrayClient browser tests work under mash The eliminates non-public ash dependencies from the tests. * Convert the tests to use the mojo system tray test API * Clean up the test api, always use the same SystemTray*, remove some unnecessary RunLoop spins * Put the tests on the mojo FYI bot. I'll move them to the main waterfall when I'm confident they are stable. Bug: 775121 Test: browser_tests --mash --gtest_filter="SystemTrayClient*" Change-Id: Id790ca77aa179db499c45825a1466e18cc9f78d7 Reviewed-on: https://chromium-review.googlesource.com/723604 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#509596} [modify] https://crrev.com/8a79c9bb9b0e66830f8c2cac81d03257dad7ed40/ash/ash_view_ids.h [modify] https://crrev.com/8a79c9bb9b0e66830f8c2cac81d03257dad7ed40/ash/public/interfaces/system_tray_test_api.mojom [modify] https://crrev.com/8a79c9bb9b0e66830f8c2cac81d03257dad7ed40/ash/system/tray/system_tray.h [modify] https://crrev.com/8a79c9bb9b0e66830f8c2cac81d03257dad7ed40/ash/system/tray/system_tray_test_api.cc [modify] https://crrev.com/8a79c9bb9b0e66830f8c2cac81d03257dad7ed40/ash/system/tray/system_tray_test_api.h [modify] https://crrev.com/8a79c9bb9b0e66830f8c2cac81d03257dad7ed40/ash/system/update/tray_update.cc [modify] https://crrev.com/8a79c9bb9b0e66830f8c2cac81d03257dad7ed40/ash/system/update/tray_update.h [modify] https://crrev.com/8a79c9bb9b0e66830f8c2cac81d03257dad7ed40/chrome/browser/ui/ash/system_tray_client_browsertest.cc [modify] https://crrev.com/8a79c9bb9b0e66830f8c2cac81d03257dad7ed40/testing/buildbot/filters/mojo.fyi.browser_tests.filter
,
Oct 18 2017
,
Jan 22 2018
,
Jan 23 2018
,
Feb 26 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Oct 16 2017