config_updater / CQ merge produced invalid config_dump.json, breaking chromite unittests |
||||
Issue descriptionThere were also some race conditions last week in which a CQ submitted CL conflicted with the config_updater submitted change to break things because the config_dump.json git merge didn't work. The problem was self-corrected by the next config_upater run, but did cause builds to fail. I'm not certain of any reasonable way to address this.
,
Oct 16 2017
Well, if goldeneye went through the CQ this wouldn't happen. But if we allow GE to chump I think this could be fixed by running ./chromeos_config_unittest --update twice after applying all the CQ patches. Or remove the test that the checked in version equals the generated version, as the assumption is broken now.
,
May 17 2018
,
Jun 8 2018
,
Jul 13
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dgarr...@chromium.org
, Oct 16 2017