New issue
Advanced search Search tips

Issue 775116 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

config_updater / CQ merge produced invalid config_dump.json, breaking chromite unittests

Project Member Reported by dgarr...@chromium.org, Oct 16 2017

Issue description

There were also some race conditions last week in which a CQ submitted CL conflicted with the config_updater submitted change to break things because the config_dump.json git merge didn't work.

The problem was self-corrected by the next config_upater run, but did cause builds to fail.

I'm not certain of any reasonable way to address this.
 
It self-corrects, and has only happened once or twice since the config_updater was created, so it probably isn't worth getting too excited about.

Comment 2 by ihf@chromium.org, Oct 16 2017

Well, if goldeneye went through the CQ this wouldn't happen.

But if we allow GE to chump I think this could be fixed by running 
./chromeos_config_unittest --update
twice after applying all the CQ patches. Or remove the test that the checked in version equals the generated version, as the assumption is broken now.
Components: -Infra>Client>ChromeOS Infra>Client>ChromeOS>Build

Comment 4 by nxia@chromium.org, Jun 8 2018

Cc: -nxia@chromium.org
Components: -Infra>Client>ChromeOS>Build Infra>Client>ChromeOS>CI

Sign in to add a comment