New issue
Advanced search Search tips

Issue 775090 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference WRITE in blink::Document::DecrementLoadEventDelayCountAndCheckLoadEvent

Project Member Reported by ClusterFuzz, Oct 16 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4546856716861440

Fuzzer: inferno_twister
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Null-dereference WRITE
Crash Address: 0x00000520
Crash State:
  blink::Document::DecrementLoadEventDelayCountAndCheckLoadEvent
  blink::IncrementLoadEventDelayCount::ClearAndCheckLoadEvent
  blink::HTMLStyleElement::DispatchPendingEvent
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=508978:508990

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4546856716861440

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 16 2017

Labels: Test-Predator-AutoOwner
Owner: yuzus@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/51ad2417ab848793ce9ca38666dc6c01e30be658 (Change Persistent to WeakPersisitent in IncrementLoadEventDelayCount).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 2 by ClusterFuzz, Oct 16 2017

Components: Blink>DOM Blink>HTML
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16b522819cf9048ca16ce0a47cfa95cc8de8e2b5

commit 16b522819cf9048ca16ce0a47cfa95cc8de8e2b5
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Tue Oct 17 22:20:39 2017

Null-check |document_| in IncrementLoadEventDelayCount

After https://chromium-review.googlesource.com/720640, |document_|
is WeakPersistent and thus it should be null-checked before use.

Bug:  773571 ,  775090 
Change-Id: I914b57071fa07288997162d8645bab4ded440032
Reviewed-on: https://chromium-review.googlesource.com/721681
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509567}
[modify] https://crrev.com/16b522819cf9048ca16ce0a47cfa95cc8de8e2b5/third_party/WebKit/Source/core/dom/IncrementLoadEventDelayCount.cpp

Project Member

Comment 4 by ClusterFuzz, Oct 18 2017

ClusterFuzz has detected this issue as fixed in range 509545:509629.

Detailed report: https://clusterfuzz.com/testcase?key=4546856716861440

Fuzzer: inferno_twister
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Null-dereference WRITE
Crash Address: 0x00000520
Crash State:
  blink::Document::DecrementLoadEventDelayCountAndCheckLoadEvent
  blink::IncrementLoadEventDelayCount::ClearAndCheckLoadEvent
  blink::HTMLStyleElement::DispatchPendingEvent
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=508978:508990
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=509545:509629

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4546856716861440

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Comment 5 by yuzus@chromium.org, Oct 18 2017

Status: Fixed (was: Assigned)
Project Member

Comment 6 by ClusterFuzz, Oct 18 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4546856716861440 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Labels: -Test-Predator-AutoOwner Test-Predator-Auto-Owner

Sign in to add a comment