Refactor location for install_attributes.proto file |
|||
Issue descriptionNow we have two copies: one in Chrome and one in Chrome OS/Cryptohome service. For some reason we fetch Chrome's version into Chrome OS.
,
Oct 17 2017
Is it really Chromad-specific?
,
Oct 17 2017
I think it was introduced by Thiemo, so kinda?
,
Jan 22 2018
,
Jan 22 2018
- Move cryptohome file to system_api and have cryptohome point at that. - Mirror over to Chrome as usual. - Remove Chrome's version and have Chrome point at that.
,
Jan 9
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/241ef9e0c1adf302ace3e5cbeba9dc4d95a35e8e commit 241ef9e0c1adf302ace3e5cbeba9dc4d95a35e8e Author: Lutz Justen <ljusten@chromium.org> Date: Fri Jan 11 15:00:03 2019 Move install_attributes.proto to system_api Moves install_attributes.proto from cryptohome to system_api, so that it can be shared with Chrome. Right now, Chrome maintains its own copy. BUG=chromium:775087 TEST=tryjobs Change-Id: Iea013da2d23eda84aa2a70d3033ca04cccbc4a52 Reviewed-on: https://chromium-review.googlesource.com/1402785 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/241ef9e0c1adf302ace3e5cbeba9dc4d95a35e8e/cryptohome/libs/BUILD.gn [rename] https://crrev.com/241ef9e0c1adf302ace3e5cbeba9dc4d95a35e8e/system_api/dbus/cryptohome/install_attributes.proto
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/042d306d61a82a9075260268a1eaeecf19953a3e commit 042d306d61a82a9075260268a1eaeecf19953a3e Author: Lutz Justen <ljusten@chromium.org> Date: Tue Jan 15 10:54:55 2019 system_api: Add LITE_RUNTIME to install_attributes.proto Cannot reuse the proto for Chrome since Chrome enforces the lite runtime. Forgot to add this to CL:1402785. BUG=chromium:775087 TEST=build_packages, tryjobs Change-Id: I5b08cf07e947eca0678e72b1206be42449349fae Reviewed-on: https://chromium-review.googlesource.com/1409943 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/042d306d61a82a9075260268a1eaeecf19953a3e/system_api/dbus/cryptohome/install_attributes.proto
,
Jan 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e91fec08b1b687045196f844aff5202360d8e42 commit 2e91fec08b1b687045196f844aff5202360d8e42 Author: Lutz Justen <ljusten@chromium.org> Date: Wed Jan 16 14:21:08 2019 Roll src/third_party/cros_system_api/ ea44d5db9..5e6881be3 (8 commits) https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/ea44d5db9e74..5e6881be3c6b $ git log ea44d5db9..5e6881be3 --date=short --no-merges --format='%ad %ae %s' 2019-01-14 ljusten system_api: Add LITE_RUNTIME to install_attributes.proto 2019-01-09 aoldemeier login: Also set block_devmode=0 in system properties when clearing FRE VPD. 2019-01-09 ljusten Move install_attributes.proto to system_api 2019-01-07 zachr system_api: add enable_gpu option to StartVmRequest 2018-12-12 iby vm_tools: Add unit test for ContainerListenerImpl 2018-11-16 edmanp arc: Add initial arc-keymasterd 2019-01-03 ejcaruso system_api: add UnmountRequest proto for cryptohome 2018-11-16 chirantan system_api: Add StartPluginVm method Created with: roll-dep src/third_party/cros_system_api Bug:775087 Change-Id: I09140cc9fd841b0d89f2e35bc100507bb0070bdb Reviewed-on: https://chromium-review.googlesource.com/c/1412002 Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#623225} [modify] https://crrev.com/2e91fec08b1b687045196f844aff5202360d8e42/DEPS
,
Jan 18
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0afc521fa85f664f3de0d2c13a99990c4944097 commit b0afc521fa85f664f3de0d2c13a99990c4944097 Author: Lutz Justen <ljusten@chromium.org> Date: Fri Jan 18 10:09:53 2019 Use install_attributes.proto from system_api Gets rid of Chrome's own copy of install_attributes.proto and uses the one from system_api instead, which was recently moved there by CL:1402785. BUG=chromium:775087 TEST=Tryjobs Change-Id: I5e9166eaee380d9f0e47c3312f4f19cb4ef62d72 Reviewed-on: https://chromium-review.googlesource.com/c/1402876 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by: Sergey Poromov <poromov@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#624055} [modify] https://crrev.com/b0afc521fa85f664f3de0d2c13a99990c4944097/chromeos/dbus/BUILD.gn [modify] https://crrev.com/b0afc521fa85f664f3de0d2c13a99990c4944097/chromeos/dbus/fake_cryptohome_client.cc [modify] https://crrev.com/b0afc521fa85f664f3de0d2c13a99990c4944097/chromeos/tpm/install_attributes.cc [modify] https://crrev.com/b0afc521fa85f664f3de0d2c13a99990c4944097/chromeos/tpm/install_attributes_unittest.cc [modify] https://crrev.com/b0afc521fa85f664f3de0d2c13a99990c4944097/components/policy/proto/BUILD.gn [delete] https://crrev.com/aacb4fc1f524ade63567c41f4cf4515df22971c8/components/policy/proto/install_attributes.proto |
|||
►
Sign in to add a comment |
|||
Comment 1 by ljusten@chromium.org
, Oct 17 2017