New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775067 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Nov 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Failed test in mus without use_texture_npot (npot_ok) support

Project Member Reported by wutao@chromium.org, Oct 16 2017

Issue description

After turn on trilinear filtering in overview mode, the test (WorkspaceLayoutManagerBackdropTest, BackdropTest) [1] fails in mus test.

DCHECK fails at DCHECK(settings_.use_texture_npot) [2]; to generate mipmap in the test of mus.

The test in mash passed, but it seems not calling FeatureInfo::InitializeFeatures [3] as well to set feature_flags_.npot_ok = true;.

We need to set up the test appropriate for mus and mash.

[1] https://cs.chromium.org/chromium/src/ash/wm/workspace/workspace_layout_manager_unittest.cc?l=1177&rcl=fc1a895a2a6e8ab8f63dd19fcc7186e29ccf0772

[2] https://cs.chromium.org/chromium/src/cc/resources/resource_provider.cc?l=1129&rcl=fc1a895a2a6e8ab8f63dd19fcc7186e29ccf0772

[3] https://cs.chromium.org/chromium/src/gpu/command_buffer/service/feature_info.cc?l=874&rcl=6c8aa0c1e4bc6add5c8124e3282e26236127aa25
 

Comment 1 by wutao@chromium.org, Oct 16 2017

Description: Show this description

Comment 2 by wutao@chromium.org, Oct 16 2017

Cc: sky@chromium.org
+sky@, could you please suggest who will be the best person to investigate this.
Thanks!

Comment 3 by sky@chromium.org, Oct 16 2017

+fsamuel
If this is blocking you feel free to add an exclusion to https://chromium.googlesource.com/chromium/src/+/master/testing/buildbot/filters/ash_unittests_mus.filter with a pointer to this bug.

Comment 4 by wutao@chromium.org, Oct 16 2017

#3, Thanks. Done to add to the exclusion list.

Comment 5 by kbr@chromium.org, Oct 16 2017

Cc: kbr@chromium.org zmo@chromium.org
Components: -Internals>GPU>Testing Internals>GPU>Internals

Comment 6 by fsamuel@google.com, Oct 20 2017

Status: Assigned (was: Untriaged)
Components: -Internals>GPU>Internals Internals>Services>Viz
Mus specific, so moving to Viz component.
Owner: fsam...@chromium.org
Status: WontFix (was: Assigned)
This is very out of date. I'm marking as WontFix. Please reopen if I'm mistaken.

Sign in to add a comment