New issue
Advanced search Search tips

Issue 775064 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

fast/text/selection/atsui-kerning-and-ligatures.html is failing on WebKit Mac10.10

Project Member Reported by alex...@chromium.org, Oct 16 2017

Issue description

This test started consistently failing with an image diff in:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/38598

Looks like it was touched (moved) in https://chromium-review.googlesource.com/c/chromium/src/+/718239.  yosin@, can you please take a look?  I'll disable the test for now.

 
engedy@ put together a rebaseline CL that should fix this: https://chromium-review.googlesource.com/c/chromium/src/+/721543
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/518401d1e3b6160d53ad66cf76c2ddb996aa4887

commit 518401d1e3b6160d53ad66cf76c2ddb996aa4887
Author: Balazs Engedy <engedy@chromium.org>
Date: Mon Oct 16 17:54:15 2017

Rebaseline fast/text/selection/atsui-kerning-and-ligatures.html on Mac10.10.

This is in follow-up to https://chromium-review.googlesource.com/718239. See:
https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Mac10.10/38598

TBR=yosin@chromium.org

Bug:  775064 
Change-Id: I73828dd584748e61e263f3e34a6484f9627da30b
Reviewed-on: https://chromium-review.googlesource.com/721543
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509100}
[add] https://crrev.com/518401d1e3b6160d53ad66cf76c2ddb996aa4887/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/selection/atsui-kerning-and-ligatures-expected.png

Comment 3 by yosin@chromium.org, Oct 17 2017

Status: Started (was: Assigned)
Thanks alex to handle this!
I'm removing redundant image file: ayoutTests/platform/mac-mac10.10/fast/text/atsui-kerning-and-ligatures-expected.png

http://crrev.com/c/722361
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2d06c06bfdec667ac284fac3caeee4f1b4749be

commit d2d06c06bfdec667ac284fac3caeee4f1b4749be
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Tue Oct 17 06:13:03 2017

Remove redundant file WebKit/LayoutTests/platform/mac-mac10.10/fast/text/atsui-kerning-and-ligatures-expected.png

This patch gets rid of redundant layout test expected image file[1] introduced
by the patch[2], which missed to move this file to "fast/text/selection"
directory.


[1] WebKit/LayoutTests/platform/mac-mac10.10/fast/text/atsui-kerning-and-ligatures-expected.pngatsui-kerning-and-ligatures-expected.png
[2] http://crrev.com/c/718239: Move selection related layout tests to fast/text/selection from fast/text/"

TBR=alexmos@chromium.org
NOTRY=true

Bug:  775064 
Change-Id: Ib5cac0d3e3009ee52c46e81e106d710d4b6f1e42
Reviewed-on: https://chromium-review.googlesource.com/722361
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509287}
[delete] https://crrev.com/99214294411cd62c9aa577142ecc1b421f9bd1e8/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/atsui-kerning-and-ligatures-expected.png

Comment 5 by yosin@chromium.org, Oct 17 2017

Status: Fixed (was: Started)

Sign in to add a comment