Local NTP OGB: Don't re-load when tiles are reloaded |
||||||
Issue descriptionIn https://crrev.com/c/695302, I moved loading of the OGB to when we get the 'loaded' message from the MV iframe. Turns out we get that message whenever the tiles are reloaded, e.g. because the user blacklisted one. So now on every blacklisting, we load the OGB again, adding another set of script tags etc. Interestingly, this doesn't seem to cause any major problems other than burning some memory.
,
Oct 17 2017
,
Oct 17 2017
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9974a8c5369686a01afbcc685351549d8202239 commit f9974a8c5369686a01afbcc685351549d8202239 Author: Marc Treib <treib@chromium.org> Date: Wed Oct 18 17:01:08 2017 Local NTP: Load the OGB only once CL https://crrev.com/c/695302 moved loading the OGB to when we get the 'loaded' message from the MV iframe. Turns out we can get that multiple times. So before loading the OGB (again), check that we haven't yet. Bug: 775048 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1888032f4227369f64b6c0c8c6ff6e0572b076fb Reviewed-on: https://chromium-review.googlesource.com/722999 Reviewed-by: Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#509796} [modify] https://crrev.com/f9974a8c5369686a01afbcc685351549d8202239/chrome/browser/resources/local_ntp/local_ntp.js
,
Oct 19 2017
,
Oct 19 2017
,
Oct 20 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa22cda92a7e5ff4852d97c26cff474fdc16e406 commit aa22cda92a7e5ff4852d97c26cff474fdc16e406 Author: Marc Treib <treib@chromium.org> Date: Fri Oct 20 08:59:41 2017 Local NTP: Load the OGB only once CL https://crrev.com/c/695302 moved loading the OGB to when we get the 'loaded' message from the MV iframe. Turns out we can get that multiple times. So before loading the OGB (again), check that we haven't yet. Bug: 775048 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1888032f4227369f64b6c0c8c6ff6e0572b076fb Reviewed-on: https://chromium-review.googlesource.com/722999 Reviewed-by: Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509796}(cherry picked from commit f9974a8c5369686a01afbcc685351549d8202239) Reviewed-on: https://chromium-review.googlesource.com/730323 Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#104} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/aa22cda92a7e5ff4852d97c26cff474fdc16e406/chrome/browser/resources/local_ntp/local_ntp.js |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by treib@chromium.org
, Oct 16 2017