New issue
Advanced search Search tips

Issue 775045 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Dec 2017
Cc:
twelling...@chromium.org
mdjones@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Make opt-in/opt-out promo label tappable

Project Member Reported by k...@chromium.org, Oct 16 2017 
We should make the label "Use the new Chrome" tappable so it toggles the UI. That way we would be more consistent with typical label UIs.

Comment 1 by twelling...@chromium.org, Oct 19 2017

Cc: twelling...@chromium.org
For preferences, the entire row is has an on click listener that toggles the preference and shows a material ripple on touch. Is that the behavior we want to emulate?

As an aside, "NavPanel" isn't really an the right widget. Should we have a "ChromeHomePromo" component or something like that? Or leave off the component entirely?

Comment 2 by k...@chromium.org, Oct 21 2017 

Sure - we can leave off the component. I don't think it makes sense to have a component for a feature that'll only last a few milestones.

And yes, the entire row sounds good here.

Comment 3 by k...@chromium.org, Nov 7 2017

Labels: -Fine-Pri-3.0 Fine-Pri-2.9

Comment 4 by twelling...@chromium.org, Dec 11 2017 

Can this be closed as "WontFix" since we removed the toggle?

Comment 5 by k...@chromium.org, Dec 12 2017

Status: WontFix (was: Available)
Yep!
►

Sign in to add a comment