New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775041 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 768373
issue 775039

Blocking:
issue 777820



Sign in to add a comment

Remove SUMMARY_ONLY from MemoryDumpType

Project Member Reported by hjd@chromium.org, Oct 16 2017

Issue description

Background context: go/memory-infra

Remove SUMMARY_ONLY from the memory dump type[1]. Instead distinguish between requests that should/should not return data using RequestGlobalDump vs AndAddToTrace added for  issue 775039 

[1]: https://cs.chromium.org/chromium/src/base/trace_event/memory_dump_request_args.h?type=cs&q=SUMMARY_ONLY&sq=package:chromium&l=34
 

Comment 1 by lalitm@chromium.org, Oct 17 2017

Owner: lalitm@chromium.org
Status: Started (was: Available)
Seems that this is better done before VM_REGIONS work because of the interactions between LevelOfDetail and Type.

Comment 2 by lalitm@chromium.org, Oct 17 2017

Owner: ----
Status: Available (was: Started)
Never mind: VM_REGIONS_ONLY seems the better starting point because SUMMARY_ONLY has to deal with whitelisting.

Comment 3 by lalitm@chromium.org, Oct 24 2017

Blocking: 777820

Comment 4 by lalitm@chromium.org, Oct 24 2017

Status: Started (was: Available)

Comment 5 by lalitm@chromium.org, Oct 24 2017

Owner: lalitm@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33684a9efdc271b9804e0c6595d26e1985ac65ff

commit 33684a9efdc271b9804e0c6595d26e1985ac65ff
Author: Lalit Maganti <lalitm@chromium.org>
Date: Wed Oct 25 23:38:57 2017

memory-infra: move SUMMARY_ONLY from type to level of detail

As with VM_REGIONS_ONLY, SUMMARY_ONLY never belonged in the type enum as
its meaning refers how much information should be returned to the caller
of the memory instrumentation service.

Move the enum member and change all relevant references. Eventually, we
plan to remove this member all together as its purpose will be subsumed
by one of the other levels of detail but for now this is a good stepping
stone.

Bug: 775041
Bug: 777820
Change-Id: I43504be0cd2f864b38dfd607b7d08ada156ed7ca
Reviewed-on: https://chromium-review.googlesource.com/735700
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Lalit Maganti <lalitm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511645}
[modify] https://crrev.com/33684a9efdc271b9804e0c6595d26e1985ac65ff/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/33684a9efdc271b9804e0c6595d26e1985ac65ff/base/trace_event/memory_dump_manager_unittest.cc
[modify] https://crrev.com/33684a9efdc271b9804e0c6595d26e1985ac65ff/base/trace_event/memory_dump_request_args.cc
[modify] https://crrev.com/33684a9efdc271b9804e0c6595d26e1985ac65ff/base/trace_event/memory_dump_request_args.h
[modify] https://crrev.com/33684a9efdc271b9804e0c6595d26e1985ac65ff/base/trace_event/memory_dump_scheduler.cc
[modify] https://crrev.com/33684a9efdc271b9804e0c6595d26e1985ac65ff/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/33684a9efdc271b9804e0c6595d26e1985ac65ff/services/resource_coordinator/memory_instrumentation/coordinator_impl_unittest.cc
[modify] https://crrev.com/33684a9efdc271b9804e0c6595d26e1985ac65ff/services/resource_coordinator/memory_instrumentation/queued_request.h
[modify] https://crrev.com/33684a9efdc271b9804e0c6595d26e1985ac65ff/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation.cc
[modify] https://crrev.com/33684a9efdc271b9804e0c6595d26e1985ac65ff/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation_struct_traits.cc
[modify] https://crrev.com/33684a9efdc271b9804e0c6595d26e1985ac65ff/services/resource_coordinator/public/cpp/memory_instrumentation/struct_traits_unittest.cc
[modify] https://crrev.com/33684a9efdc271b9804e0c6595d26e1985ac65ff/services/resource_coordinator/public/cpp/memory_instrumentation/tracing_observer.cc
[modify] https://crrev.com/33684a9efdc271b9804e0c6595d26e1985ac65ff/services/resource_coordinator/public/interfaces/memory_instrumentation/memory_instrumentation.mojom

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98e8b7f9910e484189d4806ee1d5e456cb31701c

commit 98e8b7f9910e484189d4806ee1d5e456cb31701c
Author: Lalit Maganti <lalitm@chromium.org>
Date: Thu Oct 26 09:46:29 2017

Revert "memory-infra: move SUMMARY_ONLY from type to level of detail"

This reverts commit 33684a9efdc271b9804e0c6595d26e1985ac65ff.

Reason for revert: A lot of code is conditional on BACKGROUND being the level of detail and so there are significant problems if we don't revert this including the crasher motivating this bug but also issues with UMA and UKM etc.

Bug: 778560

Original change's description:
> memory-infra: move SUMMARY_ONLY from type to level of detail
> 
> As with VM_REGIONS_ONLY, SUMMARY_ONLY never belonged in the type enum as
> its meaning refers how much information should be returned to the caller
> of the memory instrumentation service.
> 
> Move the enum member and change all relevant references. Eventually, we
> plan to remove this member all together as its purpose will be subsumed
> by one of the other levels of detail but for now this is a good stepping
> stone.
> 
> Bug: 775041
> Bug: 777820
> Change-Id: I43504be0cd2f864b38dfd607b7d08ada156ed7ca
> Reviewed-on: https://chromium-review.googlesource.com/735700
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Primiano Tucci <primiano@chromium.org>
> Reviewed-by: Siddhartha S <ssid@chromium.org>
> Commit-Queue: Lalit Maganti <lalitm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#511645}

TBR=dcheng@chromium.org,primiano@chromium.org,rkaplow@chromium.org,hjd@chromium.org,ssid@chromium.org,lalitm@chromium.org

Change-Id: I5a765e551eb1d9cac289a13eb9e373c72ddd78e4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775041, 777820
Reviewed-on: https://chromium-review.googlesource.com/738039
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Lalit Maganti <lalitm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511774}
[modify] https://crrev.com/98e8b7f9910e484189d4806ee1d5e456cb31701c/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/98e8b7f9910e484189d4806ee1d5e456cb31701c/base/trace_event/memory_dump_manager_unittest.cc
[modify] https://crrev.com/98e8b7f9910e484189d4806ee1d5e456cb31701c/base/trace_event/memory_dump_request_args.cc
[modify] https://crrev.com/98e8b7f9910e484189d4806ee1d5e456cb31701c/base/trace_event/memory_dump_request_args.h
[modify] https://crrev.com/98e8b7f9910e484189d4806ee1d5e456cb31701c/base/trace_event/memory_dump_scheduler.cc
[modify] https://crrev.com/98e8b7f9910e484189d4806ee1d5e456cb31701c/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/98e8b7f9910e484189d4806ee1d5e456cb31701c/services/resource_coordinator/memory_instrumentation/coordinator_impl_unittest.cc
[modify] https://crrev.com/98e8b7f9910e484189d4806ee1d5e456cb31701c/services/resource_coordinator/memory_instrumentation/queued_request.h
[modify] https://crrev.com/98e8b7f9910e484189d4806ee1d5e456cb31701c/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation.cc
[modify] https://crrev.com/98e8b7f9910e484189d4806ee1d5e456cb31701c/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation_struct_traits.cc
[modify] https://crrev.com/98e8b7f9910e484189d4806ee1d5e456cb31701c/services/resource_coordinator/public/cpp/memory_instrumentation/struct_traits_unittest.cc
[modify] https://crrev.com/98e8b7f9910e484189d4806ee1d5e456cb31701c/services/resource_coordinator/public/cpp/memory_instrumentation/tracing_observer.cc
[modify] https://crrev.com/98e8b7f9910e484189d4806ee1d5e456cb31701c/services/resource_coordinator/public/interfaces/memory_instrumentation/memory_instrumentation.mojom

Comment 8 by lalitm@chromium.org, Oct 26 2017

Blockedon: 768373
Cc: hjd@chromium.org
Owner: ----
Status: Available (was: Started)
This is going to need to wait until after we have the full graph processing code landed. Too much code is conditional on BACKGROUND being the level of detail that we can't make it a level of detail.

Instead when the code is ready, we will directly just remove SUMMARY_ONLY.
Project Member

Comment 9 by sheriffbot@chromium.org, Oct 26

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment