Background context: go/memory-infra Remove the dump id arg from RequestGlobalMemoryDump solving this TODO: https://cs.chromium.org/chromium/src/services/resource_coordinator/memory_instrumentation/coordinator_impl.cc?q=coordinator_impl&sq=package:chromium&l=168
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae67c486ce91951a5ef5e38b78ebdf567fac54a3 commit ae67c486ce91951a5ef5e38b78ebdf567fac54a3 Author: Hector Dearman <hjd@google.com> Date: Thu Oct 26 18:20:33 2017 memory-infra: Split global from local RequestDumpArgs memory_instrumentation::RequestGlobalMemoryDump api should not contain guid argument. Bug: 775037 Bug: 777820 Change-Id: I057065eaf1ac6ed6a295343413d7236463c6ac55 Reviewed-on: https://chromium-review.googlesource.com/723461 Commit-Queue: Hector Dearman <hjd@chromium.org> Reviewed-by: Siddhartha S <ssid@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#511885} [modify] https://crrev.com/ae67c486ce91951a5ef5e38b78ebdf567fac54a3/base/trace_event/memory_dump_manager.cc [modify] https://crrev.com/ae67c486ce91951a5ef5e38b78ebdf567fac54a3/base/trace_event/memory_dump_manager.h [modify] https://crrev.com/ae67c486ce91951a5ef5e38b78ebdf567fac54a3/base/trace_event/memory_dump_manager_test_utils.h [modify] https://crrev.com/ae67c486ce91951a5ef5e38b78ebdf567fac54a3/base/trace_event/memory_dump_request_args.h [modify] https://crrev.com/ae67c486ce91951a5ef5e38b78ebdf567fac54a3/chrome/browser/metrics/process_memory_metrics_emitter.cc [modify] https://crrev.com/ae67c486ce91951a5ef5e38b78ebdf567fac54a3/services/resource_coordinator/memory_instrumentation/coordinator_impl.cc [modify] https://crrev.com/ae67c486ce91951a5ef5e38b78ebdf567fac54a3/services/resource_coordinator/memory_instrumentation/coordinator_impl.h [modify] https://crrev.com/ae67c486ce91951a5ef5e38b78ebdf567fac54a3/services/resource_coordinator/memory_instrumentation/coordinator_impl_unittest.cc [modify] https://crrev.com/ae67c486ce91951a5ef5e38b78ebdf567fac54a3/services/resource_coordinator/public/cpp/memory_instrumentation/client_process_impl.cc [modify] https://crrev.com/ae67c486ce91951a5ef5e38b78ebdf567fac54a3/services/resource_coordinator/public/cpp/memory_instrumentation/client_process_impl.h [modify] https://crrev.com/ae67c486ce91951a5ef5e38b78ebdf567fac54a3/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation.cc [modify] https://crrev.com/ae67c486ce91951a5ef5e38b78ebdf567fac54a3/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation.typemap [modify] https://crrev.com/ae67c486ce91951a5ef5e38b78ebdf567fac54a3/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation_struct_traits.cc [modify] https://crrev.com/ae67c486ce91951a5ef5e38b78ebdf567fac54a3/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation_struct_traits.h [modify] https://crrev.com/ae67c486ce91951a5ef5e38b78ebdf567fac54a3/services/resource_coordinator/public/cpp/memory_instrumentation/tracing_integration_unittest.cc [modify] https://crrev.com/ae67c486ce91951a5ef5e38b78ebdf567fac54a3/services/resource_coordinator/public/interfaces/memory_instrumentation/memory_instrumentation.mojom
The above commit should fix this bug
Comment 1 by hjd@chromium.org
, Oct 17 2017Status: Started (was: Available)