Make VM_REGIONS_ONLY a LevelOfDetail |
||||||
Issue descriptionBackground context: go/memory-infra Currently VM_REGIONS_ONLY is a type of memory dump (MemoryDumpType) which does not make much sense considering that it talks about how much data should be returned in the response rather than why the data is being collected. Change the enum member to be a member of MemoryDumpLevelOfDetail which more closely reflects its purpose.
,
Oct 16 2017
,
Oct 16 2017
,
Oct 17 2017
,
Oct 24 2017
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/376991ca05d1dfc07ccc8b3d90e0497a4d3e3788 commit 376991ca05d1dfc07ccc8b3d90e0497a4d3e3788 Author: Lalit Maganti <lalitm@chromium.org> Date: Tue Oct 24 18:59:28 2017 memory-infra: move VM_REGIONS_ONLY from a type to level of detail VM_REGIONS_ONLY never made sense as a type. It was talking about what needed to be returned which is captured by level of detail rather than the type. With the big refactoring of the whole memory dump arguments incoming, moving this clears the path for working on more complex issues in the system. Bug: 775034 Bug: 777820 Change-Id: If2ada9c4dd3cbd25a1c5b49dec2ec3e68f9c4f95 Reviewed-on: https://chromium-review.googlesource.com/735323 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Primiano Tucci <primiano@chromium.org> Commit-Queue: Lalit Maganti <lalitm@chromium.org> Cr-Commit-Position: refs/heads/master@{#511221} [modify] https://crrev.com/376991ca05d1dfc07ccc8b3d90e0497a4d3e3788/base/trace_event/memory_dump_request_args.cc [modify] https://crrev.com/376991ca05d1dfc07ccc8b3d90e0497a4d3e3788/base/trace_event/memory_dump_request_args.h [modify] https://crrev.com/376991ca05d1dfc07ccc8b3d90e0497a4d3e3788/base/trace_event/memory_dump_scheduler.cc [modify] https://crrev.com/376991ca05d1dfc07ccc8b3d90e0497a4d3e3788/services/resource_coordinator/memory_instrumentation/coordinator_impl.cc [modify] https://crrev.com/376991ca05d1dfc07ccc8b3d90e0497a4d3e3788/services/resource_coordinator/memory_instrumentation/queued_request.h [modify] https://crrev.com/376991ca05d1dfc07ccc8b3d90e0497a4d3e3788/services/resource_coordinator/memory_instrumentation/queued_request_dispatcher.cc [modify] https://crrev.com/376991ca05d1dfc07ccc8b3d90e0497a4d3e3788/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation_struct_traits.cc [modify] https://crrev.com/376991ca05d1dfc07ccc8b3d90e0497a4d3e3788/services/resource_coordinator/public/interfaces/memory_instrumentation/memory_instrumentation.mojom
,
Oct 25 2017
Done using the above commit |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by lalitm@chromium.org
, Oct 16 2017