We are using error prone versions from 2 years ago (2.0.5 & 2.0.6).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f22fda88430b7ebcca5a6ef2df26d8b92f21e33f commit f22fda88430b7ebcca5a6ef2df26d8b92f21e33f Author: Peter Wen <wnwen@chromium.org> Date: Mon Oct 23 14:50:12 2017 Android: Update errorprone to 2.0.15 Fixes newly introduced errors. BUG= 775031 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id28040cbec39dc1f252a28a4729bb7596300ef0a Reviewed-on: https://chromium-review.googlesource.com/726163 Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Steven Valdez <svaldez@chromium.org> Reviewed-by: Bence Béky <bnc@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#510789} [modify] https://crrev.com/f22fda88430b7ebcca5a6ef2df26d8b92f21e33f/DEPS [modify] https://crrev.com/f22fda88430b7ebcca5a6ef2df26d8b92f21e33f/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java [modify] https://crrev.com/f22fda88430b7ebcca5a6ef2df26d8b92f21e33f/components/cronet/android/test/javatests/src/org/chromium/net/CronetUploadTest.java [modify] https://crrev.com/f22fda88430b7ebcca5a6ef2df26d8b92f21e33f/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java [modify] https://crrev.com/f22fda88430b7ebcca5a6ef2df26d8b92f21e33f/content/public/android/junit/src/org/chromium/content/browser/input/RangeTest.java [modify] https://crrev.com/f22fda88430b7ebcca5a6ef2df26d8b92f21e33f/net/android/javatests/src/org/chromium/net/AndroidKeyStoreTestUtil.java [modify] https://crrev.com/f22fda88430b7ebcca5a6ef2df26d8b92f21e33f/remoting/android/java/src/org/chromium/chromoting/Chromoting.java [modify] https://crrev.com/f22fda88430b7ebcca5a6ef2df26d8b92f21e33f/services/service_manager/public/java/src/org/chromium/services/service_manager/InterfaceProvider.java [modify] https://crrev.com/f22fda88430b7ebcca5a6ef2df26d8b92f21e33f/services/service_manager/public/java/src/org/chromium/services/service_manager/InterfaceRegistry.java [modify] https://crrev.com/f22fda88430b7ebcca5a6ef2df26d8b92f21e33f/third_party/errorprone/BUILD.gn [modify] https://crrev.com/f22fda88430b7ebcca5a6ef2df26d8b92f21e33f/third_party/errorprone/README.chromium
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e5c2bb47fab12af0f8e05726de234bd2b6d4680 commit 9e5c2bb47fab12af0f8e05726de234bd2b6d4680 Author: Peter Wen <wnwen@chromium.org> Date: Wed Nov 15 16:46:13 2017 Android: Update errorprone to 2.1.2 Brings us up to the latest release by the errorprone team. * Suppresses "RestrictTo" checks for classes meant to override support classes. * Removes legacy javac options and suppressions that have been fixed in errorprone. * Add bootclasspath as errorprone now uses JDK 9, needing its classes first in the class loader. BUG= 775031 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I33781453e7551aa494a1cbb7c4757c2c0dbca315 Reviewed-on: https://chromium-review.googlesource.com/761318 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#516719} [modify] https://crrev.com/9e5c2bb47fab12af0f8e05726de234bd2b6d4680/DEPS [modify] https://crrev.com/9e5c2bb47fab12af0f8e05726de234bd2b6d4680/base/android/javatests/src/org/chromium/base/ObserverListTest.java [modify] https://crrev.com/9e5c2bb47fab12af0f8e05726de234bd2b6d4680/build/android/gyp/javac.py [modify] https://crrev.com/9e5c2bb47fab12af0f8e05726de234bd2b6d4680/build/android/lint/suppressions.xml [modify] https://crrev.com/9e5c2bb47fab12af0f8e05726de234bd2b6d4680/chrome/android/BUILD.gn [modify] https://crrev.com/9e5c2bb47fab12af0f8e05726de234bd2b6d4680/chrome/android/java/ChromeVersionConstants.java.version [modify] https://crrev.com/9e5c2bb47fab12af0f8e05726de234bd2b6d4680/chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java [modify] https://crrev.com/9e5c2bb47fab12af0f8e05726de234bd2b6d4680/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java [modify] https://crrev.com/9e5c2bb47fab12af0f8e05726de234bd2b6d4680/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsRecyclerView.java [modify] https://crrev.com/9e5c2bb47fab12af0f8e05726de234bd2b6d4680/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNavigationItemView.java [modify] https://crrev.com/9e5c2bb47fab12af0f8e05726de234bd2b6d4680/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationItemView.java [modify] https://crrev.com/9e5c2bb47fab12af0f8e05726de234bd2b6d4680/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationMenu.java [modify] https://crrev.com/9e5c2bb47fab12af0f8e05726de234bd2b6d4680/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationMenuView.java [modify] https://crrev.com/9e5c2bb47fab12af0f8e05726de234bd2b6d4680/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationPresenter.java [modify] https://crrev.com/9e5c2bb47fab12af0f8e05726de234bd2b6d4680/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationView.java [modify] https://crrev.com/9e5c2bb47fab12af0f8e05726de234bd2b6d4680/components/cronet/android/java/src/org/chromium/net/impl/JavaUrlRequest.java [modify] https://crrev.com/9e5c2bb47fab12af0f8e05726de234bd2b6d4680/remoting/android/java/src/org/chromium/chromoting/SessionConnector.java [modify] https://crrev.com/9e5c2bb47fab12af0f8e05726de234bd2b6d4680/third_party/errorprone/BUILD.gn [modify] https://crrev.com/9e5c2bb47fab12af0f8e05726de234bd2b6d4680/third_party/errorprone/README.chromium
I'm seeing failures on the Chromium Perf arm64 builder because of this: https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20arm64%20Builder/builds/164548 Is there any bug tracking these failures?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd commit dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd Author: Peter Wen <wnwen@chromium.org> Date: Wed Nov 15 18:59:42 2017 Android: Add missing @Override annotations This fixes errorprone MissingOverride warnings. Used '-XepPatchChecks:MissingOverride' and '-XepPatchLocation:IN_PLACE' to automatically add the annotations. TBR for cross-repo refactoring. BUG= 775031 TBR=torne@chromium.org,sdefresne@chromium.org,rockot@chromium.org,xunjieli@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I2fd028dcf6ab9fdf5ea1e2dab2215a52dffe8b21 Reviewed-on: https://chromium-review.googlesource.com/766516 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Xi Han <hanxi@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#516770} [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/base/android/junit/src/org/chromium/base/process_launcher/ChildProcessConnectionTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/base/test/android/javatests/src/org/chromium/base/test/BaseActivityInstrumentationTestCase.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/base/test/android/junit/src/org/chromium/base/test/util/MinAndroidSdkLevelSkipCheckTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/base/test/android/junit/src/org/chromium/base/test/util/RestrictionSkipCheckTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderService.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderServiceHost.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebShareEntryActivity.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/java/src/org/chromium/chrome/browser/widget/ThumbnailDiskStorage.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/javatests/src/org/chromium/chrome/browser/WebShareTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/javatests/src/org/chromium/chrome/browser/feature_engagement/ScreenshotMonitorTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesBasicTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/junit/src/org/chromium/chrome/browser/AppIndexingUtilTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/junit/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManagerTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/CastMessageHandlerTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/DiscoveryCallbackTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationFaviconTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerTestBase.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeUnitTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTaskUnitTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/junit/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManagerTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImpl.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/webapk/shell_apk/shell_apk_version.gni [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/IdentityService.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/chrome/test/android/javatests/src/org/chromium/chrome/test/MultiActivityTestCommon.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/components/background_task_scheduler/android/java/src/org/chromium/components/background_task_scheduler/BackgroundTaskSchedulerPrefs.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/components/background_task_scheduler/android/java/src/org/chromium/components/background_task_scheduler/BackgroundTaskSchedulerUma.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/components/invalidation/impl/android/javatests/src/org/chromium/components/invalidation/InvalidationClientServiceTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploaderImplTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/device/geolocation/android/junit/src/org/chromium/device/geolocation/LocationProviderTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/device/vr/android/java/src/org/chromium/device/vr/NonPresentingGvrContext.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/net/test/android/javatests/src/org/chromium/net/test/util/NetworkChangeNotifierTestUtil.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/remoting/android/java/src/org/chromium/chromoting/ChromotingDownloadManager.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/remoting/android/java/src/org/chromium/chromoting/Desktop.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/remoting/android/java/src/org/chromium/chromoting/Event.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/remoting/android/java/src/org/chromium/chromoting/accountswitcher/AccountSwitcherBasic.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/remoting/android/java/src/org/chromium/chromoting/jni/Client.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/services/device/nfc/android/junit/src/org/chromium/device/nfc/NFCTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/services/shape_detection/android/javatests/src/org/chromium/shape_detection/BarcodeDetectionImplTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/services/shape_detection/android/javatests/src/org/chromium/shape_detection/FaceDetectionImplTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/services/shape_detection/android/javatests/src/org/chromium/shape_detection/TextDetectionImplTest.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/testing/android/appurify_support/java/src/org/chromium/test/support/RobotiumBundleGenerator.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/testing/android/junit/java/src/org/chromium/testing/local/BackgroundShadowAsyncTask.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/testing/android/junit/java/src/org/chromium/testing/local/CustomShadowAsyncTask.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/testing/android/junit/java/src/org/chromium/testing/local/GtestComputer.java [modify] https://crrev.com/dd3a51e0e5a3c9555590770caf0ebcec8c2ee8bd/testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusListener.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6686c0001a1c308024788485783468485ddfce9d commit 6686c0001a1c308024788485783468485ddfce9d Author: Peter Wen <wnwen@chromium.org> Date: Wed Nov 15 21:51:48 2017 Reland "Android: Update errorprone to 2.1.2" Original CL: https://crrev.com/c/761318 Changes: - Suppress additional warning in ChromeVersionConstants BUG= 775031 , 785324 TBR=nyquist@chromium.org,yuweih@chromium.org,kapishnikov@chromium.org,agrieve@chromium.org Change-Id: I2c38e5fca25af5e6993477fcacf426df113fb2f0 Reviewed-on: https://chromium-review.googlesource.com/772000 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#516840} [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/DEPS [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/base/android/javatests/src/org/chromium/base/ObserverListTest.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/build/android/gyp/javac.py [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/build/android/lint/suppressions.xml [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/BUILD.gn [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/java/ChromeVersionConstants.java.version [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsRecyclerView.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNavigationItemView.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationItemView.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationMenu.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationMenuView.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationPresenter.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationView.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/components/cronet/android/java/src/org/chromium/net/impl/JavaUrlRequest.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/remoting/android/java/src/org/chromium/chromoting/SessionConnector.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/third_party/errorprone/BUILD.gn [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/third_party/errorprone/README.chromium
Comment 1 by bugdroid1@chromium.org
, Oct 23 2017