New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775018 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove notifications on successful rename of External Drive

Project Member Reported by weifangsun@chromium.org, Oct 16 2017

Issue description

We should keep the process the same as when renaming files rather than an operation like formatting. Generally, we should not trigger notifications unless needed.
 

Comment 1 by klemenko@google.com, Oct 17 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f07ee0890c5184f72df6ebfa8e66dff0b95c4b33

commit f07ee0890c5184f72df6ebfa8e66dff0b95c4b33
Author: Klemen Kozjek <klemenko@google.com>
Date: Tue Oct 17 07:38:01 2017

Files App: Remove notifications for external drive rename

This CL removes notifications to indicate successfully completed and
pending operation of an external drive rename. Related strings will be
removed in CL:722460.

Bug:  775018 
Test: browser_tests --gtest_filter=FileManagerJsTest.DeviceHandlerTest
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3eb43a6f4cc4f53214e074813e04f561262d7767
Reviewed-on: https://chromium-review.googlesource.com/722140
Commit-Queue: Klemen Kozjek <klemenko@google.com>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509315}
[modify] https://crrev.com/f07ee0890c5184f72df6ebfa8e66dff0b95c4b33/ui/file_manager/file_manager/background/js/device_handler.js
[modify] https://crrev.com/f07ee0890c5184f72df6ebfa8e66dff0b95c4b33/ui/file_manager/file_manager/background/js/device_handler_unittest.js

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef60662c9e164a2d1af17562b6e4732a516c1f8b

commit ef60662c9e164a2d1af17562b6e4732a516c1f8b
Author: Klemen Kozjek <klemenko@google.com>
Date: Tue Oct 17 08:20:04 2017

Files App: Remove unused translations

This CL removes translation strings for external drive rename notifications,
because they are no longer in use.

BUG= 775018 
CQ-DEPEND=CL:722140

Change-Id: Ia85cc845302f0db83e6dcad88445d2f774bb704a
Reviewed-on: https://chromium-review.googlesource.com/722460
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Klemen Kozjek <klemenko@google.com>
Cr-Commit-Position: refs/heads/master@{#509323}
[modify] https://crrev.com/ef60662c9e164a2d1af17562b6e4732a516c1f8b/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/ef60662c9e164a2d1af17562b6e4732a516c1f8b/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc

Comment 4 by klemenko@google.com, Oct 17 2017

Status: Fixed (was: Started)

Comment 5 by klemenko@google.com, Oct 17 2017

Labels: Merge-Request-63
Project Member

Comment 6 by sheriffbot@chromium.org, Oct 18 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 47 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by klemenko@google.com, Oct 18 2017

To #6.

If we are not allowed to make changes to *.grdp after branch cut, could we at least merge commit f07ee0890c5184f72df6ebfa8e66dff0b95c4b33 (comment #2)?
For additional context - We should merge this back to M63 if possible as this was an update requested by UI review as well.
Labels: -Merge-Review-63 Merge-Approved-63
Owner: yamaguchi@chromium.org
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 27 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5deae76b0255eb24e9c4bf46441b291c2d656cf

commit f5deae76b0255eb24e9c4bf46441b291c2d656cf
Author: Klemen Kozjek <klemenko@google.com>
Date: Fri Oct 27 03:12:36 2017

Files App: Remove notifications for external drive rename

This CL removes notifications to indicate successfully completed and
pending operation of an external drive rename. Related strings will be
removed in CL:722460.

Bug:  775018 
Test: browser_tests --gtest_filter=FileManagerJsTest.DeviceHandlerTest
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3eb43a6f4cc4f53214e074813e04f561262d7767
Reviewed-on: https://chromium-review.googlesource.com/722140
Commit-Queue: Klemen Kozjek <klemenko@google.com>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509315}(cherry picked from commit f07ee0890c5184f72df6ebfa8e66dff0b95c4b33)
Reviewed-on: https://chromium-review.googlesource.com/741281
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#259}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/f5deae76b0255eb24e9c4bf46441b291c2d656cf/ui/file_manager/file_manager/background/js/device_handler.js
[modify] https://crrev.com/f5deae76b0255eb24e9c4bf46441b291c2d656cf/ui/file_manager/file_manager/background/js/device_handler_unittest.js

Labels: -Hotlist-Merge-Review

Sign in to add a comment