New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775017 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Add feedback collection to Tricium

Project Member Reported by emso@chromium.org, Oct 16 2017

Issue description

Extend the Tricium service to expose an endpoint collecting feedback.

The endpoint should support collection of 'not useful' feedback for robot comments.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c1ec1ceb1c58c14d839e6ec00154510aa2dcbc79

commit c1ec1ceb1c58c14d839e6ec00154510aa2dcbc79
Author: Emma <emso@chromium.org>
Date: Thu Nov 23 09:27:55 2017

Adds comment UUIDs.

- Makes room for an UUID in the comment data format and in the tracking.
- Generates the UUID when tracking is added for a comment.
- Adds missing comment selection in the gerrit reporter.

Bug:775017
Change-Id: I0738581e67e7fca279a43331e5a8cb893ab85170
Reviewed-on: https://chromium-review.googlesource.com/785675
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Emma Söderberg <emso@chromium.org>

[modify] https://crrev.com/c1ec1ceb1c58c14d839e6ec00154510aa2dcbc79/go/src/infra/tricium/appengine/common/track/track.go
[modify] https://crrev.com/c1ec1ceb1c58c14d839e6ec00154510aa2dcbc79/go/src/infra/tricium/appengine/gerrit/gerrit_test.go
[modify] https://crrev.com/c1ec1ceb1c58c14d839e6ec00154510aa2dcbc79/go/src/infra/tricium/appengine/tracker/rpc_worker_done.go
[modify] https://crrev.com/c1ec1ceb1c58c14d839e6ec00154510aa2dcbc79/go/src/infra/tricium/api/v1/data.pb.go
[modify] https://crrev.com/c1ec1ceb1c58c14d839e6ec00154510aa2dcbc79/go/src/infra/tricium/api/v1/data.proto
[modify] https://crrev.com/c1ec1ceb1c58c14d839e6ec00154510aa2dcbc79/go/src/infra/tricium/api/v1/pb.discovery.go
[modify] https://crrev.com/c1ec1ceb1c58c14d839e6ec00154510aa2dcbc79/go/src/infra/tricium/appengine/gerrit/gerrit.go
[modify] https://crrev.com/c1ec1ceb1c58c14d839e6ec00154510aa2dcbc79/go/src/infra/tricium/appengine/gerrit/rpc_report_results.go
[modify] https://crrev.com/c1ec1ceb1c58c14d839e6ec00154510aa2dcbc79/go/src/infra/tricium/appengine/gerrit/rpc_report_results_test.go

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4a677ceb7f514df1e3e7acb3244d600e5b45708a

commit 4a677ceb7f514df1e3e7acb3244d600e5b45708a
Author: Emma <emso@chromium.org>
Date: Thu Nov 23 14:10:35 2017

Adds comment creation time.

This enabled filtering on time when summarizing analyzer feedback.

Bug:775017
Change-Id: Iaf4987ee81c63469cfb3103197bda32f2d101f44
Reviewed-on: https://chromium-review.googlesource.com/787370
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Emma Söderberg <emso@chromium.org>

[modify] https://crrev.com/4a677ceb7f514df1e3e7acb3244d600e5b45708a/go/src/infra/tricium/appengine/common/track/track.go
[modify] https://crrev.com/4a677ceb7f514df1e3e7acb3244d600e5b45708a/go/src/infra/tricium/appengine/tracker/rpc_worker_done.go

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ad252d1144fead4f41844a2e0b4907f40811e8e7

commit ad252d1144fead4f41844a2e0b4907f40811e8e7
Author: Emma <emso@chromium.org>
Date: Mon Nov 27 07:32:14 2017

Adds Feedback RPCs.

- Adds report RPC for 'not useful' feedback.
- Adds feedback RPC for analyzer feedback summaries.
- Adds index for feedback queries.
- Adds field to tracked comments to support feedback queries.

Bug:775017
Change-Id: Ib99cc6d05fcd33a1ac14cca33453126aad8864a7
Reviewed-on: https://chromium-review.googlesource.com/774839
Commit-Queue: Emma Söderberg <emso@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/ad252d1144fead4f41844a2e0b4907f40811e8e7/go/src/infra/tricium/appengine/common/track/track.go
[add] https://crrev.com/ad252d1144fead4f41844a2e0b4907f40811e8e7/go/src/infra/tricium/appengine/frontend/rpc_report.go
[add] https://crrev.com/ad252d1144fead4f41844a2e0b4907f40811e8e7/go/src/infra/tricium/appengine/frontend/rpc_feedback.go
[add] https://crrev.com/ad252d1144fead4f41844a2e0b4907f40811e8e7/go/src/infra/tricium/appengine/frontend/rpc_report_test.go
[modify] https://crrev.com/ad252d1144fead4f41844a2e0b4907f40811e8e7/go/src/infra/tricium/api/v1/tricium.pb.go
[add] https://crrev.com/ad252d1144fead4f41844a2e0b4907f40811e8e7/go/src/infra/tricium/appengine/frontend/rpc_feedback_test.go
[modify] https://crrev.com/ad252d1144fead4f41844a2e0b4907f40811e8e7/go/src/infra/tricium/appengine/tracker/rpc_worker_done.go
[modify] https://crrev.com/ad252d1144fead4f41844a2e0b4907f40811e8e7/go/src/infra/tricium/api/v1/config.pb.go
[modify] https://crrev.com/ad252d1144fead4f41844a2e0b4907f40811e8e7/go/src/infra/tricium/api/v1/pb.discovery.go
[add] https://crrev.com/ad252d1144fead4f41844a2e0b4907f40811e8e7/go/src/infra/tricium/appengine/frontend/index.yaml
[modify] https://crrev.com/ad252d1144fead4f41844a2e0b4907f40811e8e7/go/src/infra/tricium/api/v1/v1.infra_testing
[modify] https://crrev.com/ad252d1144fead4f41844a2e0b4907f40811e8e7/go/src/infra/tricium/api/v1/tricium.proto

Comment 4 by emso@chromium.org, Nov 27 2017

Status: Fixed (was: Assigned)

Sign in to add a comment