Don't add passwords through navigation, add them directly to the TestPasswordStore instead.
Reported by
nikhil.s...@samsung.com,
Oct 16 2017
|
|||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 Steps to reproduce the problem: 1. In file password_manager_browsertest.cc password is added through navigation in CrossSiteIframeNotFillTest test. What is the expected behavior? As Navigation slows the test down and can introduce sources of failure unrelated to the tested property , password should be added directly to the TestPasswordStore and not through navigation. What went wrong? Password is added through navigation Did this work before? No Chrome version: <Copy from: 'about:version'> Channel: stable OS Version: Flash Version:
,
Oct 17 2017
Thanks, Nikhil, for filing the ticket, and sorry, ligimole@, if it was confusing. This is not a bug report, it's a code health task my team needs to fix at some point. Changing labels accordingly.
,
Oct 17 2017
(Also for the record, https://chromium-review.googlesource.com/c/chromium/src/+/704435 is the change which prompted this ticket and contains more background.)
,
Oct 17 2017
I am working to correct this as well.
,
Oct 23 2017
Marking accordingly to #4.
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5c2c2d1532db356a93ee1e65dd56132215d7168 commit e5c2c2d1532db356a93ee1e65dd56132215d7168 Author: nikhil <nikhil.sahni@samsung.com> Date: Tue Oct 24 12:35:13 2017 Password should be added using TestPasswordStore. Adding password through navigation slows the test down and can introduce sources of failure unrelated to the tested property. It should use TestPasswordStore instead of navigation. BUG=775016 Change-Id: I0dcb20b2e5324b301e0071744b501305b7ba9185 Reviewed-on: https://chromium-review.googlesource.com/732808 Reviewed-by: Vaclav Brozek <vabr@chromium.org> Reviewed-by: Shanmuga Pandi <shanmuga.m@samsung.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#511116} [modify] https://crrev.com/e5c2c2d1532db356a93ee1e65dd56132215d7168/chrome/browser/password_manager/password_manager_browsertest.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by ligim...@chromium.org
, Oct 16 2017