sensors: SensorErrorEvent constructor does not parse |errorEventInitDict| |
||
Issue descriptionSee https://github.com/w3c/web-platform-tests/pull/7763 and the failing test being imported in https://chromium-review.googlesource.com/c/chromium/src/+/720407 The SensorErrorEvent::SensorErrorEvent(const AtomicString& event_type, const SensorErrorEventInit& initializer) overload is just forwarding |initializer| to Event and not parsing the object's contents, leaving us with an unset |error_|.
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec3d9ebab41efcfdcea80a45d639848daf1b2161 commit ec3d9ebab41efcfdcea80a45d639848daf1b2161 Author: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Date: Mon Oct 16 19:35:27 2017 [Sensors] Fix SensorErrorEvent constructor This patch fixes SensorErrorEvent constructor so that it considers the given initializer. The test is being added at: https://chromium-review.googlesource.com/c/chromium/src/+/720407 Also nullable specifier is removed from SensorOptions.frequency field as it follows from the updated ED specification: https://w3c.github.io/sensors/#the-sensor-interface Bug: 775001 Change-Id: Ib20994ed89981e948ec739fc13033653278c92e7 Reviewed-on: https://chromium-review.googlesource.com/719819 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Reviewed-by: Alexander Shalamov <alexander.shalamov@intel.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#509140} [delete] https://crrev.com/a35501faaac641c8f5683f1015a68c4ca35cc28a/third_party/WebKit/LayoutTests/external/wpt/generic-sensor/SensorErrorEvent-constructor-expected.txt [modify] https://crrev.com/ec3d9ebab41efcfdcea80a45d639848daf1b2161/third_party/WebKit/Source/modules/sensor/SensorErrorEvent.cpp [modify] https://crrev.com/ec3d9ebab41efcfdcea80a45d639848daf1b2161/third_party/WebKit/Source/modules/sensor/SensorErrorEventInit.idl [modify] https://crrev.com/ec3d9ebab41efcfdcea80a45d639848daf1b2161/third_party/WebKit/Source/modules/sensor/SensorOptions.idl
,
Oct 16 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by mikhail....@intel.com
, Oct 16 2017Status: Started (was: Available)