Add UMA stats for reasons of returning invalid parameters from AudioManagerWin::GetPreferredOutputStreamParameters() |
|||
Issue descriptionInvalid parameters returned from AudioManagerWin::GetPreferredOutputStreamParameters() is the root cause of fallback to a fake output stream in AudioManagerBase::MakeAudioOutputStreamProxy() [https://cs.chromium.org/chromium/src/media/audio/audio_manager_base.cc?type=cs&q=%22AudioOutputStreamProxy.%22&l=302] We need to clarify what's causing that.
,
Oct 24 2017
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4c44cc2491da7b2fc70cd9a1fb4a909993401c7 commit e4c44cc2491da7b2fc70cd9a1fb4a909993401c7 Author: Marina Ciocea <marinaciocea@chromium.org> Date: Tue Oct 31 10:20:58 2017 Refactor GetPreferredAudioParameters from core audio util on Windows Split GetPreferredAudioParameters functions to improve readability, move helper functions to unnamed namespace, fix typo. R=maxmorin@chromium.org, olka@chromium.org Bug: 774998 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I630e02dc73152eaf662a94ef0e1a4150a8ebcec9 Reviewed-on: https://chromium-review.googlesource.com/743361 Reviewed-by: Olga Sharonova <olka@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#512794} [modify] https://crrev.com/e4c44cc2491da7b2fc70cd9a1fb4a909993401c7/media/audio/win/audio_low_latency_output_win.cc [modify] https://crrev.com/e4c44cc2491da7b2fc70cd9a1fb4a909993401c7/media/audio/win/core_audio_util_win.cc [modify] https://crrev.com/e4c44cc2491da7b2fc70cd9a1fb4a909993401c7/media/audio/win/core_audio_util_win.h
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/949224b603328994c8c3d08bd7a72c50f391e563 commit 949224b603328994c8c3d08bd7a72c50f391e563 Author: Marina Ciocea <marinaciocea@chromium.org> Date: Wed Nov 01 16:39:05 2017 Refactor core audio util for Windows In functions that handle creation of IMMDeviceEnumerator, IMMDevice or IAudioClient objects, propagate error code through return value and pass in the object to be created as parameter. Bug: 774998 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icaab3ccbbe7441e7062597c1dc1ea547cb670952 Reviewed-on: https://chromium-review.googlesource.com/749322 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#513150} [modify] https://crrev.com/949224b603328994c8c3d08bd7a72c50f391e563/media/audio/win/audio_device_listener_win.cc [modify] https://crrev.com/949224b603328994c8c3d08bd7a72c50f391e563/media/audio/win/audio_low_latency_output_win.cc [modify] https://crrev.com/949224b603328994c8c3d08bd7a72c50f391e563/media/audio/win/core_audio_util_win.cc [modify] https://crrev.com/949224b603328994c8c3d08bd7a72c50f391e563/media/audio/win/core_audio_util_win.h [modify] https://crrev.com/949224b603328994c8c3d08bd7a72c50f391e563/media/audio/win/core_audio_util_win_unittest.cc
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e3f815437d4186aeb943e965f420e707b6a67b7 commit 2e3f815437d4186aeb943e965f420e707b6a67b7 Author: Marina Ciocea <marinaciocea@chromium.org> Date: Thu Nov 02 09:44:41 2017 Revert "Refactor core audio util for Windows" This reverts commit 949224b603328994c8c3d08bd7a72c50f391e563. Reason for revert: <INSERT REASONING HERE> Original change's description: > Refactor core audio util for Windows > > In functions that handle creation of IMMDeviceEnumerator, > IMMDevice or IAudioClient objects, propagate error code through > return value and pass in the object to be created as parameter. > > Bug: 774998 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Icaab3ccbbe7441e7062597c1dc1ea547cb670952 > Reviewed-on: https://chromium-review.googlesource.com/749322 > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > Reviewed-by: Max Morin <maxmorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#513150} TBR=maxmorin@chromium.org,marinaciocea@chromium.org Change-Id: I9bf77addb19dc98a40730cbc71f16ba9764fbfc8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 774998 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/750739 Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#513436} [modify] https://crrev.com/2e3f815437d4186aeb943e965f420e707b6a67b7/media/audio/win/audio_device_listener_win.cc [modify] https://crrev.com/2e3f815437d4186aeb943e965f420e707b6a67b7/media/audio/win/audio_low_latency_output_win.cc [modify] https://crrev.com/2e3f815437d4186aeb943e965f420e707b6a67b7/media/audio/win/core_audio_util_win.cc [modify] https://crrev.com/2e3f815437d4186aeb943e965f420e707b6a67b7/media/audio/win/core_audio_util_win.h [modify] https://crrev.com/2e3f815437d4186aeb943e965f420e707b6a67b7/media/audio/win/core_audio_util_win_unittest.cc
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c487c4597d77811823840293fba6f100a7d0a6a7 commit c487c4597d77811823840293fba6f100a7d0a6a7 Author: Marina Ciocea <marinaciocea@chromium.org> Date: Thu Nov 16 12:21:00 2017 Add UMA stats for AudioManagerWin::GetPreferredOutputStreamParameters * Add uma logging callback to CreateDeviceEnumeratorInternal, CreateDeviceInternal and CreateClientInternal * Add 5 new histograms to track HRESULT of the steps in which GetPreferredOutputStreamParameters can potentially fail: creating device enumerator, creating device, creating client, getting shared-mode mix format and getting device period * Keep public only one version of each of the 3 CreateDevice, 3 CreateClient and 2 GetPreferredAudioParameters functions and move the behavior of removed public functions to internal functions * Refactor CreateDevice and CreateClient * Remove IsDefaultDevice that duplicates AudioDeviceDescription::IsDeviceDefault behavior * Remove unused functions DeviceIsDefault Bug: 774998 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8688f38a6b7bc8b093a95ba3ccf83f5b7eafaced Reviewed-on: https://chromium-review.googlesource.com/750807 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517063} [modify] https://crrev.com/c487c4597d77811823840293fba6f100a7d0a6a7/media/audio/win/audio_device_listener_win.cc [modify] https://crrev.com/c487c4597d77811823840293fba6f100a7d0a6a7/media/audio/win/audio_low_latency_output_win.cc [modify] https://crrev.com/c487c4597d77811823840293fba6f100a7d0a6a7/media/audio/win/core_audio_util_win.cc [modify] https://crrev.com/c487c4597d77811823840293fba6f100a7d0a6a7/media/audio/win/core_audio_util_win.h [modify] https://crrev.com/c487c4597d77811823840293fba6f100a7d0a6a7/media/audio/win/core_audio_util_win_unittest.cc [modify] https://crrev.com/c487c4597d77811823840293fba6f100a7d0a6a7/tools/metrics/histograms/enums.xml [modify] https://crrev.com/c487c4597d77811823840293fba6f100a7d0a6a7/tools/metrics/histograms/histograms.xml
,
Nov 16 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by olka@chromium.org
, Oct 16 2017