New issue
Advanced search Search tips

Issue 774977 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature



Sign in to add a comment

Add UMA metrics for NTP tile impressions broken down per icon type (favicon vs touch icon)

Project Member Reported by mastiz@chromium.org, Oct 16 2017

Issue description

Analogous to  crbug.com/773593  but for iOS, although with a different scope because icons from Web Manifests are currently not supported on iOS.

 

Comment 1 by pkl@chromium.org, Oct 16 2017

Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by fi...@chromium.org, Oct 17 2017

Labels: zine-triaged
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12188941485534a6a79906c59bca37fbcd1fe8eb

commit 12188941485534a6a79906c59bca37fbcd1fe8eb
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Oct 27 13:33:32 2017

Add FaviconAttributes subclass with iconType info

Some non-UI informations needs to be added to the FaviconAttributes
for logging purpose.
This CL creates a subclass of the FaviconAttributes to store the
information as a payload. The UI will use it as a standard
FaviconAttributes, respecting the layer separation.
The IconType is used for logging.

Bug:  774977 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib9edbaa419ffbdb7517279c41304460cb9d69c21
Reviewed-on: https://chromium-review.googlesource.com/725720
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512167}
[modify] https://crrev.com/12188941485534a6a79906c59bca37fbcd1fe8eb/ios/chrome/browser/content_suggestions/content_suggestions_favicon_mediator.mm
[modify] https://crrev.com/12188941485534a6a79906c59bca37fbcd1fe8eb/ios/chrome/browser/ui/favicon/BUILD.gn
[add] https://crrev.com/12188941485534a6a79906c59bca37fbcd1fe8eb/ios/chrome/browser/ui/favicon/favicon_attributes+private.h
[modify] https://crrev.com/12188941485534a6a79906c59bca37fbcd1fe8eb/ios/chrome/browser/ui/favicon/favicon_attributes.h
[modify] https://crrev.com/12188941485534a6a79906c59bca37fbcd1fe8eb/ios/chrome/browser/ui/favicon/favicon_attributes.mm
[modify] https://crrev.com/12188941485534a6a79906c59bca37fbcd1fe8eb/ios/chrome/browser/ui/favicon/favicon_attributes_provider.mm
[add] https://crrev.com/12188941485534a6a79906c59bca37fbcd1fe8eb/ios/chrome/browser/ui/favicon/favicon_attributes_with_payload.h
[add] https://crrev.com/12188941485534a6a79906c59bca37fbcd1fe8eb/ios/chrome/browser/ui/favicon/favicon_attributes_with_payload.mm
[modify] https://crrev.com/12188941485534a6a79906c59bca37fbcd1fe8eb/ios/chrome/browser/ui/ntp/BUILD.gn
[modify] https://crrev.com/12188941485534a6a79906c59bca37fbcd1fe8eb/ios/chrome/browser/ui/ntp/google_landing_mediator.mm
[modify] https://crrev.com/12188941485534a6a79906c59bca37fbcd1fe8eb/ios/chrome/browser/ui/ntp/metrics.mm

Status: Fixed (was: Assigned)

Sign in to add a comment