Rows in Telemetry tracing results html are not sorted |
|||
Issue descriptionSee the attached file results.html, the rows are not sorted, and the row order is different every time results.html was generated. I think it's better to sort the rows by name. Possible patch to sort rows by name: Add the following line in function build() in tracing/tracing/value/histogram_set_hierarchy.html: rootRows.sort((x, y) => x.name > y.name);
,
Oct 16 2017
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/6369a55f5ea1026e509d7f827ad42c7a4d904470 commit 6369a55f5ea1026e509d7f827ad42c7a4d904470 Author: benshayden <benjhayden@chromium.org> Date: Mon Oct 16 20:37:59 2017 Sort results.html by Name by default. HistogramSetLocation sets sortColumnIndex to undefined when there is no 'c' query parameter. This CL sets it to the correct default value, 0. http://www/~benjhayden/721880.html Bug: chromium:774967 Change-Id: I8c53c17842782614c5c1c8d3b28267b3baeae20f Reviewed-on: https://chromium-review.googlesource.com/721880 Reviewed-by: Simon Hatch <simonhatch@chromium.org> Commit-Queue: Ben Hayden <benjhayden@chromium.org> [modify] https://crrev.com/6369a55f5ea1026e509d7f827ad42c7a4d904470/tracing/tracing/value/ui/histogram_set_location.html
,
Oct 16 2017
You can use catapult/tracing/bin/histograms2html to patch the fix into existing results.html files or set "?c=0" in links to them.
,
Oct 17 2017
Thank you for the quick fix. |
|||
►
Sign in to add a comment |
|||
Comment 1 by vovoy@chromium.org
, Oct 16 2017