The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a94ae07b192cdabece086008d6617716cfbee229

commit a94ae07b192cdabece086008d6617716cfbee229
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Tue Oct 17 12:57:50 2017

Correctly vertically align the combobox in the save password dialog.

This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/718858.
The combobox should be center-aligned with the label like it used to be. Only the static password
label is top-aligned.

Bug:  774393 , 774962 
Change-Id: Id4fe1bf3a93d30f2d9748978afb91df08929726c
Reviewed-on: https://chromium-review.googlesource.com/723139
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509370}
[modify] https://crrev.com/a94ae07b192cdabece086008d6617716cfbee229/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

Tested the issue on Mac OS 10.12.6 using chrome M64 #63.0.3243.0 and observed as attached in screenshot.

Steps followed to verify :

1. Launched chrome and entered gmail credentials and password save bubble popped up and observed as attched.

Attached screenshot for reference.

@vasilii-- Could you please confirm if this is expected and so that we can add TE-Verified labels.

Thanks!

Deleted: 774962.png 26.0 KB

	774962.png 26.0 KB View Download

What you see is correct for the case of one password detected on the page. The combobox would appear if you have 2+ password fields (e.g. a change password form) and type different passwords into them. Then you can verify the fix.

Deleted: Screen Shot 2017-10-18 at 10.59.59.png 17.7 KB

	Screen Shot 2017-10-18 at 10.59.59.png 17.7 KB View Download

Thanks, Vasilii. There are some new issue now:

1. When the passwords are masked clicking the combo-box doesn't do anything. Instead clicking the combo box should always select the input text for editing. See attachment (1).

2. Clicking the view-password button focuses and selects the combo box text. Instead it should only reveal the password. See attachment (2).

Deleted: 1. Click combo box.gif 1.3 MB

	1. Click combo box.gif 1.3 MB View Download

Deleted: 2. Click button.gif 962 KB

	2. Click button.gif 962 KB View Download

Result from our discussion offline: let's switch to a pull-down button (like on other platforms) for now.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11a22464ccf7394596c428373b681e5699008c53

commit 11a22464ccf7394596c428373b681e5699008c53
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Oct 20 08:38:20 2017

Replace editable combobox with a pop up button in the password bubble.

The CL changes the Mac implementation to match that on Windows. Editing the password is not possible anymore.

Bug:  774962 
Change-Id: Iccd589baa3f9caf8ec038863d90e10cd6b8cdf18
Reviewed-on: https://chromium-review.googlesource.com/728759
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510380}
[modify] https://crrev.com/11a22464ccf7394596c428373b681e5699008c53/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.h
[modify] https://crrev.com/11a22464ccf7394596c428373b681e5699008c53/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm
[modify] https://crrev.com/11a22464ccf7394596c428373b681e5699008c53/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller_unittest.mm
[modify] https://crrev.com/11a22464ccf7394596c428373b681e5699008c53/chrome/browser/ui/cocoa/passwords/passwords_list_view_controller_unittest.mm
[modify] https://crrev.com/11a22464ccf7394596c428373b681e5699008c53/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.h
[modify] https://crrev.com/11a22464ccf7394596c428373b681e5699008c53/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm
[modify] https://crrev.com/11a22464ccf7394596c428373b681e5699008c53/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm
[modify] https://crrev.com/11a22464ccf7394596c428373b681e5699008c53/chrome/browser/ui/cocoa/passwords/signin_promo_view_controller_unittest.mm

I want to merge r510380 back, it's a requirement from the UX team. 

Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc6c2672edb3dd2d0dcd40e1de983e6ae9f4f426

commit dc6c2672edb3dd2d0dcd40e1de983e6ae9f4f426
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Tue Oct 24 11:29:30 2017

Replace editable combobox with a pop up button in the password bubble.

The CL changes the Mac implementation to match that on Windows. Editing the password is not possible anymore.

TBR=vasilii@chromium.org

(cherry picked from commit 11a22464ccf7394596c428373b681e5699008c53)

Bug:  774962 
Change-Id: Iccd589baa3f9caf8ec038863d90e10cd6b8cdf18
Reviewed-on: https://chromium-review.googlesource.com/728759
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510380}
Reviewed-on: https://chromium-review.googlesource.com/735151
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#174}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/dc6c2672edb3dd2d0dcd40e1de983e6ae9f4f426/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.h
[modify] https://crrev.com/dc6c2672edb3dd2d0dcd40e1de983e6ae9f4f426/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm
[modify] https://crrev.com/dc6c2672edb3dd2d0dcd40e1de983e6ae9f4f426/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller_unittest.mm
[modify] https://crrev.com/dc6c2672edb3dd2d0dcd40e1de983e6ae9f4f426/chrome/browser/ui/cocoa/passwords/passwords_list_view_controller_unittest.mm
[modify] https://crrev.com/dc6c2672edb3dd2d0dcd40e1de983e6ae9f4f426/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.h
[modify] https://crrev.com/dc6c2672edb3dd2d0dcd40e1de983e6ae9f4f426/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm
[modify] https://crrev.com/dc6c2672edb3dd2d0dcd40e1de983e6ae9f4f426/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm
[modify] https://crrev.com/dc6c2672edb3dd2d0dcd40e1de983e6ae9f4f426/chrome/browser/ui/cocoa/passwords/signin_promo_view_controller_unittest.mm