Save password dialog: focus username field when empty |
|
Issue descriptionChrome Version: 63.0.3239.0 OS: Windows, Mac, Linux When the username field is empty, we should default-focus it instead of the Save button to draw attention to the fact that it's empty. Link to design deck: https://goo.gl/kMG79w (Google internal link). Note: the focus ring is only shown when a user manually opens the dialog from the omnibox. The dialog doesn't get keyboard focus when the dialog is triggered automatically.
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92fe72eb70004bcd00ac5747268cb35024e4c4d9 commit 92fe72eb70004bcd00ac5747268cb35024e4c4d9 Author: Maxim Kolosovskiy <kolos@chromium.org> Date: Mon Oct 16 13:18:09 2017 [Password Manager] Username field should grab focus if the username value is empty Bug: 770051 , 774954 Change-Id: I3adbe71766f39aba45f359c5c966daf57f2a2acc Reviewed-on: https://chromium-review.googlesource.com/720928 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#509029} [modify] https://crrev.com/92fe72eb70004bcd00ac5747268cb35024e4c4d9/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc |
|
►
Sign in to add a comment |
|
Comment 1 by kolos@chromium.org
, Oct 16 2017Status: Duplicate (was: Untriaged)