New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774939 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Indication point about opened Folder is seen missing at shelf

Project Member Reported by mmanchala@chromium.org, Oct 16 2017

Issue description

Chrome Version: 64.0.3241.0/10038.0.0 dev-channel Kip,Reks and Peppy
OS: Chrome

What steps will reproduce the problem?ho
(1)Sign into User -> click on App Launcher -> Open Files App/ gallery /Browser 
(2)Now observe there is no indication point about opened Folder at shelf(Please refer Video Screenshot)

Expected: There should be indication point about opened Folder i.e. there should be Dot seen under opened folder at shelf
Actual: Instead there is no indication point about opened Folder is seen at shelf

This is Regression issue as same is working fine in 63.0.3236.0/10024.0.0 dev-channel Reks

@tdanderson : Please confirm the Issue 
 
Actual.webm
2.8 MB View Download
Actual.jpg
72.6 KB View Download
Expected.webm
1.3 MB View Download
Expected.jpg
108 KB View Download
Components: -UI>Shell>Launcher UI>Shell>Shelf
Owner: mmanchala@chromium.org
I am no longer actively working on the Chromium project.
Owner: tbuck...@chromium.org
@tbuckley : Please confirm the Issue 

Cc: tbuck...@chromium.org
Labels: Hotlist-Triaged
Owner: zork@chromium.org
I am able to repro on 64.0.3261.0 canary. It is important that the Files.app is not pinned in the launcher before you open it.

+zork can someone on your team look into this for M64?

Comment 5 by zork@chromium.org, Nov 20 2017

Cc: zork@chromium.org
Owner: x...@chromium.org
Daisy, could you have someone look into this?

Comment 6 by x...@chromium.org, Nov 21 2017

Cc: -krajshree@chromium.org x...@chromium.org
Owner: minch@chromium.org

Comment 7 by minch@chromium.org, Nov 22 2017

Can repro the  issue 64 .0.3241.0/10038.0.0 kevin. But what I can see is not only this. The launcher is even not complete in this case, there is only suggested apps in the launcher. And many other issues, like the system tray is not complete either.
Updated to 64.0.3274.0/10151.0.0 don't have this issue.

#4, I think the indication of files.app (or other app) is missing by following steps,
1. Open the launcher
2. Click Files to open (not pinned on the shelf)
3. No indication of the Files even though it is opened.
4. Move the cursor to hover above the Files.app on the shelf. The indicator will be shown.

Comment 8 by vadimt@chromium.org, Nov 27 2017

Labels: Not-Touch-Friendly-Launcher

Comment 9 by minch@chromium.org, Nov 28 2017

Cc: -x...@chromium.org minch@chromium.org
Owner: malaykeshav@chromium.org
Indicator is missing if follow the steps at #7

Works well before this cl https://chromium-review.googlesource.com/c/chromium/src/+/661778

can you help take a look?

Comment 10 by minch@chromium.org, Nov 28 2017

Cc: x...@chromium.org
Status: Started (was: Assigned)
This bug is being caused due to a race condition at
https://cs.chromium.org/chromium/src/cc/layers/picture_layer.cc?l=130
where the recording scale is not set before the display item list is updated. Thus the solid color analysis fails and marks the app indicator as a 'no paint' region.

Working on a fix with unit tests.
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57abc3e73cf8c9a0c9bc5f839d379cd41baacc7a

commit 57abc3e73cf8c9a0c9bc5f839d379cd41baacc7a
Author: F#m <malaykeshav@chromium.org>
Date: Thu Nov 30 01:49:35 2017

Fixes bug where recording scale factor was not set timely

This patch rearranges the statement to set the device scale factor for
recording source before the DisplayItemLists are updated and solid color
analysis is performed.

Adds unit test for this scenario.

Bug:  774939 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Iaa3c864f90636e042d26a89d443356cbd3dbd7ed
Component: Picture Layer, Recording source, solid color analysis
Reviewed-on: https://chromium-review.googlesource.com/795290
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520383}
[modify] https://crrev.com/57abc3e73cf8c9a0c9bc5f839d379cd41baacc7a/cc/benchmarks/rasterize_and_record_benchmark.cc
[modify] https://crrev.com/57abc3e73cf8c9a0c9bc5f839d379cd41baacc7a/cc/layers/picture_layer.cc
[modify] https://crrev.com/57abc3e73cf8c9a0c9bc5f839d379cd41baacc7a/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/57abc3e73cf8c9a0c9bc5f839d379cd41baacc7a/cc/layers/picture_layer_unittest.cc
[modify] https://crrev.com/57abc3e73cf8c9a0c9bc5f839d379cd41baacc7a/cc/layers/recording_source.cc
[modify] https://crrev.com/57abc3e73cf8c9a0c9bc5f839d379cd41baacc7a/cc/layers/recording_source.h
[modify] https://crrev.com/57abc3e73cf8c9a0c9bc5f839d379cd41baacc7a/cc/paint/oop_pixeltest.cc
[modify] https://crrev.com/57abc3e73cf8c9a0c9bc5f839d379cd41baacc7a/cc/test/fake_recording_source.h

Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-64; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-64 label, otherwise remove Merge-TBD label. Thanks.
Labels: Merge-Request-64
Project Member

Comment 17 by sheriffbot@chromium.org, Nov 30 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: We don't branch M64 until 2017-11-30.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-64 Merge-Approved-64
Approving merge to M64 Chrome OS.
Project Member

Comment 19 by sheriffbot@chromium.org, Dec 11 2017

Cc: kbleicher@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-64 Disable-Nags Merge-Merged
Status: Verified (was: Fixed)
10176.34.0, 64.0.3282.65
Project Member

Comment 22 by sheriffbot@chromium.org, Feb 19 2018

Labels: -Merge-TBD

Sign in to add a comment