Issue metadata
Sign in to add a comment
|
"JavaScript" not right-aligned in Page Info Bubble in RTL |
||||||||||||||||||||||||
Issue descriptionSee attached image from Chrome Stable in Hebrew.
,
Oct 17 2017
Tested the issue on Chrome Canary# 63.0.3239.0 on Pixel (Android 8.0.0 / OPR1 170623.027) and Pixel XL (Android 7.1.2 / N2G48E) and was able to reproduce the issue. Steps followed -- Pre-Condition -- Change Mobile language to Hebrew 1. Navigate to https://permission.site 2. Click on Location and allow permissions. 3. Click on security icon and observe "Location", not aligned properly. Expected Result: Location text should be properly aligned. Actual Result: Location text is not properly aligned. This is a Regression issue in M63 builds -- Chrome Good Build -- 63.0.3221.3. Chrome Bad Build -- 63.0.3222.0. You are looking for a change made after 503403(GOOD), but before 503404(BAD). Suspecting Commit# https://chromium.googlesource.com/chromium/src/+/e56bcfa1d3d852362be9041a16b7768bbb583e4e @dullweber -- Could you please look into the issue, kindly re-assign if it has nothing to do with your changes. Please find the logs and videos in the below URL -- go/chrome-androidlogs/774934 Thank You.
,
Oct 17 2017
I changed the "Location" string and it is not translated yet. It should be fixed as soon as a hebrew translation is available. The title and screenshot in the bug description mention "Javascript" not being aligned. This is a separate issue that is not related to my change. This probably needs to be bisected again.
,
Oct 18 2017
@timloh -- Could you please let us know in activating Javascript under https://permission.site so that it would help us in providing bisect. Thanks in Advance.
,
Oct 19 2017
Tim, please provide the info asked for. Thanks!
,
Oct 19 2017
You probably need to turn off JavaScript to get it to show up. I'd guess it's been like this since it was implemented.
,
Oct 20 2017
Does not repro on iOS.
,
Oct 30 2017
,
Oct 31 2017
We are able to repro this issue in chrome:55.0.2883.91 Device:Pixel/N2G48G Pre-Condition: Mobile language should be Hebrew Steps to Reproduce: 1.Launch Chrome 2.From Chrome menu go to site setting -> click on JavaScript and Turn off the toggle 3.Tap on Add Site Exception and Enter Text 'Permission.site' and click on add button 4.Open a new tab and Search www.permission.site 5.Tap on Security icon Observed behavior: JavaScript text is not properly aligned Expected behavior: JavaScript text should be properly aligned Frequency:100% @Image,logs:http://go/chrome-androidlogs1/7/774934
,
Oct 31 2017
,
Nov 10 2017
,
Nov 17 2017
WIP at https://chromium-review.googlesource.com/c/chromium/src/+/776333 with screenshot:
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eab030fe2143c852dbb77f68bbe03c454ae24a3c commit eab030fe2143c852dbb77f68bbe03c454ae24a3c Author: Patti <patricialor@chromium.org> Date: Mon Dec 04 03:41:52 2017 Page Info Android: Fix RTL positioning for untranslated permission names. Hebrew does not translate the string for 'Javascript'. This means any labels containing the English string will not have the RTL mark, and it will be displayed in LTR mode. Normally this would be OK, however, the permission labels in Page Info for Android have a width that matches the parent, so the label ends up aligning the text all the way on the left. Fix by changing the label width to wrap the content instead of matching its parent width. Note other strings are fine because they have Hebrew translations. Bug: 774934 Change-Id: I756c9e9584c8c89ab86462ba43aa8cefc10f024e Reviewed-on: https://chromium-review.googlesource.com/776333 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#521265} [modify] https://crrev.com/eab030fe2143c852dbb77f68bbe03c454ae24a3c/chrome/android/java/res/layout/page_info_permission_row.xml
,
Dec 4 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, Oct 16 2017