We currently have functions getComputedStyleMap and getInlineStyleMap, but they should now be methods on Element according to the spec. Spec: https://drafts.css-houdini.org/css-typed-om-1/#computed-stylepropertymapreadonly-objects
We need to move getComputedStyleMap to Element.computedStyleMap() and Element.styleMap to Element.attributeStyleMap. Spec: https://drafts.css-houdini.org/css-typed-om-1/#computed-stylepropertymapreadonly-objects
Adding to Hotlist-GoodFirstBug. This should be pretty easy - the typed cssom code isn't too hairy & extending Element is pretty straight-forward.
i will take this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e60ee2f3c487779720cc7cc703f3a293c7c68da commit 1e60ee2f3c487779720cc7cc703f3a293c7c68da Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Thu Nov 02 04:00:29 2017 [css-typed-om]StylePropertyMaps should be obtained via the Element replace Window.getComputedStyleMap() with element.computedStyleMap() https://github.com/w3c/css-houdini-drafts/pull/454 https://drafts.css-houdini.org/css-typed-om-1/#computed-stylepropertymapreadonly-objects Bug: 774933 Change-Id: Idd6438852671e6ac80d681a956f2c19bdab09a96 Reviewed-on: https://chromium-review.googlesource.com/746861 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by: Renée Wright <rjwright@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#513399} [modify] https://crrev.com/1e60ee2f3c487779720cc7cc703f3a293c7c68da/third_party/WebKit/LayoutTests/typedcssom/computedstyle/background-image.html [modify] https://crrev.com/1e60ee2f3c487779720cc7cc703f3a293c7c68da/third_party/WebKit/LayoutTests/typedcssom/computedstyle/border-top-width.html [modify] https://crrev.com/1e60ee2f3c487779720cc7cc703f3a293c7c68da/third_party/WebKit/LayoutTests/typedcssom/computedstyle/computedStylePropertyMap.html [modify] https://crrev.com/1e60ee2f3c487779720cc7cc703f3a293c7c68da/third_party/WebKit/LayoutTests/typedcssom/computedstyle/custom-properties.html [modify] https://crrev.com/1e60ee2f3c487779720cc7cc703f3a293c7c68da/third_party/WebKit/LayoutTests/typedcssom/computedstyle/left.html [modify] https://crrev.com/1e60ee2f3c487779720cc7cc703f3a293c7c68da/third_party/WebKit/LayoutTests/typedcssom/computedstyle/line-height.html [modify] https://crrev.com/1e60ee2f3c487779720cc7cc703f3a293c7c68da/third_party/WebKit/LayoutTests/typedcssom/computedstyle/numbers.html [delete] https://crrev.com/48300395311db1aa2677e91c4eaeed51f20d7e59/third_party/WebKit/LayoutTests/typedcssom/computedstyle/pseudo-elements.html [modify] https://crrev.com/1e60ee2f3c487779720cc7cc703f3a293c7c68da/third_party/WebKit/LayoutTests/typedcssom/computedstyle/width.html [modify] https://crrev.com/1e60ee2f3c487779720cc7cc703f3a293c7c68da/third_party/WebKit/LayoutTests/typedcssom/cssURLImageValue.html [modify] https://crrev.com/1e60ee2f3c487779720cc7cc703f3a293c7c68da/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed.html [modify] https://crrev.com/1e60ee2f3c487779720cc7cc703f3a293c7c68da/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt [modify] https://crrev.com/1e60ee2f3c487779720cc7cc703f3a293c7c68da/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/1e60ee2f3c487779720cc7cc703f3a293c7c68da/third_party/WebKit/Source/core/core_idl_files.gni [modify] https://crrev.com/1e60ee2f3c487779720cc7cc703f3a293c7c68da/third_party/WebKit/Source/core/css/BUILD.gn [modify] https://crrev.com/1e60ee2f3c487779720cc7cc703f3a293c7c68da/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h [add] https://crrev.com/1e60ee2f3c487779720cc7cc703f3a293c7c68da/third_party/WebKit/Source/core/css/cssom/ElementComputedStyleMap.h [add] https://crrev.com/1e60ee2f3c487779720cc7cc703f3a293c7c68da/third_party/WebKit/Source/core/css/cssom/ElementComputedStyleMap.idl [delete] https://crrev.com/48300395311db1aa2677e91c4eaeed51f20d7e59/third_party/WebKit/Source/core/css/cssom/WindowGetComputedStyle.h [delete] https://crrev.com/48300395311db1aa2677e91c4eaeed51f20d7e59/third_party/WebKit/Source/core/css/cssom/WindowGetComputedStyle.idl
Just realised the description was wrong. Fixed now.
Hi hs1217, are you continuing with this work? I think all that's left is renaming Element.styleMap to Element.attributeStyleMap.
@shend i will do that.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3 commit 6c564a2f8e9fcb55e58e30adf8d61dbe172742a3 Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Mon Nov 13 07:11:09 2017 [css-typed-om] Replace Element.styleMap with Element.attributeStyleMap Replace Element.styleMap with Element.attributeStyleMap. Element.sytleMap is still behind runtime feature of CSSTypedOM. so it does not need to notify at blink-dev groups. https://drafts.css-houdini.org/css-typed-om-1/#inline-stylepropertymap Bug: 774933 Change-Id: I25c3dd401702505981b77fe38aa4798ea8ea9bd6 Reviewed-on: https://chromium-review.googlesource.com/765553 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by: Darren Shen <shend@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#515894} [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/declared-styleMap-accepts-inherit.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/styleMap-update-function-expected.txt [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/styleMap-update-function.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/cssURLImageValue.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_append.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_delete.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_getAll.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_getProperties.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_iteration.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_iterationWithModification.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_setGet.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/numbers.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/background-image.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/property-suite.js [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/transform.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform-perspective.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/unparsedValue.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/unsupported-properties.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/stylevalue-serialization/cssKeywordValue.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/stylevalue-serialization/cssPositionValue.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/stylevalue-serialization/cssUnitValue.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssUrlImageValue.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/get.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/getAll.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/getProperties.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/has.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/iterable.html [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/Source/core/dom/Element.cpp [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/Source/core/dom/Element.h [modify] https://crrev.com/6c564a2f8e9fcb55e58e30adf8d61dbe172742a3/third_party/WebKit/Source/core/dom/Element.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fd7240748f1ce00560946618f2bd0e9636d414 commit c9fd7240748f1ce00560946618f2bd0e9636d414 Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Mon Nov 13 22:19:10 2017 [css-typed-om] Fix the normalize-ident.html LayoutTest failure fix the normalize-ident.html LayoutTest failure. normalize-ident.html seems like to merge between my patch which is replaced with Element.attributeSytleMap pass CQ dry run and merge. Bug: 784278 , 774933 Change-Id: I779b6177399c3e10b6323b6ed891d81e523cfcfe Reviewed-on: https://chromium-review.googlesource.com/765753 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#516079} [modify] https://crrev.com/c9fd7240748f1ce00560946618f2bd0e9636d414/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/c9fd7240748f1ce00560946618f2bd0e9636d414/third_party/WebKit/LayoutTests/typedcssom/stylevalue-normalization/normalize-ident.html
Comment 1 by rjwright@chromium.org
, Oct 31 2017