desktop-pwas: Refactor to properly distinguish Bookmark apps from PWAs |
|||||
Issue descriptionThere are instances in which Bookmark Apps for PWAs will behave differently to Bookmark Apps for non-PWAs. For example, when navigating to websites with a different origin, non-PWA Bookmark Apps will just navigate and show the address bar; PWA Bookmark Apps will open the target website in a new tab in a regular browser window. Checking if the Bookmark App has a scope is enough for now but we might want to introduce something more explicit. Alternatives include: 1. A pref that indicates the Bookmark App is for a PWA 2. A field in the Bookmark App manifest that indicates it's for a PWA 3. A new type of manifest for PWA Bookmark Apps Ideally, whatever name or mechanism we use should avoid mentioning the term PWA since it's mostly a marketing name. "Web App Wrapper", "Bookmark App V2", "Legacy Bookmark App" (for non PWAs) and "Installable Website" are some names that have been thrown around.
,
Mar 26 2018
,
Mar 27 2018
This is an internal refactor (not user-facing).
,
Sep 6
,
Sep 6
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87df387391a042bf0d2d10c23948ab0cd4c519f4 commit 87df387391a042bf0d2d10c23948ab0cd4c519f4 Author: Alexey Baskakov <loyso@chromium.org> Date: Tue Sep 11 04:52:00 2018 HostedApp: Encapsulate Extensions in HostedAppBrowserController. This is a cleanup code-health change. Bug: 774918 Change-Id: I9b73ad49874fa48210aba031d646173f1544678d Reviewed-on: https://chromium-review.googlesource.com/1209133 Reviewed-by: Alan Cutter <alancutter@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#590203} [modify] https://crrev.com/87df387391a042bf0d2d10c23948ab0cd4c519f4/chrome/browser/ui/extensions/hosted_app_browser_controller.cc [modify] https://crrev.com/87df387391a042bf0d2d10c23948ab0cd4c519f4/chrome/browser/ui/extensions/hosted_app_browser_controller.h [modify] https://crrev.com/87df387391a042bf0d2d10c23948ab0cd4c519f4/chrome/browser/ui/extensions/hosted_app_browsertest.cc [modify] https://crrev.com/87df387391a042bf0d2d10c23948ab0cd4c519f4/chrome/browser/ui/extensions/hosted_app_menu_model.cc
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2117478be806acda4d07d3ae7cd8e68dc9a04ce4 commit 2117478be806acda4d07d3ae7cd8e68dc9a04ce4 Author: Alexey Baskakov <loyso@chromium.org> Date: Wed Sep 19 02:46:39 2018 HostedApp: Encapsulate the Extension object in extensions::TabHelper. Extensions shouldn't leak into chrome/browser/ui/ code. Use TabHelper::GetAppId instead of Extension* Since we are going to use std::string for AppId, this change will allow us to use an abstract apps::App and move off the Extensions System in the future. Drive By: Erase unused TabHelper::web_app_info(). Bug: 774918 Change-Id: I3596bb80729c53f53215325abd371dda8a06a50a Reviewed-on: https://chromium-review.googlesource.com/1229719 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#592308} [modify] https://crrev.com/2117478be806acda4d07d3ae7cd8e68dc9a04ce4/chrome/browser/extensions/tab_helper.cc [modify] https://crrev.com/2117478be806acda4d07d3ae7cd8e68dc9a04ce4/chrome/browser/extensions/tab_helper.h [modify] https://crrev.com/2117478be806acda4d07d3ae7cd8e68dc9a04ce4/chrome/browser/extensions/tab_helper_unittest.cc [modify] https://crrev.com/2117478be806acda4d07d3ae7cd8e68dc9a04ce4/chrome/browser/sessions/chrome_tab_restore_service_client.cc [modify] https://crrev.com/2117478be806acda4d07d3ae7cd8e68dc9a04ce4/chrome/browser/sessions/session_service.cc [modify] https://crrev.com/2117478be806acda4d07d3ae7cd8e68dc9a04ce4/chrome/browser/ui/browser.cc [modify] https://crrev.com/2117478be806acda4d07d3ae7cd8e68dc9a04ce4/chrome/browser/ui/browser_browsertest.cc [modify] https://crrev.com/2117478be806acda4d07d3ae7cd8e68dc9a04ce4/chrome/browser/ui/browser_navigator.cc [modify] https://crrev.com/2117478be806acda4d07d3ae7cd8e68dc9a04ce4/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da858d822e0245e4bbfaad4486600398a2bf7a59 commit da858d822e0245e4bbfaad4486600398a2bf7a59 Author: Alexey Baskakov <loyso@chromium.org> Date: Wed Sep 19 03:41:22 2018 Extension App Launch: Extract UMA code into platform_apps. Extensions shouldn't leak into chrome/browser/sessions/ code. No behavior changes. Bug: 774918 Change-Id: I5c35749362914bdb3ea46c160abcd4ab36a74957 Reviewed-on: https://chromium-review.googlesource.com/1229722 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#592315} [modify] https://crrev.com/da858d822e0245e4bbfaad4486600398a2bf7a59/chrome/browser/apps/platform_apps/platform_app_launch.cc [modify] https://crrev.com/da858d822e0245e4bbfaad4486600398a2bf7a59/chrome/browser/apps/platform_apps/platform_app_launch.h [modify] https://crrev.com/da858d822e0245e4bbfaad4486600398a2bf7a59/chrome/browser/sessions/chrome_tab_restore_service_client.cc
,
Dec 17
This is now more about distinguishing: "The Install-button" (PWA) vs "Create Shortcut button" user-installed. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ortuno@chromium.org
, Oct 16 2017