Add layout tests to cover the current draft spec: https://drafts.css-houdini.org/css-typed-om-1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d34a16ea2c388c29befa152ab2bcaaf40e0a0409 commit d34a16ea2c388c29befa152ab2bcaaf40e0a0409 Author: Darren Shen <shend@chromium.org> Date: Wed Oct 18 02:22:38 2017 [css-typed-om] Add tests for CSSStyleValue.parse and parseAll. We add layout tests for CSSStyleValue.parse and parseAll [1]. These two methods are very similar so we test them in the same file to avoid code duplication. This will be first of many patches to add tests for CSS Typed OM. We follow WPT guidelines for these tests, with the intent that these tests will eventually be incorporated into WPT. Of note: - We organise the directory structure based on the heading structure of the spec. - We include metadata containing links to sections of the spec. - We use modern javascript features like 'const' and 'let'. As recommended by [2], we will land these tests in Chromium first. Once the spec has stabilised enough, we will upstream them to WPT. [1] https://drafts.css-houdini.org/css-typed-om-1/#dom-cssstylevalue-parse [2] https://chromium.googlesource.com/chromium/src/+/lkcr/docs/testing/web_platform_tests.md#write-tests-against-specifications Currently failing: - parseAll is not implemented. - parsing a custom property doesn't seem to be implemented. - parsing list value properties doesn't seem to work. - parsing an invalid cssText should throw. Bug: 774887 Change-Id: If7fd3ed222dd6371a8a6077777742860a81ff4dc Reviewed-on: https://chromium-review.googlesource.com/720577 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#509657} [add] https://crrev.com/d34a16ea2c388c29befa152ab2bcaaf40e0a0409/third_party/WebKit/LayoutTests/typedcssom/resources/testhelper.js [delete] https://crrev.com/6893e151e592a51ca46f6deb2747b7f1e7787b89/third_party/WebKit/LayoutTests/typedcssom/styleValue-parse-basic.html [add] https://crrev.com/d34a16ea2c388c29befa152ab2bcaaf40e0a0409/third_party/WebKit/LayoutTests/typedcssom/stylevalue-objects/parse-parseAll-expected.txt [add] https://crrev.com/d34a16ea2c388c29befa152ab2bcaaf40e0a0409/third_party/WebKit/LayoutTests/typedcssom/stylevalue-objects/parse-parseAll.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f372e37d40c013c5ca02035669e0e828f6d46a54 commit f372e37d40c013c5ca02035669e0e828f6d46a54 Author: Darren Shen <shend@chromium.org> Date: Wed Oct 18 07:26:24 2017 [css-typed-om] Add tests for CSSKeywordValue constructor Spec: https://drafts.css-houdini.org/css-typed-om-1/#keywordvalue-objects There are no failing tests. Bug: 774887 Change-Id: If78a3e490c406e8743eb591f1e9bdcb28f9fb3a5 Reviewed-on: https://chromium-review.googlesource.com/720582 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#509711} [modify] https://crrev.com/f372e37d40c013c5ca02035669e0e828f6d46a54/third_party/WebKit/LayoutTests/typedcssom/cssKeywordValue.html [add] https://crrev.com/f372e37d40c013c5ca02035669e0e828f6d46a54/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/keywordvalue-objects/constructor.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35d697ee2286c3856fd5c9f09d01a4e182102fb5 commit 35d697ee2286c3856fd5c9f09d01a4e182102fb5 Author: Darren Shen <shend@chromium.org> Date: Fri Oct 20 04:48:24 2017 [css-typed-om] Add tests for CSSKeywordValue attributes Spec: https://drafts.css-houdini.org/css-typed-om-1/#keywordvalue-objects Previously we were thinking of having a folder for CSSKeywordValue, but that turns out to be too fine-grained. So this patch just has one file for CSSKeywordValue tests for simplicity. Currently failing: - Setting the 'value' attribute to empty string should throw. Bug: 774887 Change-Id: Ic79c4d2947345d808a403b8d3eaa7724ff3f7a1f Reviewed-on: https://chromium-review.googlesource.com/725003 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#510338} [modify] https://crrev.com/35d697ee2286c3856fd5c9f09d01a4e182102fb5/third_party/WebKit/LayoutTests/typedcssom/cssKeywordValue.html [add] https://crrev.com/35d697ee2286c3856fd5c9f09d01a4e182102fb5/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssKeywordValue-expected.txt [rename] https://crrev.com/35d697ee2286c3856fd5c9f09d01a4e182102fb5/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssKeywordValue.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/254a1bbb28a47fc41f57a412eb601bc97fa52882 commit 254a1bbb28a47fc41f57a412eb601bc97fa52882 Author: Darren Shen <shend@chromium.org> Date: Fri Oct 20 06:35:08 2017 [css-typed-om] Update CSSSkew tests to follow WPT standards. This patch: - Moves CSSSkew tests to a subfolder containing all the other CSSStylevalue subclasses. - Adds the appropriate meta and link tags. - Clean up the test code a bit. Note: Following the WPT guidelines, our test structure closely follows the spec structure. Therefore, serialization and normalization of skew values will be done in a separate file as it is a separate section in the spec. Spec: https://drafts.css-houdini.org/css-typed-om-1/#cssskew WPT Guidelines: http://web-platform-tests.org/writing-tests/general-guidelines.html Currently failing: - Constructing with non-angles should throw. Bug: 774887 Change-Id: I4e3df878ac493da78ad88ee21b5a4bf276ec00f0 Reviewed-on: https://chromium-review.googlesource.com/724922 Reviewed-by: meade_UTC10 <meade@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#510360} [modify] https://crrev.com/254a1bbb28a47fc41f57a412eb601bc97fa52882/third_party/WebKit/LayoutTests/typedcssom/cssSkew.html [add] https://crrev.com/254a1bbb28a47fc41f57a412eb601bc97fa52882/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssSkew-expected.txt [add] https://crrev.com/254a1bbb28a47fc41f57a412eb601bc97fa52882/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssSkew.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/954f354eeb5ac891ba626fb42bd5ba5b4e2fe26b commit 954f354eeb5ac891ba626fb42bd5ba5b4e2fe26b Author: Darren Shen <shend@chromium.org> Date: Fri Oct 20 23:50:22 2017 [css-typed-om] Update CSSPerspective tests to follow WPT standards. This patch: - Moves CSSPerspective tests to a subfolder containing all the other CSSStylevalue subclasses. - Adds the appropriate meta and link tags. - Clean up the test code a bit. Note: Following the WPT guidelines, our test structure closely follows the spec structure. Therefore, serialization and normalization of perspective values will be done in a separate file as it is a separate section in the spec. Spec: https://drafts.css-houdini.org/css-typed-om-1/#cssperspective WPT Guidelines: http://web-platform-tests.org/writing-tests/general-guidelines.html None of the tests are failing. Bug: 774887 Change-Id: I390405e9e6953cbc2e010ab51fa722af7b8eebc3 Reviewed-on: https://chromium-review.googlesource.com/725119 Reviewed-by: meade_UTC10 <meade@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#510616} [modify] https://crrev.com/954f354eeb5ac891ba626fb42bd5ba5b4e2fe26b/third_party/WebKit/LayoutTests/typedcssom/cssPerspective.html [add] https://crrev.com/954f354eeb5ac891ba626fb42bd5ba5b4e2fe26b/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssPerspective.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd7d43a97a054c09d4bf65aeead4e166cc483562 commit cd7d43a97a054c09d4bf65aeead4e166cc483562 Author: Darren Shen <shend@chromium.org> Date: Tue Oct 24 06:03:37 2017 [css-typed-om] Update CSSPositionValue tests to follow WPT standards. This patch: - Moves CSSPositionValue tests to a subfolder containing all the other CSSStylevalue subclasses. - Adds the appropriate meta and link tags. - Clean up the test code a bit. Note: Following the WPT guidelines, our test structure closely follows the spec structure. Therefore, serialization and normalization of position values will be done in a separate file as it is a separate section in the spec. Spec: https://drafts.css-houdini.org/css-typed-om-1/#positionvalue-objects WPT Guidelines: http://web-platform-tests.org/writing-tests/general-guidelines.html All tests pass. Bug: 774887 Change-Id: Ia19b7b93ddbd4aa12df9038b863a4c0a78a83ad4 Reviewed-on: https://chromium-review.googlesource.com/732002 Reviewed-by: Renée Wright <rjwright@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#511045} [modify] https://crrev.com/cd7d43a97a054c09d4bf65aeead4e166cc483562/third_party/WebKit/LayoutTests/typedcssom/cssPositionValue.html [add] https://crrev.com/cd7d43a97a054c09d4bf65aeead4e166cc483562/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssPositionValue.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdec7fc1c5d24dc1ab2c8805916686cf8f2ce341 commit cdec7fc1c5d24dc1ab2c8805916686cf8f2ce341 Author: Darren Shen <shend@chromium.org> Date: Tue Oct 31 05:59:04 2017 [css-typed-om] Add tests for the readonly part of StylePropertyMap. Spec: https://drafts.css-houdini.org/css-typed-om-1/#stylepropertymapreadonly We test get, getAll, has, iterable and getProperties through the inline StylePropertyMap. Currently failing: - Custom properties seem to be returned as CSSStyleValues and not CSSUnparsedValues - properties are not sorted correctly in iteration and getProperties. Bug: 774887 Change-Id: I613329005030355e137d19063c5ad7e6247156ed Reviewed-on: https://chromium-review.googlesource.com/722400 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#512757} [modify] https://crrev.com/cdec7fc1c5d24dc1ab2c8805916686cf8f2ce341/third_party/WebKit/LayoutTests/typedcssom/resources/testhelper.js [add] https://crrev.com/cdec7fc1c5d24dc1ab2c8805916686cf8f2ce341/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/get-expected.txt [add] https://crrev.com/cdec7fc1c5d24dc1ab2c8805916686cf8f2ce341/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/get.html [add] https://crrev.com/cdec7fc1c5d24dc1ab2c8805916686cf8f2ce341/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/getAll-expected.txt [add] https://crrev.com/cdec7fc1c5d24dc1ab2c8805916686cf8f2ce341/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/getAll.html [add] https://crrev.com/cdec7fc1c5d24dc1ab2c8805916686cf8f2ce341/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/getProperties-expected.txt [add] https://crrev.com/cdec7fc1c5d24dc1ab2c8805916686cf8f2ce341/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/getProperties.html [add] https://crrev.com/cdec7fc1c5d24dc1ab2c8805916686cf8f2ce341/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/has.html [add] https://crrev.com/cdec7fc1c5d24dc1ab2c8805916686cf8f2ce341/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/iterable-expected.txt [add] https://crrev.com/cdec7fc1c5d24dc1ab2c8805916686cf8f2ce341/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/iterable.html [modify] https://crrev.com/cdec7fc1c5d24dc1ab2c8805916686cf8f2ce341/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dac3aef518e053bd9ec8721f0003e5bf5b2d7f64 commit dac3aef518e053bd9ec8721f0003e5bf5b2d7f64 Author: Darren Shen <shend@chromium.org> Date: Tue Oct 31 22:04:54 2017 [css-typed-om] Add tests for the computed StylePropertyMap Spec: https://drafts.css-houdini.org/css-typed-om-1/#computed-stylepropertymapreadonly-objects Currently failing: - Custom properties seem to be returned as CSSStyleValues and not CSSUnparsedValues Bug: 774887 Change-Id: I20a900a0d07a7c4bcce2ed02aa0e8612ebbb804e Reviewed-on: https://chromium-review.googlesource.com/737497 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#512972} [modify] https://crrev.com/dac3aef518e053bd9ec8721f0003e5bf5b2d7f64/third_party/WebKit/LayoutTests/typedcssom/resources/testhelper.js [add] https://crrev.com/dac3aef518e053bd9ec8721f0003e5bf5b2d7f64/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed-expected.txt [add] https://crrev.com/dac3aef518e053bd9ec8721f0003e5bf5b2d7f64/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4274499a4b2cf96607a3a3556ad321e76d71e4a8 commit 4274499a4b2cf96607a3a3556ad321e76d71e4a8 Author: Darren Shen <shend@chromium.org> Date: Wed Nov 08 05:46:15 2017 [css-typed-om] Add CSSMathValue test cases to CSSStyleValue tests. We recently added the IDL for CSSMathValue subclasses, so now they can be used in layout tests. We change some of the existing CSSStyleValue tests to cover inputs for CSSMathValues. Specs: https://drafts.css-houdini.org/css-typed-om-1/#dom-cssperspective-cssperspective https://drafts.css-houdini.org/css-typed-om-1/#dom-csspositionvalue-csspositionvalue https://drafts.css-houdini.org/css-typed-om-1/#dom-cssskew-cssskew Bug: 774887 Change-Id: I640d272b1019c7acdfc986264b477dce52ae8cf9 Reviewed-on: https://chromium-review.googlesource.com/756177 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#514765} [add] https://crrev.com/4274499a4b2cf96607a3a3556ad321e76d71e4a8/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssPerspective-expected.txt [modify] https://crrev.com/4274499a4b2cf96607a3a3556ad321e76d71e4a8/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssPerspective.html [add] https://crrev.com/4274499a4b2cf96607a3a3556ad321e76d71e4a8/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssPositionValue-expected.txt [modify] https://crrev.com/4274499a4b2cf96607a3a3556ad321e76d71e4a8/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssPositionValue.html [add] https://crrev.com/4274499a4b2cf96607a3a3556ad321e76d71e4a8/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssSkew-expected.txt [modify] https://crrev.com/4274499a4b2cf96607a3a3556ad321e76d71e4a8/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssSkew.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8164bd88c5b63323641a50d54a9bc15aa3584e25 commit 8164bd88c5b63323641a50d54a9bc15aa3584e25 Author: Darren Shen <shend@chromium.org> Date: Thu Nov 09 11:12:30 2017 [css-typed-om] Add tests for CSSUnitValue. This patch adds validation (constructor/setters) tests for CSSUnitValue. We also fixed a missing return statement that caused the code to crash. Spec: https://drafts.css-houdini.org/css-typed-om-1/#simple-numeric Bug: 774887 Change-Id: I11077de36e6b07570e54d578c84a7370b9de8aa6 Reviewed-on: https://chromium-review.googlesource.com/759153 Reviewed-by: Renée Wright <rjwright@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#515137} [modify] https://crrev.com/8164bd88c5b63323641a50d54a9bc15aa3584e25/third_party/WebKit/LayoutTests/typedcssom/resources/testhelper.js [add] https://crrev.com/8164bd88c5b63323641a50d54a9bc15aa3584e25/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/numeric-objects/cssUnitValue-expected.txt [add] https://crrev.com/8164bd88c5b63323641a50d54a9bc15aa3584e25/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/numeric-objects/cssUnitValue.html [modify] https://crrev.com/8164bd88c5b63323641a50d54a9bc15aa3584e25/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/numeric-objects/numeric-factory.html [modify] https://crrev.com/8164bd88c5b63323641a50d54a9bc15aa3584e25/third_party/WebKit/Source/core/css/cssom/CSSUnitValue.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad3d6e670111d442c19858724ee218097fbc8004 commit ad3d6e670111d442c19858724ee218097fbc8004 Author: Darren Shen <shend@chromium.org> Date: Fri Nov 10 01:53:22 2017 [css-typed-om] Update CSSURLImageValue tests to follow WPT standards. This patch: - Moves CSSURLImageValue tests to a subfolder containing all the other CSSStylevalue subclasses. - Adds the appropriate meta and link tags. - Clean up the test code a bit. - Remove redundant unit tests Note: Following the WPT guidelines, our test structure closely follows the spec structure. Therefore, serialization and normalization of URL image values will be done in a separate file as it is a separate section in the spec. Spec: https://drafts.css-houdini.org/css-typed-om-1/#imagevalue-objects WPT Guidelines: http://web-platform-tests.org/writing-tests/general-guidelines.html There's one failing test where we are not throwing an error when the URL is invalid. Also, we should be resetting attributes back to null if there was an error loading the resource. Bug: 774887 Change-Id: Ieb1df73e538d6343fc8e8d05569981349aa90118 Reviewed-on: https://chromium-review.googlesource.com/759704 Reviewed-by: meade_UTC10 <meade@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#515413} [modify] https://crrev.com/ad3d6e670111d442c19858724ee218097fbc8004/third_party/WebKit/LayoutTests/typedcssom/cssURLImageValue.html [add] https://crrev.com/ad3d6e670111d442c19858724ee218097fbc8004/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssUrlImageValue-expected.txt [add] https://crrev.com/ad3d6e670111d442c19858724ee218097fbc8004/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssUrlImageValue.html [modify] https://crrev.com/ad3d6e670111d442c19858724ee218097fbc8004/third_party/WebKit/Source/core/BUILD.gn [modify] https://crrev.com/ad3d6e670111d442c19858724ee218097fbc8004/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp [modify] https://crrev.com/ad3d6e670111d442c19858724ee218097fbc8004/third_party/WebKit/Source/core/css/cssom/CSSURLImageValue.h [delete] https://crrev.com/f55d9b83921d2d82ac9e79d963cc283a51a53208/third_party/WebKit/Source/core/css/cssom/CSSURLImageValueTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb0e4d778c32f40aaee2d29c9ca9b4223ed0d552 commit bb0e4d778c32f40aaee2d29c9ca9b4223ed0d552 Author: Darren Shen <shend@chromium.org> Date: Fri Nov 10 03:18:17 2017 [css-typed-om] Add tests for serialization from IDL constructed values. This patch adds some tests for serialization of style values constructed from the IDL. Tests for the following classes were added: - CSSKeywordValue - CSSUnitValue - CSSPositionValue There's currently three types of serialization [1]. We are testing the second case ("the value was constructed using an IDL constructor"). Along with testing the IDL constructor, we also test what happens when we obtain a CSSStyleValue from a DOMString or CSSOM (case 1 and 3) and modify it using IDL setters. Currently our code will trivially pass this test, but it'll be harder when we implement all three serialization types, as the style value needs to remember whether which case it belongs to. There's a failing test due to the fact that we haven't implemented normalization of <position> values. Bug: 782103 , 774887 Change-Id: I4a379dcb51ea718642e6889f9c0b63bf0bc7d60c Reviewed-on: https://chromium-review.googlesource.com/759407 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#515438} [delete] https://crrev.com/f15ede50a29d9d4bf0d3aeb2ddc67188a0188b83/third_party/WebKit/LayoutTests/typedcssom/cssKeywordValue.html [modify] https://crrev.com/bb0e4d778c32f40aaee2d29c9ca9b4223ed0d552/third_party/WebKit/LayoutTests/typedcssom/cssUnitValue.html [add] https://crrev.com/bb0e4d778c32f40aaee2d29c9ca9b4223ed0d552/third_party/WebKit/LayoutTests/typedcssom/stylevalue-serialization/cssKeywordValue.html [add] https://crrev.com/bb0e4d778c32f40aaee2d29c9ca9b4223ed0d552/third_party/WebKit/LayoutTests/typedcssom/stylevalue-serialization/cssPositionValue-expected.txt [add] https://crrev.com/bb0e4d778c32f40aaee2d29c9ca9b4223ed0d552/third_party/WebKit/LayoutTests/typedcssom/stylevalue-serialization/cssPositionValue.html [add] https://crrev.com/bb0e4d778c32f40aaee2d29c9ca9b4223ed0d552/third_party/WebKit/LayoutTests/typedcssom/stylevalue-serialization/cssUnitValue.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ad0d23830e07abc17bd12058d7307e98e9fadd7 commit 6ad0d23830e07abc17bd12058d7307e98e9fadd7 Author: Darren Shen <shend@chromium.org> Date: Mon Nov 13 06:11:01 2017 [css-typed-om] Add test for identifier normalization. We add a test for identifier normalization that covers [1]. Note that we're only testing that an <identifier> normalizes to a CSSKeywordValue (hence the simple test). Testing of which properties normalizes to CSSKeywordValue will be done in a separate test, as it is in a separate part of the spec [2]. [1] https://drafts.css-houdini.org/css-typed-om-1/#normalize-ident [2] https://drafts.css-houdini.org/css-typed-om-1/#stylevalue-normalization Bug: 774887 Change-Id: Idc2c0bb1279389e1e7fd46373bea13ac9b5dd105 Reviewed-on: https://chromium-review.googlesource.com/765550 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#515889} [add] https://crrev.com/6ad0d23830e07abc17bd12058d7307e98e9fadd7/third_party/WebKit/LayoutTests/typedcssom/stylevalue-normalization/normalize-ident.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f55c8b5d5fda3f2f50bbe42cd881bcc7b0f9c1f1 commit f55c8b5d5fda3f2f50bbe42cd881bcc7b0f9c1f1 Author: Darren Shen <shend@chromium.org> Date: Mon Nov 13 06:12:48 2017 [css-typed-om] Update CSSTranslation tests to follow WPT standards. This patch: - Moves CSSTranslation tests to a subfolder containing all the other CSSStylevalue subclasses. - Adds the appropriate meta and link tags. - Clean up the test code a bit. Notably, the spec changed so that Z can be a percentage. Note: Following the WPT guidelines, our test structure closely follows the spec structure. Therefore, serialization and normalization of CSSTranslation will be done in a separate file as it is a separate section in the spec. Spec: https://drafts.css-houdini.org/css-typed-om-1/#csstranslation WPT Guidelines: http://web-platform-tests.org/writing-tests/general-guidelines.html There are failing tests where we are passing in a CSSMathValue/calc value. We currently don't support CSSMathValues as arguments. Bug: 774887 Change-Id: I571d6dd529a60381c310df74fddead39c61e2cd9 Reviewed-on: https://chromium-review.googlesource.com/765552 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#515891} [modify] https://crrev.com/f55c8b5d5fda3f2f50bbe42cd881bcc7b0f9c1f1/third_party/WebKit/LayoutTests/typedcssom/cssTranslation.html [add] https://crrev.com/f55c8b5d5fda3f2f50bbe42cd881bcc7b0f9c1f1/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssTranslation-expected.txt [add] https://crrev.com/f55c8b5d5fda3f2f50bbe42cd881bcc7b0f9c1f1/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssTranslation.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9888777317b487dda50529cc8921eb2c9014df56 commit 9888777317b487dda50529cc8921eb2c9014df56 Author: Darren Shen <shend@chromium.org> Date: Thu Nov 16 01:42:12 2017 [css-typed-om] Update tests for CSSUnparsedValue. Before, CSSUnparsedValue did not have a constructor, so we couldn't test it using a layout test. This patch updates the CSSUnparsedValue IDL and code to the updated spec where CSSUnparsedValue hsa a constructor. We can now layout test CSSUnparsedValue (with some hack to create CSSVariableReferenceValues). This also makes the existing unit tests redundant so we delete those. Spec: https://drafts.css-houdini.org/css-typed-om-1/#unparsedvalue-objects Bug: 774887 Change-Id: I1ffce7af7eb0494b388a1843097d922b8753195b Reviewed-on: https://chromium-review.googlesource.com/759618 Reviewed-by: meade_UTC10 <meade@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#516946} [modify] https://crrev.com/9888777317b487dda50529cc8921eb2c9014df56/third_party/WebKit/LayoutTests/typedcssom/resources/testhelper.js [add] https://crrev.com/9888777317b487dda50529cc8921eb2c9014df56/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssUnparsedValue.html [modify] https://crrev.com/9888777317b487dda50529cc8921eb2c9014df56/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed-expected.txt [modify] https://crrev.com/9888777317b487dda50529cc8921eb2c9014df56/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/get-expected.txt [modify] https://crrev.com/9888777317b487dda50529cc8921eb2c9014df56/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/getAll-expected.txt [modify] https://crrev.com/9888777317b487dda50529cc8921eb2c9014df56/third_party/WebKit/Source/core/BUILD.gn [modify] https://crrev.com/9888777317b487dda50529cc8921eb2c9014df56/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.cpp [modify] https://crrev.com/9888777317b487dda50529cc8921eb2c9014df56/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.h [modify] https://crrev.com/9888777317b487dda50529cc8921eb2c9014df56/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.idl [delete] https://crrev.com/2a737de10c1b397664f0bd01a68764b9f1114d69/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValueTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfc102ecb13e25634a92e2dd7d38646276acab3b commit dfc102ecb13e25634a92e2dd7d38646276acab3b Author: Darren Shen <shend@chromium.org> Date: Thu Nov 16 01:53:07 2017 [css-typed-om] Update CSSScale tests to follow WPT standards. This patch: - Moves CSSScale tests to a subfolder containing all the other CSSStylevalue subclasses. - Adds the appropriate meta and link tags. - Clean up the test code a bit. Note: Following the WPT guidelines, our test structure closely follows the spec structure. Therefore, serialization and normalization of scale values will be done in a separate file as it is a separate section in the spec. Spec: https://drafts.css-houdini.org/css-typed-om-1/#dom-cssscale-cssscale WPT Guidelines: http://web-platform-tests.org/writing-tests/general-guidelines.html Tests are currently failing because: 1) CSSScale should take numberishes 2) CSSScale should also take CSSMathValues Bug: 774887 Change-Id: If10a27220d2d7b9e6066950513af958cf2c5cd62 Reviewed-on: https://chromium-review.googlesource.com/768190 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#516948} [modify] https://crrev.com/dfc102ecb13e25634a92e2dd7d38646276acab3b/third_party/WebKit/LayoutTests/typedcssom/cssScale.html [add] https://crrev.com/dfc102ecb13e25634a92e2dd7d38646276acab3b/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssScale-expected.txt [add] https://crrev.com/dfc102ecb13e25634a92e2dd7d38646276acab3b/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssScale.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c349014fc3d1bda22bbc2f299b91ea9c4ac3d52 commit 4c349014fc3d1bda22bbc2f299b91ea9c4ac3d52 Author: Darren Shen <shend@chromium.org> Date: Thu Nov 16 08:15:38 2017 [css-typed-om] Update CSSRotation tests to follow WPT standards. This patch: - Moves CSSRotation tests to a subfolder containing all the other CSSStylevalue subclasses. - Adds the appropriate meta and link tags. - Clean up the test code a bit. Note: Following the WPT guidelines, our test structure closely follows the spec structure. Therefore, serialization and normalization of rotation values will be done in a separate file as it is a separate section in the spec. Spec: https://drafts.css-houdini.org/css-typed-om-1/#cssrotation WPT Guidelines: http://web-platform-tests.org/writing-tests/general-guidelines.html Tests are currently failing because: 1) CSSRotation should take numberishes 2) CSSRotation should also take CSSMathValues Bug: 774887 Change-Id: I55a77ad25167c0b0a0c650f6c774b6a117eb2ba1 Reviewed-on: https://chromium-review.googlesource.com/768594 Reviewed-by: meade_UTC10 <meade@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#517024} [modify] https://crrev.com/4c349014fc3d1bda22bbc2f299b91ea9c4ac3d52/third_party/WebKit/LayoutTests/typedcssom/cssRotation.html [add] https://crrev.com/4c349014fc3d1bda22bbc2f299b91ea9c4ac3d52/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssRotation-expected.txt [add] https://crrev.com/4c349014fc3d1bda22bbc2f299b91ea9c4ac3d52/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssRotation.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25e156adc119530d78492770a01ce7667879c3e6 commit 25e156adc119530d78492770a01ce7667879c3e6 Author: Darren Shen <shend@chromium.org> Date: Tue Nov 21 07:10:49 2017 [css-typed-om] Add tests for mutating StylePropertyMap. StylePropertyMap has several methods for mutating its state: - append - delete - set - update This patch adds tests for each of those. Note that 'update' was not originally in the IDL so we had to add it. There are several failing tests. Spec: https://drafts.css-houdini.org/css-typed-om-1/#stylepropertymap Bug: 774887 Change-Id: I1458cacfd95f4c0056f2e7bc6592798b2d3a1f64 Reviewed-on: https://chromium-review.googlesource.com/768252 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#518164} [modify] https://crrev.com/25e156adc119530d78492770a01ce7667879c3e6/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/styleMap-update-function-expected.txt [modify] https://crrev.com/25e156adc119530d78492770a01ce7667879c3e6/third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt [add] https://crrev.com/25e156adc119530d78492770a01ce7667879c3e6/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/append-expected.txt [add] https://crrev.com/25e156adc119530d78492770a01ce7667879c3e6/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/append.html [add] https://crrev.com/25e156adc119530d78492770a01ce7667879c3e6/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/delete-expected.txt [add] https://crrev.com/25e156adc119530d78492770a01ce7667879c3e6/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/delete.html [add] https://crrev.com/25e156adc119530d78492770a01ce7667879c3e6/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/set-expected.txt [add] https://crrev.com/25e156adc119530d78492770a01ce7667879c3e6/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/set.html [add] https://crrev.com/25e156adc119530d78492770a01ce7667879c3e6/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/update-expected.txt [add] https://crrev.com/25e156adc119530d78492770a01ce7667879c3e6/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/update.html [modify] https://crrev.com/25e156adc119530d78492770a01ce7667879c3e6/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/25e156adc119530d78492770a01ce7667879c3e6/third_party/WebKit/Source/bindings/core/v8/BUILD.gn [modify] https://crrev.com/25e156adc119530d78492770a01ce7667879c3e6/third_party/WebKit/Source/core/css/CSSProperties.json5 [modify] https://crrev.com/25e156adc119530d78492770a01ce7667879c3e6/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h [modify] https://crrev.com/25e156adc119530d78492770a01ce7667879c3e6/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72e39c13a335d85ecf6f128b529e2593d3def373 commit 72e39c13a335d85ecf6f128b529e2593d3def373 Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Mon Dec 18 01:18:18 2017 [css-typed-om] replace undefined variable with defined variable there is using undefined variable in iterable.html. it is cause to fail layout test. Bug: 774887 Change-Id: Ibe516bcd8a24cc21ed604a1a9cf85e392a1c40c5 Reviewed-on: https://chromium-review.googlesource.com/828562 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#524634} [delete] https://crrev.com/cedfd986e1aba860a363c54e3367647b0ded5ec2/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/iterable-expected.txt [modify] https://crrev.com/72e39c13a335d85ecf6f128b529e2593d3def373/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/iterable.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7bbec96604a6dfdc17862bbbd0faef03b31c487 commit e7bbec96604a6dfdc17862bbbd0faef03b31c487 Author: Darren Shen <shend@chromium.org> Date: Tue Dec 19 02:12:31 2017 [css-typed-om] Have separate tests for each style map. This patch creates two new folders: the-stylepropertymap/computed the-stylepropertymap/inline Each folder contains tests for each method in the computed and inline style property map API. Since we already have existing tests for the inline style property map, we just need to copy it for computed as well, but with some modifications because computed style property map contains every CSS property. Bug: 774887 Change-Id: I006249535094c2b59e3db0b728d32e40950d67de Reviewed-on: https://chromium-review.googlesource.com/831312 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#524915} [rename] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed/computed-expected.txt [rename] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed/computed.html [copy] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed/get.html [copy] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed/getAll.html [add] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed/getProperties-expected.txt [add] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed/getProperties.html [copy] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed/has.html [add] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed/iterable-expected.txt [add] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed/iterable.html [rename] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/append.html [rename] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/delete-expected.txt [rename] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/delete.html [rename] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/get.html [rename] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/getAll.html [rename] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/getProperties.html [rename] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/has.html [rename] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/iterable.html [rename] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/set-expected.txt [rename] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/set.html [rename] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/update-expected.txt [rename] https://crrev.com/e7bbec96604a6dfdc17862bbbd0faef03b31c487/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/update.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4730a09ad16c153e2ce65c673e5e15228698377 commit b4730a09ad16c153e2ce65c673e5e15228698377 Author: Darren Shen <shend@chromium.org> Date: Tue Dec 19 22:59:00 2017 [css-typed-om] Fix tests to handle default case. The Typed OM tests have a helper function (assert_style_value_equals) that checks if two CSSStyleValues have the same structure. It does this by checking what type the style value is. If it is not a CSSStyleValue, then we silently ignored it. This became a problem for CSSUnparsedValue, which is an array that may contain strings, because the strings are not CSSStyleValues and so they will be ignored and not tested. This patch adds a default case that uses assert_equals which handles the string case correctly. Bug: 774887 Change-Id: I74f1cc95f410c712c005ebcb596338d31e474119 Reviewed-on: https://chromium-review.googlesource.com/835088 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#525170} [modify] https://crrev.com/b4730a09ad16c153e2ce65c673e5e15228698377/third_party/WebKit/LayoutTests/typedcssom/resources/testhelper.js [modify] https://crrev.com/b4730a09ad16c153e2ce65c673e5e15228698377/third_party/WebKit/LayoutTests/typedcssom/stylevalue-normalization/normalize-tokens.html [modify] https://crrev.com/b4730a09ad16c153e2ce65c673e5e15228698377/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed/computed.html [modify] https://crrev.com/b4730a09ad16c153e2ce65c673e5e15228698377/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed/get.html [modify] https://crrev.com/b4730a09ad16c153e2ce65c673e5e15228698377/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed/getAll.html [modify] https://crrev.com/b4730a09ad16c153e2ce65c673e5e15228698377/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/get.html [modify] https://crrev.com/b4730a09ad16c153e2ce65c673e5e15228698377/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/getAll.html [modify] https://crrev.com/b4730a09ad16c153e2ce65c673e5e15228698377/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/iterable.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe commit fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe Author: Darren Shen <shend@chromium.org> Date: Mon Jan 01 23:07:46 2018 [css-typed-om] Use create* helper functions in tests. Currently, to test style property maps, we have to set up some divs in the body with the test styles. Each test case would then query the style maps of these divs. To simplify things, we add two helper functions: createInlineStyleMap and createComputedStyleMap. Each take a string containing css and will return an inline/computed StylePropertyMap with that css. This adds greater isolation between test cases, simplifies tests, and will help write succinct tests for the declared style property map, which has a lot of boilerplate. Bug: 774887 Change-Id: I0ffc571e37601fea02f9d27ef458e3c569ba58cf Reviewed-on: https://chromium-review.googlesource.com/835887 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#526429} [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/resources/testhelper.js [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/stylevalue-normalization/normalize-ident.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/stylevalue-normalization/normalize-numeric.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/stylevalue-normalization/normalize-tokens.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/stylevalue-normalization/transformvalue-normalization.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/stylevalue-objects/parse-relative-url.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/stylevalue-serialization/cssKeywordValue.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/stylevalue-serialization/cssPositionValue.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/stylevalue-serialization/cssUnitValue.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssUrlImageValue.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed/computed.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed/get.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed/getAll.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed/getProperties.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed/has.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed/iterable.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/append.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/delete.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/get.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/getAll.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/getProperties.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/has.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/iterable.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/set.html [modify] https://crrev.com/fbf25ea941bf9f15aa1558c9606d25ef87fd2cfe/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/inline/update.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f2a7d4186bca2c414c87afc3f7b767b669abe32 commit 7f2a7d4186bca2c414c87afc3f7b767b669abe32 Author: Darren Shen <shend@chromium.org> Date: Tue Jan 02 05:16:14 2018 [css-typed-om] Change Q and Hz tests to expect lowercase serialization. As mentioned in [1], serialization of Q and Hz should produce lowercase. [1] https://github.com/w3c/css-houdini-drafts/issues/504 Bug: 774887 Change-Id: I1c82486f1067eefd315c3a5da5792f2cf62d4b2b Reviewed-on: https://chromium-review.googlesource.com/846652 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#526439} [modify] https://crrev.com/7f2a7d4186bca2c414c87afc3f7b767b669abe32/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/numeric-objects/cssUnitValue-expected.txt [modify] https://crrev.com/7f2a7d4186bca2c414c87afc3f7b767b669abe32/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/numeric-objects/cssUnitValue.html [modify] https://crrev.com/7f2a7d4186bca2c414c87afc3f7b767b669abe32/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/numeric-objects/numeric-factory-expected.txt [modify] https://crrev.com/7f2a7d4186bca2c414c87afc3f7b767b669abe32/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/numeric-objects/numeric-factory.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3666df2c653d78de3d72d8376e922bc334a8c0b commit d3666df2c653d78de3d72d8376e922bc334a8c0b Author: Darren Shen <shend@chromium.org> Date: Wed Jan 03 23:48:36 2018 [css-typed-om] Add IDL tests for CSSStyleValue. This patch uses idlharness.js to test the CSSStyleValue interface. Bug: 774887 Change-Id: I20e487e2ec0e733e5ab152e1f9e9fa6bc2c5a605 Reviewed-on: https://chromium-review.googlesource.com/848116 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#526864} [add] https://crrev.com/d3666df2c653d78de3d72d8376e922bc334a8c0b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-objects/interface.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df0d9265ec03bb939f2dcab74807c9e7fb3b97b7 commit df0d9265ec03bb939f2dcab74807c9e7fb3b97b7 Author: Darren Shen <shend@chromium.org> Date: Thu Jan 04 04:41:21 2018 [css-typed-om] Add IDL tests for CSSKeywordValue. This patch uses idlharness.js to test the CSSKeywordValue interface. Bug: 774887 Change-Id: I64bd459bcc199094fc0ce60c217110fc0f0cb17f Reviewed-on: https://chromium-review.googlesource.com/848117 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#526921} [add] https://crrev.com/df0d9265ec03bb939f2dcab74807c9e7fb3b97b7/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssKeywordValue-interface.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d17f45e2633f4260779d73c214bc389e5af179d9 commit d17f45e2633f4260779d73c214bc389e5af179d9 Author: Darren Shen <shend@chromium.org> Date: Sun Jan 07 21:49:40 2018 [css-typed-om] Upstream CSSStyleValue.parse and .parseAll tests. This patch upstreams tests for CSSStyleValue.parse and .parseAll. We made the following changes: - Split the tests into 4 files (parse, parse-invalid, parseAll, parseAll-invalid). - Added <meta name="assert"> tags to distinguish the different files. See [1] about metadata. - Inlined test cases. More code duplication but (hopefully) more readable than a loop over test cases. [1] http://web-platform-tests.org/writing-tests/css-metadata.html Bug: 774887 Change-Id: I766be70744218549f86ee95212f9899310960d9b Reviewed-on: https://chromium-review.googlesource.com/848489 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#527545} [add] https://crrev.com/d17f45e2633f4260779d73c214bc389e5af179d9/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-objects/parse-invalid.html [add] https://crrev.com/d17f45e2633f4260779d73c214bc389e5af179d9/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-objects/parse.html [add] https://crrev.com/d17f45e2633f4260779d73c214bc389e5af179d9/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-objects/parseAll-invalid.html [add] https://crrev.com/d17f45e2633f4260779d73c214bc389e5af179d9/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-objects/parseAll.html [delete] https://crrev.com/fa0fbd04bd63be9d9d8e6e5b329e36d3b0e53001/third_party/WebKit/LayoutTests/typedcssom/stylevalue-objects/parse-parseAll.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ca4e0d10663b04e9d83c5533537d0984576825b commit 0ca4e0d10663b04e9d83c5533537d0984576825b Author: Darren Shen <shend@chromium.org> Date: Mon Jan 08 07:08:15 2018 [css-typed-om] Update CSSTransformValue.toMatrix() tests. This patch updates CSSTransformValue.toMatrix() tests and consolidates them into one file. It also fixes a bug involving CSSScale not respecting the is2D attribute. Spec: https://drafts.css-houdini.org/css-typed-om-1/#dom-csstransformvalue-tomatrix Bug: 774887 Change-Id: I338d36566add8328ca302a2f799fea81939aea55 Reviewed-on: https://chromium-review.googlesource.com/846559 Reviewed-by: meade_UTC10 <meade@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#527581} [modify] https://crrev.com/0ca4e0d10663b04e9d83c5533537d0984576825b/third_party/WebKit/LayoutTests/typedcssom/cssMatrixComponent.html [delete] https://crrev.com/39e67b25b7b45d01f3e74a9e1520576790cff93d/third_party/WebKit/LayoutTests/typedcssom/cssPerspective.html [modify] https://crrev.com/0ca4e0d10663b04e9d83c5533537d0984576825b/third_party/WebKit/LayoutTests/typedcssom/cssRotation.html [modify] https://crrev.com/0ca4e0d10663b04e9d83c5533537d0984576825b/third_party/WebKit/LayoutTests/typedcssom/cssTranslation.html [modify] https://crrev.com/0ca4e0d10663b04e9d83c5533537d0984576825b/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssTransformValue.html [modify] https://crrev.com/0ca4e0d10663b04e9d83c5533537d0984576825b/third_party/WebKit/Source/core/css/cssom/CSSScale.cpp [modify] https://crrev.com/0ca4e0d10663b04e9d83c5533537d0984576825b/third_party/WebKit/Source/core/css/cssom/CSSTranslation.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00e802bf84ff37f2af092e619ba378eee208c435 commit 00e802bf84ff37f2af092e619ba378eee208c435 Author: Darren Shen <shend@chromium.org> Date: Tue Jan 09 23:38:41 2018 [css-typed-om] Add IDL tests for StylePropertyMap(ReadOnly). This patch uses idlharness.js to test the StylePropertyMap(ReadOnly) interface. There's an expected failure due to https://github.com/w3c/css-houdini-drafts/issues/268 Bug: 774887 Change-Id: Id3bfb55dad2b1a8dd3957b63904fb95b38f602a7 Reviewed-on: https://chromium-review.googlesource.com/848483 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#528167} [add] https://crrev.com/00e802bf84ff37f2af092e619ba378eee208c435/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/interface-expected.txt [add] https://crrev.com/00e802bf84ff37f2af092e619ba378eee208c435/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/interface.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/941d30c5c0449f8d0381dfaa8b8baefa3870d294 commit 941d30c5c0449f8d0381dfaa8b8baefa3870d294 Author: Darren Shen <shend@chromium.org> Date: Thu Jan 11 20:57:05 2018 [css-typed-om] Add IDL tests for CSSPositionValue. This patch uses idlharness.js to test the CSSPositionValue interface. Bug: 774887 Change-Id: I6298716200a662201e7d5dbb11a4fb7328d5cafb Reviewed-on: https://chromium-review.googlesource.com/860963 Reviewed-by: meade_UTC10 <meade@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#528750} [add] https://crrev.com/941d30c5c0449f8d0381dfaa8b8baefa3870d294/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssPositionValue-interface.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ab65234c1431dbb5c2dc2e86e2a9cc81908ccec commit 9ab65234c1431dbb5c2dc2e86e2a9cc81908ccec Author: Darren Shen <shend@chromium.org> Date: Mon Jan 15 05:52:44 2018 [css-typed-om] Upstream CSSKeywordValue tests. This patch upstreams CSSKeywordValue tests to WPT. We split the original test into two seperate tests (one for valid and one for invalid inputs). Bug: 774887 Change-Id: Ic215178739e7a6d6399297b31e4ecf540a2b046b Reviewed-on: https://chromium-review.googlesource.com/866518 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#529205} [add] https://crrev.com/9ab65234c1431dbb5c2dc2e86e2a9cc81908ccec/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssKeywordValue-invalid.html [add] https://crrev.com/9ab65234c1431dbb5c2dc2e86e2a9cc81908ccec/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssKeywordValue.html [delete] https://crrev.com/021cd4a8c2bccff607130d9a34a2fcce763de966/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssKeywordValue.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a358c1523e705f3a9204b5be2f2853dc798a034d commit a358c1523e705f3a9204b5be2f2853dc798a034d Author: Darren Shen <shend@chromium.org> Date: Wed Jan 17 21:15:35 2018 [css-typed-om] Upstream serialization & normalization tests as tentative This patch upstreams serialization and normalization tests as tentative WPTs. We modified the include paths to match WPT. We also copied the existing resources in our layout tests. Our plan is to eventually clean up these tests and remove the tentative label. Bug: 774887 Change-Id: I7651b8003bb7917157c6f6008b7093c8e85d9a2d Reviewed-on: https://chromium-review.googlesource.com/869631 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#529893} [add] https://crrev.com/a358c1523e705f3a9204b5be2f2853dc798a034d/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/resources/1x1-green.png [add] https://crrev.com/a358c1523e705f3a9204b5be2f2853dc798a034d/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/resources/testhelper.js [rename] https://crrev.com/a358c1523e705f3a9204b5be2f2853dc798a034d/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-normalization/normalize-ident.tentative.html [rename] https://crrev.com/a358c1523e705f3a9204b5be2f2853dc798a034d/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-normalization/normalize-numeric.tentative.html [rename] https://crrev.com/a358c1523e705f3a9204b5be2f2853dc798a034d/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-normalization/normalize-resource.tentative-expected.txt [rename] https://crrev.com/a358c1523e705f3a9204b5be2f2853dc798a034d/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-normalization/normalize-resource.tentative.html [rename] https://crrev.com/a358c1523e705f3a9204b5be2f2853dc798a034d/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-normalization/normalize-tokens.tentative.html [rename] https://crrev.com/a358c1523e705f3a9204b5be2f2853dc798a034d/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-normalization/positionvalue-normalization.tentative.html [rename] https://crrev.com/a358c1523e705f3a9204b5be2f2853dc798a034d/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-normalization/transformvalue-normalization.tentative.html [rename] https://crrev.com/a358c1523e705f3a9204b5be2f2853dc798a034d/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-serialization/cssKeywordValue.tentative.html [rename] https://crrev.com/a358c1523e705f3a9204b5be2f2853dc798a034d/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-serialization/cssMathValue.tentative.html [rename] https://crrev.com/a358c1523e705f3a9204b5be2f2853dc798a034d/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-serialization/cssTransformValue.tentative.html [rename] https://crrev.com/a358c1523e705f3a9204b5be2f2853dc798a034d/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-serialization/cssUnitValue.tentative.html [rename] https://crrev.com/a358c1523e705f3a9204b5be2f2853dc798a034d/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-serialization/cssUnparsedValue.tentative.html [rename] https://crrev.com/a358c1523e705f3a9204b5be2f2853dc798a034d/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-serialization/cssUrlImageValue.tentative.html [delete] https://crrev.com/903169c43667530a44f536a24f78fa45f5c7da90/third_party/WebKit/LayoutTests/typedcssom/stylevalue-serialization/cssPositionValue-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de19abd4c49114c0def55b855b9fe2831b484f8c commit de19abd4c49114c0def55b855b9fe2831b484f8c Author: Darren Shen <shend@chromium.org> Date: Thu Jan 18 00:09:54 2018 [css-typed-om] Upstream style property map tests as tentative This patch upstreams style property map tests as tentative WPTs. We modified the include paths to match WPT. Our plan is to eventually clean up these tests and remove the tentative label. TBR=nainar@chromium.org Bug: 774887 Change-Id: I20e6e025e9a78678db4e63ce3a82905d0fa3b20d Reviewed-on: https://chromium-review.googlesource.com/871731 Reviewed-by: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#529960} [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/computed/computed.tentative-expected.txt [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/computed/computed.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/computed/get.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/computed/getAll.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/computed/getProperties.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/computed/has.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/computed/iterable.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/declared/append.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/declared/declared.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/declared/delete-expected.txt [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/declared/get.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/declared/getAll.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/declared/getProperties.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/declared/has.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/declared/iterable.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/declared/set.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/declared/test.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/declared/update.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/inline/append.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/inline/delete.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/inline/get.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/inline/getAll.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/inline/getProperties.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/inline/has.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/inline/iterable.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/inline/set.tentative.html [rename] https://crrev.com/de19abd4c49114c0def55b855b9fe2831b484f8c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/inline/update.tentative.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ad51612ce8cd153c47dda9ea3fca5051efbab04 commit 3ad51612ce8cd153c47dda9ea3fca5051efbab04 Author: Darren Shen <shend@chromium.org> Date: Thu Jan 18 03:03:58 2018 [css-typed-om] Upstream CSSPositionValue serialization to WPT. This patch upstreams the CSSPositionValue serialization test [1] to WPT. Note that the original test was accidentally deleted in [2]. [1] https://chromium.googlesource.com/chromium/src/+/4853213e011c9f5b8bc67f4dd966a3213e71fd87/third_party/WebKit/LayoutTests/typedcssom/stylevalue-serialization/cssPositionValue.html [2] https://chromium.googlesource.com/chromium/src/+/ce65e32cc96765afe77a7388c1a2a876b37d593e Bug: 774887 Change-Id: I1a88925ac37802ae47aff35e65f72592fcfb7f9e Reviewed-on: https://chromium-review.googlesource.com/869010 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#530033} [add] https://crrev.com/3ad51612ce8cd153c47dda9ea3fca5051efbab04/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-serialization/cssPositionValue.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17ee3de54388382d020e6e7420ddb945ec6e23aa commit 17ee3de54388382d020e6e7420ddb945ec6e23aa Author: Darren Shen <shend@chromium.org> Date: Thu Jan 18 06:23:46 2018 [css-typed-om] Clean up CSSUnparsedValue serialization test This patch cleans up the CSSUnparsedValue serialization tests to make it more suitable for WPT. We remove the .tentative extension. Bug: 774887 Change-Id: Ifaca6831f0ee60b1515a719ed13438dc1842134f Reviewed-on: https://chromium-review.googlesource.com/871990 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#530072} [add] https://crrev.com/17ee3de54388382d020e6e7420ddb945ec6e23aa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-serialization/cssUnparsedValue.html [delete] https://crrev.com/540c7d5dbb9311acee17501336b477498bf9b266/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-serialization/cssUnparsedValue.tentative.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/757074630d6dc6346a5f2de8a7e6ebff01b67462 commit 757074630d6dc6346a5f2de8a7e6ebff01b67462 Author: Darren Shen <shend@chromium.org> Date: Thu Jan 18 10:37:32 2018 [css-typed-om] Clean up StylePropertyMap.delete tests. This patch does the following to clean up the StylePropertyMap.delete tests for WPT: - We split happy cases and sad cases into separate files. - We used to test delete by calling .delete and then checking if .has returns false. There are a few problems with this: - it's arbitrary why we use .has (and not, say, .get) to check if the property was deleted. - our tests for .delete depend on .has to be implemented correctly. - we are not actually testing that the property was removed from element's style (i.e. the style map may not propagate changes to the element's style correctly and the tests wouldn't catch that). So, to avoid these downsides, we change the tests to call .delete and then checking the element's actual style from CSSOM. - For some reason declared didn't have .delete tests but had an expectation file. We add a test for declared .delete, which is basically the same as the inline tests but using a rule instead of an element. - We removed the .tentative extension. Bug: 774887 Change-Id: Ie911b62e493d0ce371b85b1a1a0597fac4ca3f4e Reviewed-on: https://chromium-review.googlesource.com/872515 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#530113} [modify] https://crrev.com/757074630d6dc6346a5f2de8a7e6ebff01b67462/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/resources/testhelper.js [add] https://crrev.com/757074630d6dc6346a5f2de8a7e6ebff01b67462/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/declared/delete-invalid.html [add] https://crrev.com/757074630d6dc6346a5f2de8a7e6ebff01b67462/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/declared/delete.html [add] https://crrev.com/757074630d6dc6346a5f2de8a7e6ebff01b67462/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/inline/delete-invalid.html [add] https://crrev.com/757074630d6dc6346a5f2de8a7e6ebff01b67462/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/inline/delete.html [delete] https://crrev.com/3662ebcc77ccc9f31cd7d73571c7e8f07d79056e/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/inline/delete.tentative.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73880bed31b170157ad8adfef5dbcb5012e86091 commit 73880bed31b170157ad8adfef5dbcb5012e86091 Author: Darren Shen <shend@chromium.org> Date: Thu Jan 18 21:06:31 2018 [css-typed-om] Upstream style value subclass tests as tentative This patch upstreams style value subclass tests as tentative WPTs. We modified the include paths to match WPT. Our plan is to eventually clean up these tests and remove the tentative label. TBR=nainar@chromium.org Bug: 774887 Change-Id: Ia0b683eb41fa0f65bfdce54315ea687123a78a76 Reviewed-on: https://chromium-review.googlesource.com/872475 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#530269} [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssMatrixComponent.tentative.html [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssPerspective.tentative.html [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssPositionValue.tentative.html [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssRotation.tentative.html [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssScale.tentative.html [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssSkew.tentative.html [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssTransformValue.tentative.html [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssTranslation.tentative.html [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue.tentative.html [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssUrlImageValue.tentative.html [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssVariableReferenceValue.tentative-expected.txt [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssVariableReferenceValue.tentative.html [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/arithmetic.tentative.html [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssMathValue.tentative.html [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssUnitValue.tentative-expected.txt [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssUnitValue.tentative.html [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/equals.tentative.html [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/numeric-factory.tentative-expected.txt [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/numeric-factory.tentative.html [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/numeric-typing.tentative.html [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/parse.tentative.html [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/to.tentative.html [rename] https://crrev.com/73880bed31b170157ad8adfef5dbcb5012e86091/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/toSum.tentative.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b1843c7b99837e8d9089317ab5b0adf758415a2 commit 6b1843c7b99837e8d9089317ab5b0adf758415a2 Author: Darren Shen <shend@chromium.org> Date: Tue Jan 23 02:14:07 2018 [css-typed-om] Clean up StylePropertyMap.get tests. This patch does the following to clean up the StylePropertyMap.get tests for WPT: - We split happy cases and sad cases into separate files. - We removed the .tentative extension. - Added additional tests for style map liveness. Bug: 774887 Change-Id: I4143b6358f0d2b11fbb34be03696d5eea00bd0fa Reviewed-on: https://chromium-review.googlesource.com/878104 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#531129} [modify] https://crrev.com/6b1843c7b99837e8d9089317ab5b0adf758415a2/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/resources/testhelper.js [add] https://crrev.com/6b1843c7b99837e8d9089317ab5b0adf758415a2/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/computed/get-invalid.html [add] https://crrev.com/6b1843c7b99837e8d9089317ab5b0adf758415a2/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/computed/get.html [delete] https://crrev.com/4454e1b88f2a7bf81f859c939881c303cfc60827/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/computed/get.tentative.html [add] https://crrev.com/6b1843c7b99837e8d9089317ab5b0adf758415a2/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/declared/get-invalid.html [add] https://crrev.com/6b1843c7b99837e8d9089317ab5b0adf758415a2/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/declared/get.html [delete] https://crrev.com/4454e1b88f2a7bf81f859c939881c303cfc60827/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/declared/get.tentative.html [add] https://crrev.com/6b1843c7b99837e8d9089317ab5b0adf758415a2/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/inline/get-invalid.html [add] https://crrev.com/6b1843c7b99837e8d9089317ab5b0adf758415a2/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/inline/get.html [delete] https://crrev.com/4454e1b88f2a7bf81f859c939881c303cfc60827/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/inline/get.tentative.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ef8aa85cf244edd8e1209e2e71b235e65497435 commit 4ef8aa85cf244edd8e1209e2e71b235e65497435 Author: Darren Shen <shend@chromium.org> Date: Tue Jan 30 22:37:54 2018 [css-typed-om] Untentative CSSUnparsedValue. Removes .tentative extension from CSSUnparsedValue WPT. Also adds a interface IDL test, which is currently failing because Blink doesn't implement Array.values. Bug: 774887 Change-Id: Ia59af546f72a1a664e16cb708dce3e97dfec75ea Reviewed-on: https://chromium-review.googlesource.com/892583 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#533051} [add] https://crrev.com/4ef8aa85cf244edd8e1209e2e71b235e65497435/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue-interface-expected.txt [add] https://crrev.com/4ef8aa85cf244edd8e1209e2e71b235e65497435/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue-interface.html [add] https://crrev.com/4ef8aa85cf244edd8e1209e2e71b235e65497435/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue.html [delete] https://crrev.com/72816eaa19b0eca08b6ccbfd642148690a55922a/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue.tentative.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af572bced32ae373f31b9a13dcc8891873049259 commit af572bced32ae373f31b9a13dcc8891873049259 Author: Darren Shen <shend@chromium.org> Date: Wed Jan 31 01:37:28 2018 [css-typed-om] Remove junk test. Accidentally upstreamed a test test. TBR=nainar@chromium.org Bug: 774887 Change-Id: I52b48d2d83f1bdc95d0ac6ffcf5c58d791aa5cf7 Reviewed-on: https://chromium-review.googlesource.com/894744 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#533149} [delete] https://crrev.com/5c7b0986b75f2846359a8adde0d65b0ba31c2e00/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/declared/test.tentative.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1beb3de201b01cebaa84cefad241a6130255ccc9 commit 1beb3de201b01cebaa84cefad241a6130255ccc9 Author: Darren Shen <shend@chromium.org> Date: Wed Jan 31 04:47:03 2018 [css-typed-om] Untentative CSSPositionValue tests. We untentative CSSPositionValue tests. We also split happy and sad tests Spec: https://drafts.css-houdini.org/css-typed-om-1/#positionvalue-objects TBR=nainar@chromium.org Bug: 774887 Change-Id: I33052e0dc6400f5de693da9449d769012919dee3 Reviewed-on: https://chromium-review.googlesource.com/894748 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#533204} [add] https://crrev.com/1beb3de201b01cebaa84cefad241a6130255ccc9/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssPositionValue-invalid.html [add] https://crrev.com/1beb3de201b01cebaa84cefad241a6130255ccc9/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssPositionValue.html [delete] https://crrev.com/101743dbd356cc02cfdb6c424bd1477a6c767321/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssPositionValue.tentative.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29c4281dc734ff1e86fed6a868a1a09de2195483 commit 29c4281dc734ff1e86fed6a868a1a09de2195483 Author: Darren Shen <shend@chromium.org> Date: Fri Feb 02 04:42:49 2018 [css-typed-om] Untentative CSSURLImageValue tests. This patch removes the tentative extension from CSSURLImageValue and adds an IDLHarness test for it. TBR=nainar@chromium.org Bug: 774887 Change-Id: I3dceb0a91231f40ff7a44a620146bcf77baf260f Reviewed-on: https://chromium-review.googlesource.com/897229 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#533954} [add] https://crrev.com/29c4281dc734ff1e86fed6a868a1a09de2195483/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssUrlImageValue-interface.html [add] https://crrev.com/29c4281dc734ff1e86fed6a868a1a09de2195483/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssUrlImageValue-invalid.html [add] https://crrev.com/29c4281dc734ff1e86fed6a868a1a09de2195483/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssUrlImageValue.html [delete] https://crrev.com/c0a946a4dec56ce5906a78f6e0b0c1f9e12c70b6/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssUrlImageValue.tentative.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d70df684c588af690e99fe7c5879f2113e231065 commit d70df684c588af690e99fe7c5879f2113e231065 Author: Darren Shen <shend@chromium.org> Date: Sun Feb 04 23:03:10 2018 [css-typed-om] Combine all the IDL tests into one. This patch adds the Typed OM IDL into WPT /interfaces (as tentative) and adds a IDLHarness test. We also delete existing IDL tests spread throughout the Typed OM WPT. Bug: 774887 Change-Id: I8e9af9d8f82e483a1c501fc550b488bf8791d3fd Reviewed-on: https://chromium-review.googlesource.com/897075 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#534305} [add] https://crrev.com/d70df684c588af690e99fe7c5879f2113e231065/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/interfaces-expected.txt [add] https://crrev.com/d70df684c588af690e99fe7c5879f2113e231065/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/interfaces.html [delete] https://crrev.com/fd9b9e4576ddb57c371c80e5eb379903361d0495/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssKeywordValue-interface.html [delete] https://crrev.com/fd9b9e4576ddb57c371c80e5eb379903361d0495/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssPositionValue-interface.html [delete] https://crrev.com/fd9b9e4576ddb57c371c80e5eb379903361d0495/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue-interface-expected.txt [delete] https://crrev.com/fd9b9e4576ddb57c371c80e5eb379903361d0495/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue-interface.html [delete] https://crrev.com/fd9b9e4576ddb57c371c80e5eb379903361d0495/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssVariableReferenceValue-interface.html [delete] https://crrev.com/fd9b9e4576ddb57c371c80e5eb379903361d0495/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/interface.html [add] https://crrev.com/d70df684c588af690e99fe7c5879f2113e231065/third_party/WebKit/LayoutTests/external/wpt/interfaces/css-typed-om.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a4cbea61a82fa621743aef998d918b72fc2735c commit 9a4cbea61a82fa621743aef998d918b72fc2735c Author: Darren Shen <shend@chromium.org> Date: Tue Feb 06 04:28:35 2018 [css-typed-om] Add per-property tests. Currently, we don't have any test coverage over properties. In our existing tests, we only use 'canonical' test properties like 'width'. This means that it's possible that other properties (e.g. 'height') might not work and we still pass the tests. We add a bunch of new files, each representing a property. Think of these as metadata for the properties. For example, each file contains the values that are valid for that property. We then have a test suite that uses this metadata to generate appropriate tests. More properties will be coming. There is a test failure involving setting margin-top to unitless zero. Bug: 774887 Change-Id: I8f8463c8f608454ef177e81ace21fe1eeb66f897 Reviewed-on: https://chromium-review.googlesource.com/882901 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#534623} [add] https://crrev.com/9a4cbea61a82fa621743aef998d918b72fc2735c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/display.html [add] https://crrev.com/9a4cbea61a82fa621743aef998d918b72fc2735c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/margin-top-expected.txt [add] https://crrev.com/9a4cbea61a82fa621743aef998d918b72fc2735c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/margin-top.html [add] https://crrev.com/9a4cbea61a82fa621743aef998d918b72fc2735c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js [modify] https://crrev.com/9a4cbea61a82fa621743aef998d918b72fc2735c/third_party/WebKit/Source/core/css/CSSProperties.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee0cdef5544a6db01a0d85026d63509b8484ddbc commit ee0cdef5544a6db01a0d85026d63509b8484ddbc Author: Darren Shen <shend@chromium.org> Date: Mon Feb 12 01:58:18 2018 [css-typed-om] Test that styleMap.set rejects invalid values. Currently, our per-property tests only test that styleMap.set accept valid values. This patch refactors the per-property tests a bit to also test that we reject invalid values. Bug: 774887 Change-Id: I41b5c4c1a6dfe6e766ff37fdc1b1f890dfb81aac Reviewed-on: https://chromium-review.googlesource.com/905523 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#536021} [modify] https://crrev.com/ee0cdef5544a6db01a0d85026d63509b8484ddbc/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/margin-top-expected.txt [modify] https://crrev.com/ee0cdef5544a6db01a0d85026d63509b8484ddbc/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js [modify] https://crrev.com/ee0cdef5544a6db01a0d85026d63509b8484ddbc/third_party/WebKit/Source/core/css/CSSProperties.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e73de98545801f60a41500be89b6013f4eee3fb commit 8e73de98545801f60a41500be89b6013f4eee3fb Author: Darren Shen <shend@chromium.org> Date: Mon Feb 12 02:06:46 2018 [css-typed-om] Remove useless layout tests. There are some layout tests in typedcssom that are now covered by other tests (either WPT or IDLHarness). We can remove them. Bug: 774887 Change-Id: I39277868e2a656d66795753c984755ac8a5d330d Reviewed-on: https://chromium-review.googlesource.com/912850 Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#536023} [delete] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/LayoutTests/typedcssom/cssMatrixComponent.html [delete] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/LayoutTests/typedcssom/cssPositionValue.html [delete] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/LayoutTests/typedcssom/cssRotate.html [delete] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/LayoutTests/typedcssom/cssScale.html [delete] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/LayoutTests/typedcssom/cssTranslate.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66bf68ee6840ca2049151a2a1daf203cd628017a commit 66bf68ee6840ca2049151a2a1daf203cd628017a Author: Darren Shen <shend@chromium.org> Date: Wed Feb 14 02:01:12 2018 [css-typed-om] Refactor the per-property test harness. This patch refactors the per-property test harness quite a bit to deal with property specific behaviour: - We allow tests to override the expectation/asserts for specified and computed values. So it means that a property might compute 'auto' to '0px' and we can easily assert that by passing a callback to 'computed'. - We moved margin-top to margin and test all the margin properties (except the margin shorthand). - We made margin properties work by setting the correct metadata in the CSSProperties.json5. - We removed unitless zero tests. They don't seem to be required by the spec. Bug: 774887 Change-Id: I08605ac6af01576ff9f6c878c2ca9e280c9948e1 Reviewed-on: https://chromium-review.googlesource.com/915884 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#536603} [modify] https://crrev.com/66bf68ee6840ca2049151a2a1daf203cd628017a/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/display.html [delete] https://crrev.com/2cc05b1059c06dee98b1775383e4d7b8d0b09256/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/margin-top-expected.txt [delete] https://crrev.com/2cc05b1059c06dee98b1775383e4d7b8d0b09256/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/margin-top.html [add] https://crrev.com/66bf68ee6840ca2049151a2a1daf203cd628017a/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/margin.html [modify] https://crrev.com/66bf68ee6840ca2049151a2a1daf203cd628017a/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js [modify] https://crrev.com/66bf68ee6840ca2049151a2a1daf203cd628017a/third_party/WebKit/Source/core/css/CSSProperties.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50793b7939254a0c0add37d2858af18e4f0682b7 commit 50793b7939254a0c0add37d2858af18e4f0682b7 Author: Darren Shen <shend@chromium.org> Date: Wed Feb 14 05:53:33 2018 [css-typed-om] Move inline style map layout tests to WPT. We used to have some inline style map layout tests for a subset of properties. This patch moves them to WPT using the new test harness. Fixed some bugs involving properties not given the correct metadata (e.g. border-style should not take an <image>). Transform is failing tests because it should compute to as specified but it's computing to 'none' (will fix this later). TODO in follow up patches: - Test list-valued properties properly. - Add more test examples to <position> and <image>. Bug: 774887 Change-Id: I93f20a457e2220329b661787c7d557ee28b1f62d Reviewed-on: https://chromium-review.googlesource.com/917921 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#536658} [add] https://crrev.com/50793b7939254a0c0add37d2858af18e4f0682b7/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/animation-direction.html [add] https://crrev.com/50793b7939254a0c0add37d2858af18e4f0682b7/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/background-image.html [add] https://crrev.com/50793b7939254a0c0add37d2858af18e4f0682b7/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/border-style.html [add] https://crrev.com/50793b7939254a0c0add37d2858af18e4f0682b7/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/border-width.html [add] https://crrev.com/50793b7939254a0c0add37d2858af18e4f0682b7/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/bottom.html [add] https://crrev.com/50793b7939254a0c0add37d2858af18e4f0682b7/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/height.html [add] https://crrev.com/50793b7939254a0c0add37d2858af18e4f0682b7/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/left.html [add] https://crrev.com/50793b7939254a0c0add37d2858af18e4f0682b7/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/object-position.html [modify] https://crrev.com/50793b7939254a0c0add37d2858af18e4f0682b7/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js [add] https://crrev.com/50793b7939254a0c0add37d2858af18e4f0682b7/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/right.html [add] https://crrev.com/50793b7939254a0c0add37d2858af18e4f0682b7/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/top.html [add] https://crrev.com/50793b7939254a0c0add37d2858af18e4f0682b7/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transform-expected.txt [add] https://crrev.com/50793b7939254a0c0add37d2858af18e4f0682b7/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transform.html [add] https://crrev.com/50793b7939254a0c0add37d2858af18e4f0682b7/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/width.html [delete] https://crrev.com/aadce66e324f51a497271384d3b3e3c9629f6233/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/animation-direction.html [delete] https://crrev.com/aadce66e324f51a497271384d3b3e3c9629f6233/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/background-image.html [delete] https://crrev.com/aadce66e324f51a497271384d3b3e3c9629f6233/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/border-bottom-style.html [delete] https://crrev.com/aadce66e324f51a497271384d3b3e3c9629f6233/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/border-bottom-width.html [delete] https://crrev.com/aadce66e324f51a497271384d3b3e3c9629f6233/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/border-left-style.html [delete] https://crrev.com/aadce66e324f51a497271384d3b3e3c9629f6233/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/border-left-width.html [delete] https://crrev.com/aadce66e324f51a497271384d3b3e3c9629f6233/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/border-right-style.html [delete] https://crrev.com/aadce66e324f51a497271384d3b3e3c9629f6233/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/border-right-width.html [delete] https://crrev.com/aadce66e324f51a497271384d3b3e3c9629f6233/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/border-top-style.html [delete] https://crrev.com/aadce66e324f51a497271384d3b3e3c9629f6233/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/border-top-width.html [delete] https://crrev.com/aadce66e324f51a497271384d3b3e3c9629f6233/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/bottom.html [delete] https://crrev.com/aadce66e324f51a497271384d3b3e3c9629f6233/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/config-templates.js [delete] https://crrev.com/aadce66e324f51a497271384d3b3e3c9629f6233/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/height.html [delete] https://crrev.com/aadce66e324f51a497271384d3b3e3c9629f6233/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/left.html [delete] https://crrev.com/aadce66e324f51a497271384d3b3e3c9629f6233/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/object-position.html [delete] https://crrev.com/aadce66e324f51a497271384d3b3e3c9629f6233/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/property-suite.js [delete] https://crrev.com/aadce66e324f51a497271384d3b3e3c9629f6233/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/right.html [delete] https://crrev.com/aadce66e324f51a497271384d3b3e3c9629f6233/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/top.html [delete] https://crrev.com/aadce66e324f51a497271384d3b3e3c9629f6233/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/transform.html [delete] https://crrev.com/aadce66e324f51a497271384d3b3e3c9629f6233/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/width.html [modify] https://crrev.com/50793b7939254a0c0add37d2858af18e4f0682b7/third_party/WebKit/Source/core/css/CSSProperties.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52d3f11d8bb93b3808fb9d5b9b53530c01ab21fe commit 52d3f11d8bb93b3808fb9d5b9b53530c01ab21fe Author: Naina Raisinghani <nainar@chromium.org> Date: Wed Feb 14 11:33:22 2018 [css-typed-om] Move inline style map layout tests to WPT. We used to have some inline style map layout tests for a subset of properties. This patch moves them to WPT using the new test harness. Properties added: - position - padding-{top,bottom,left,right} - text-align - text-decoration-style Bug: 774887 Change-Id: I9fc9d6d425b1a5ce0c71f8d918bc5893c74c4e89 Reviewed-on: https://chromium-review.googlesource.com/917927 Commit-Queue: nainar <nainar@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#536698} [add] https://crrev.com/52d3f11d8bb93b3808fb9d5b9b53530c01ab21fe/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/padding.html [add] https://crrev.com/52d3f11d8bb93b3808fb9d5b9b53530c01ab21fe/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/position.html [add] https://crrev.com/52d3f11d8bb93b3808fb9d5b9b53530c01ab21fe/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-align.html [add] https://crrev.com/52d3f11d8bb93b3808fb9d5b9b53530c01ab21fe/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-decoration-style.html [modify] https://crrev.com/52d3f11d8bb93b3808fb9d5b9b53530c01ab21fe/third_party/WebKit/Source/core/css/CSSProperties.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e02b6826ad29d9c0312f9fe122b8661e73de6318 commit e02b6826ad29d9c0312f9fe122b8661e73de6318 Author: Naina Raisinghani <nainar@chromium.org> Date: Thu Feb 15 08:05:03 2018 [css-typed-om] Move inline style map layout tests to WPT. We used to have some inline style map layout tests for a subset of properties. This patch moves them to WPT using the new test harness. Properties added: - white-space - vertical-align - visibility - z-index Bug: 774887 Change-Id: Icce056c4d7f56eed3da05834b1c561fddec53a15 Reviewed-on: https://chromium-review.googlesource.com/918203 Commit-Queue: nainar <nainar@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#536966} [add] https://crrev.com/e02b6826ad29d9c0312f9fe122b8661e73de6318/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/vertical-align.html [add] https://crrev.com/e02b6826ad29d9c0312f9fe122b8661e73de6318/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/visibility.html [add] https://crrev.com/e02b6826ad29d9c0312f9fe122b8661e73de6318/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/white-space.html [add] https://crrev.com/e02b6826ad29d9c0312f9fe122b8661e73de6318/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/z-index.html [modify] https://crrev.com/e02b6826ad29d9c0312f9fe122b8661e73de6318/third_party/WebKit/Source/core/css/CSSProperties.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83aaf5c5f0722b318884d6949b0ba7fc8337f758 commit 83aaf5c5f0722b318884d6949b0ba7fc8337f758 Author: Darren Shen <shend@chromium.org> Date: Wed Feb 21 01:03:55 2018 [css-typed-om] Add CSS-wide keyword tests. This patch adds per-property tests for CSS-wide keywords like 'initial'. Every property should support these. Bug: 774887 Change-Id: Ie1d71e30c18ebff50ea166d27e92606782af43fa Reviewed-on: https://chromium-review.googlesource.com/925201 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#537969} [modify] https://crrev.com/83aaf5c5f0722b318884d6949b0ba7fc8337f758/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js [modify] https://crrev.com/83aaf5c5f0722b318884d6949b0ba7fc8337f758/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transform-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfe9e5bfae2e0e63f7cb546fa27ea4e9796defc6 commit dfe9e5bfae2e0e63f7cb546fa27ea4e9796defc6 Author: Darren Shen <shend@chromium.org> Date: Fri Feb 23 02:16:47 2018 [css-typed-om] Add unsupported tests for color properties. For color properties, we support 'currentcolor' as a CSSKeywordValue, but any other value (including identifiers like 'red') are not supported and are converted to base CSSStyleValues. We add tests for most color related properties. We are failing the text-emphasis-color one because we haven't unprefixed it yet. We change the code to make this work. Bug: 774887 Change-Id: Ide5463b9f67b63568ff32bd34e977faf16964bc1 Reviewed-on: https://chromium-review.googlesource.com/927943 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#538668} [add] https://crrev.com/dfe9e5bfae2e0e63f7cb546fa27ea4e9796defc6/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/background-color.html [add] https://crrev.com/dfe9e5bfae2e0e63f7cb546fa27ea4e9796defc6/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/border-color.html [add] https://crrev.com/dfe9e5bfae2e0e63f7cb546fa27ea4e9796defc6/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/caret-color.html [add] https://crrev.com/dfe9e5bfae2e0e63f7cb546fa27ea4e9796defc6/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/color.html [add] https://crrev.com/dfe9e5bfae2e0e63f7cb546fa27ea4e9796defc6/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/column-rule-color.html [add] https://crrev.com/dfe9e5bfae2e0e63f7cb546fa27ea4e9796defc6/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/outline-color.html [modify] https://crrev.com/dfe9e5bfae2e0e63f7cb546fa27ea4e9796defc6/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js [add] https://crrev.com/dfe9e5bfae2e0e63f7cb546fa27ea4e9796defc6/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-decoration-color.html [add] https://crrev.com/dfe9e5bfae2e0e63f7cb546fa27ea4e9796defc6/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-emphasis-color-expected.txt [add] https://crrev.com/dfe9e5bfae2e0e63f7cb546fa27ea4e9796defc6/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-emphasis-color.html [modify] https://crrev.com/dfe9e5bfae2e0e63f7cb546fa27ea4e9796defc6/third_party/WebKit/Source/core/css/CSSProperties.json5 [modify] https://crrev.com/dfe9e5bfae2e0e63f7cb546fa27ea4e9796defc6/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18fc5e4a9542da288a5ac90f7a5d1d9a780deeda commit 18fc5e4a9542da288a5ac90f7a5d1d9a780deeda Author: Darren Shen <shend@chromium.org> Date: Mon Feb 26 13:29:58 2018 [css-typed-om] Add property test for font-weight. font-weight is clamped to [0, 1000], so we have to change the out of range code to handle upperbounds too. Test failure because we seem to be rounding the font weight, but the spec doesn't say we should. Bug: 774887 Change-Id: I75d283dc32d37e04633133fe420817d02953d4e3 Reviewed-on: https://chromium-review.googlesource.com/936722 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#539117} [add] https://crrev.com/18fc5e4a9542da288a5ac90f7a5d1d9a780deeda/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-weight-expected.txt [add] https://crrev.com/18fc5e4a9542da288a5ac90f7a5d1d9a780deeda/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-weight.html [modify] https://crrev.com/18fc5e4a9542da288a5ac90f7a5d1d9a780deeda/third_party/WebKit/Source/core/css/CSSProperties.json5 [modify] https://crrev.com/18fc5e4a9542da288a5ac90f7a5d1d9a780deeda/third_party/WebKit/Source/core/css/cssom/CSSUnitValue.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb2bb69420bb6fc3b3a767ce3120915634f5de4c commit fb2bb69420bb6fc3b3a767ce3120915634f5de4c Author: Darren Shen <shend@chromium.org> Date: Mon Feb 26 13:31:28 2018 [css-typed-om] Add tests for images related properties. This patch adds tests for properties taking an <image>. There are some failing tests due to keywords not implemented in Blink yet. Bug: 774887 Change-Id: Ie5fa1fa15a16440273517afdd62b078449e615e4 Reviewed-on: https://chromium-review.googlesource.com/928056 Commit-Queue: nainar <nainar@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#539118} [add] https://crrev.com/fb2bb69420bb6fc3b3a767ce3120915634f5de4c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/border-image-source.html [add] https://crrev.com/fb2bb69420bb6fc3b3a767ce3120915634f5de4c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/mask-image-expected.txt [add] https://crrev.com/fb2bb69420bb6fc3b3a767ce3120915634f5de4c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/mask-image.html [add] https://crrev.com/fb2bb69420bb6fc3b3a767ce3120915634f5de4c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/shape-outside-expected.txt [add] https://crrev.com/fb2bb69420bb6fc3b3a767ce3120915634f5de4c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/shape-outside.html [modify] https://crrev.com/fb2bb69420bb6fc3b3a767ce3120915634f5de4c/third_party/WebKit/Source/core/css/CSSProperties.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4417ec92ac1c638d6d746308f90b6aee34f05917 commit 4417ec92ac1c638d6d746308f90b6aee34f05917 Author: Darren Shen <shend@chromium.org> Date: Mon Feb 26 19:14:16 2018 [css-typed-om] Add more property tests. Add more property tests. Most test failures are because our Blink implementation for these properties are lagging behind spec. The only weird one is line-height, which seems to return 'normal' for negative values even though the spec doesn't say that anywhere. Bug: 774887 Change-Id: I9d4a6918b5e9b5772230999b18c6eec4934bcf19 Reviewed-on: https://chromium-review.googlesource.com/936821 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#539222} [add] https://crrev.com/4417ec92ac1c638d6d746308f90b6aee34f05917/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/box-sizing.html [add] https://crrev.com/4417ec92ac1c638d6d746308f90b6aee34f05917/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/clear.html [add] https://crrev.com/4417ec92ac1c638d6d746308f90b6aee34f05917/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/float.html [add] https://crrev.com/4417ec92ac1c638d6d746308f90b6aee34f05917/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-style-expected.txt [add] https://crrev.com/4417ec92ac1c638d6d746308f90b6aee34f05917/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-style.html [add] https://crrev.com/4417ec92ac1c638d6d746308f90b6aee34f05917/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/line-height-expected.txt [add] https://crrev.com/4417ec92ac1c638d6d746308f90b6aee34f05917/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/line-height.html [add] https://crrev.com/4417ec92ac1c638d6d746308f90b6aee34f05917/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/list-style-position.html [add] https://crrev.com/4417ec92ac1c638d6d746308f90b6aee34f05917/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/outline-style-expected.txt [add] https://crrev.com/4417ec92ac1c638d6d746308f90b6aee34f05917/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/outline-style.html [add] https://crrev.com/4417ec92ac1c638d6d746308f90b6aee34f05917/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/overflow-expected.txt [add] https://crrev.com/4417ec92ac1c638d6d746308f90b6aee34f05917/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/overflow.html [modify] https://crrev.com/4417ec92ac1c638d6d746308f90b6aee34f05917/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-decoration-style.html [add] https://crrev.com/4417ec92ac1c638d6d746308f90b6aee34f05917/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-transform-expected.txt [add] https://crrev.com/4417ec92ac1c638d6d746308f90b6aee34f05917/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-transform.html [modify] https://crrev.com/4417ec92ac1c638d6d746308f90b6aee34f05917/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/visibility.html [add] https://crrev.com/4417ec92ac1c638d6d746308f90b6aee34f05917/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/whitespace.html [modify] https://crrev.com/4417ec92ac1c638d6d746308f90b6aee34f05917/third_party/WebKit/Source/core/css/CSSProperties.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39fa84ba5756e5c83807de25cd8ec5abaef1616f commit 39fa84ba5756e5c83807de25cd8ec5abaef1616f Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Tue Feb 27 22:36:30 2018 [css-typed-om] remove duplicate test. there are duplicate tests. so remove one of them. Bug: 774887 Change-Id: I040ac68b8d2752ea7f952a0ff615f5352cb23b0e Reviewed-on: https://chromium-review.googlesource.com/939881 Commit-Queue: Hwanseung Lee <hwanseung@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#539568} [modify] https://crrev.com/39fa84ba5756e5c83807de25cd8ec5abaef1616f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/white-space.html [delete] https://crrev.com/49e172d9c0bfa3c3708e4c7a65db070806985da0/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/whitespace.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5dc0cbee126fde6dd7fe08b0e71d2dbeb1611cc9 commit 5dc0cbee126fde6dd7fe08b0e71d2dbeb1611cc9 Author: Darren Shen <shend@chromium.org> Date: Wed Mar 07 21:45:52 2018 [css-typed-om] Clean up parsing tests. This patch: - Deletes unused interface.html - Fixes <div> tag in tests. - Adds case-sensitivity tests. Bug: 774887 Change-Id: I194ec7549991bfcd7708e640458246b40fc3ab03 Reviewed-on: https://chromium-review.googlesource.com/952509 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#541592} [delete] https://crrev.com/344076e53b8b61fb0f22eb42289c02f45b959455/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-objects/interface.html [modify] https://crrev.com/5dc0cbee126fde6dd7fe08b0e71d2dbeb1611cc9/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-objects/parse.html [modify] https://crrev.com/5dc0cbee126fde6dd7fe08b0e71d2dbeb1611cc9/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-objects/parseAll.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/480465dc97a1eb50856d4dd7f30322d74fecab83 commit 480465dc97a1eb50856d4dd7f30322d74fecab83 Author: Darren Shen <shend@chromium.org> Date: Fri Mar 09 03:31:03 2018 [css-typed-om] Clean up CSSUnparsedValue & CSSVariableRefValue tests. This patch: - Splits existing tests into different files testing different parts of the IDL (e.g. separate file for cssUnparsedValue.length) - Fix some stylistic issues. Bug: 774887 Change-Id: I8b37679b96d1b1b6e44c4eb596036dcafa88264b Reviewed-on: https://chromium-review.googlesource.com/954525 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#542012} [add] https://crrev.com/480465dc97a1eb50856d4dd7f30322d74fecab83/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue-indexed-getter-setter.html [add] https://crrev.com/480465dc97a1eb50856d4dd7f30322d74fecab83/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue-iterable.html [add] https://crrev.com/480465dc97a1eb50856d4dd7f30322d74fecab83/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue-length.html [modify] https://crrev.com/480465dc97a1eb50856d4dd7f30322d74fecab83/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue.html [modify] https://crrev.com/480465dc97a1eb50856d4dd7f30322d74fecab83/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssVariableReferenceValue-invalid.html [add] https://crrev.com/480465dc97a1eb50856d4dd7f30322d74fecab83/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssVariableReferenceValue-variable.html [modify] https://crrev.com/480465dc97a1eb50856d4dd7f30322d74fecab83/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssVariableReferenceValue.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/335bf87015fc6351811860d149478d14e6122edf commit 335bf87015fc6351811860d149478d14e6122edf Author: Darren Shen <shend@chromium.org> Date: Wed Mar 14 02:09:17 2018 [css-typed-om] Add tests for font-size. Pretty standard test apart from font-size can't be negative. Bug: 774887 Change-Id: Ieae05dc71c68b5f777d6078e4c9daec0b6eebee4 Reviewed-on: https://chromium-review.googlesource.com/936961 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#542985} [add] https://crrev.com/335bf87015fc6351811860d149478d14e6122edf/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-size.html [modify] https://crrev.com/335bf87015fc6351811860d149478d14e6122edf/third_party/WebKit/Source/core/css/CSSProperties.json5 [modify] https://crrev.com/335bf87015fc6351811860d149478d14e6122edf/third_party/WebKit/Source/core/css/cssom/CSSUnitValue.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85210a9bf6edb7366a65119cd692d28054162c3a commit 85210a9bf6edb7366a65119cd692d28054162c3a Author: Darren Shen <shend@chromium.org> Date: Thu Mar 15 05:53:01 2018 [css-typed-om] Clean up CSSKeywordValue tests. This patch: - Creates separate test file for CSSKeywordValue.value. - Make code style consistent. Bug: 774887 Change-Id: I46322556d4f39fd33cffd91bfad82f5a001e48b5 Reviewed-on: https://chromium-review.googlesource.com/954563 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#543313} [modify] https://crrev.com/85210a9bf6edb7366a65119cd692d28054162c3a/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssKeywordValue-invalid.html [add] https://crrev.com/85210a9bf6edb7366a65119cd692d28054162c3a/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssKeywordValue-value.html [modify] https://crrev.com/85210a9bf6edb7366a65119cd692d28054162c3a/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssKeywordValue.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e8c88b3fe1f75106a35c37f009de27f3e86992b commit 8e8c88b3fe1f75106a35c37f009de27f3e86992b Author: Darren Shen <shend@chromium.org> Date: Mon Mar 19 00:17:22 2018 [css-typed-om] Clean up CSSUnitValue tests. This patch: - Adds mutation tests for CSSUnitValue.value. - Clean up code style. Bug: 774887 Change-Id: I5a6398c4a4a2ad86f60165780ee8d48bb3d8b0a1 Reviewed-on: https://chromium-review.googlesource.com/954642 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#543959} [rename] https://crrev.com/8e8c88b3fe1f75106a35c37f009de27f3e86992b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssUnitValue-expected.txt [add] https://crrev.com/8e8c88b3fe1f75106a35c37f009de27f3e86992b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssUnitValue-value.html [add] https://crrev.com/8e8c88b3fe1f75106a35c37f009de27f3e86992b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssUnitValue.html [delete] https://crrev.com/29b26a4ba97065b4247debb2a5c759dacb8c5a88/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssUnitValue.tentative.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9236bee6a8ccb4e25e5e287629249a339e15925a commit 9236bee6a8ccb4e25e5e287629249a339e15925a Author: Darren Shen <shend@chromium.org> Date: Tue Mar 27 09:03:33 2018 [css-typed-om] Stub list-valued tests. Currently we're just adding a TODO when we want to test a list-valued property. It's probably easier if we stub that test function and then implement it later. Bug: 774887 Change-Id: Iab3cea915afbcc8490cacbd45e5632a18e7dece1 Reviewed-on: https://chromium-review.googlesource.com/981956 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#546067} [modify] https://crrev.com/9236bee6a8ccb4e25e5e287629249a339e15925a/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/animation-direction.html [modify] https://crrev.com/9236bee6a8ccb4e25e5e287629249a339e15925a/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/background-image.html [modify] https://crrev.com/9236bee6a8ccb4e25e5e287629249a339e15925a/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/mask-image.html [modify] https://crrev.com/9236bee6a8ccb4e25e5e287629249a339e15925a/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js [modify] https://crrev.com/9236bee6a8ccb4e25e5e287629249a339e15925a/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transition-duration.html
There's still a lot of improvements we can make to the tests but it's probably better to create specific bugs for those. Closing this one as fixed.
Comment 1 by bugdroid1@chromium.org
, Oct 18 2017