New issue
Advanced search Search tips

Issue 774885 link

Starred by 2 users
Status: Fixed
Owner:
dtseng@chromium.org
Closed: Oct 2017
Cc:
dtseng@chromium.org
lpalmaro@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature
Team-Accessibility



Sign in to add a comment

Need ability to stop speech through touch only

Project Member Reported by lpalmaro@chromium.org, Oct 16 2017 
OS: Chrome

We need a way to pause speech on Chrome OS (whether Chromebooks or CFM devices), through a touch gesture. This should serve as the touch equivalent to pressing Ctrl to silence speech through the keyboard. We could consider a 2 finger tap here, as long as it's a quick tap and doesn't conflict with the two finger longer press to disable Chromevox on CFM devices. Happy to brainstorm other gestures, though!
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e149d3d0bf1e59a4c4d0a9437392f82f93e239e6

commit e149d3d0bf1e59a4c4d0a9437392f82f93e239e6
Author: David Tseng <dtseng@chromium.org>
Date: Tue Oct 17 18:51:12 2017

Map two finger tap to programmatic gesture

ChromeVox handles keys before the touch exploration event handler, so
dispatching raw control keys won't work.

Map the gesture to stop speech similarly to the way we do now for other
gestures.

Bug:  774885 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idf8d861a7887003c0fe12e364f3eef198567d18a
Reviewed-on: https://chromium-review.googlesource.com/721461
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509461}
[modify] https://crrev.com/e149d3d0bf1e59a4c4d0a9437392f82f93e239e6/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
[modify] https://crrev.com/e149d3d0bf1e59a4c4d0a9437392f82f93e239e6/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/e149d3d0bf1e59a4c4d0a9437392f82f93e239e6/ui/chromeos/touch_exploration_controller.cc
[modify] https://crrev.com/e149d3d0bf1e59a4c4d0a9437392f82f93e239e6/ui/chromeos/touch_exploration_controller_unittest.cc

Comment 2 by dtseng@chromium.org, Oct 17 2017

Status: fixed (was: Assigned)
Stop speech is mapped to 2 finger tap.

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: archived (was: Fixed)

Comment 4 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment