New issue
Advanced search Search tips

Issue 774868 link

Starred by 1 user
Status: Fixed
Owner:
peah@chromium.org
Closed: Oct 2017
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Too much echo suppression initially in the calls for AEC3

Project Member Reported by peah@chromium.org, Oct 15 2017 
The echo suppression initially in calls, and after resets during buffer issues, is too conservative in the sense that too much echo is removed, causing excessive ducking of the nearend.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/1b4059e84f5f58c68844cb1b91ce23390c03348a

commit 1b4059e84f5f58c68844cb1b91ce23390c03348a
Author: Per Åhgren <peah@webrtc.org>
Date: Tue Oct 17 06:00:50 2017

Transparency improvements for AEC3 during call start and after resets

This CL changes the AEC3 behavior to be more transparent when there 
is uncertainty about the amount of echo in the microphone signal.

Bug:  webrtc:8398 ,  chromium:774868 
Change-Id: I88e681f8decd892f44397b753df371a1c4b90af0
Reviewed-on: https://webrtc-review.googlesource.com/10801
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20319}
[modify] https://crrev.com/1b4059e84f5f58c68844cb1b91ce23390c03348a/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc
[modify] https://crrev.com/1b4059e84f5f58c68844cb1b91ce23390c03348a/modules/audio_processing/aec3/aec3_common.h
[modify] https://crrev.com/1b4059e84f5f58c68844cb1b91ce23390c03348a/modules/audio_processing/aec3/aec_state.cc
[modify] https://crrev.com/1b4059e84f5f58c68844cb1b91ce23390c03348a/modules/audio_processing/aec3/aec_state.h
[modify] https://crrev.com/1b4059e84f5f58c68844cb1b91ce23390c03348a/modules/audio_processing/aec3/aec_state_unittest.cc
[modify] https://crrev.com/1b4059e84f5f58c68844cb1b91ce23390c03348a/modules/audio_processing/aec3/echo_remover.cc
[modify] https://crrev.com/1b4059e84f5f58c68844cb1b91ce23390c03348a/modules/audio_processing/aec3/main_filter_update_gain_unittest.cc
[modify] https://crrev.com/1b4059e84f5f58c68844cb1b91ce23390c03348a/modules/audio_processing/aec3/render_delay_buffer.cc
[modify] https://crrev.com/1b4059e84f5f58c68844cb1b91ce23390c03348a/modules/audio_processing/aec3/residual_echo_estimator.cc
[modify] https://crrev.com/1b4059e84f5f58c68844cb1b91ce23390c03348a/modules/audio_processing/aec3/residual_echo_estimator.h
[modify] https://crrev.com/1b4059e84f5f58c68844cb1b91ce23390c03348a/modules/audio_processing/aec3/residual_echo_estimator_unittest.cc
[modify] https://crrev.com/1b4059e84f5f58c68844cb1b91ce23390c03348a/modules/audio_processing/aec3/subtractor.cc
[modify] https://crrev.com/1b4059e84f5f58c68844cb1b91ce23390c03348a/modules/audio_processing/aec3/subtractor.h
[modify] https://crrev.com/1b4059e84f5f58c68844cb1b91ce23390c03348a/modules/audio_processing/aec3/subtractor_unittest.cc
[modify] https://crrev.com/1b4059e84f5f58c68844cb1b91ce23390c03348a/modules/audio_processing/include/audio_processing.h

Comment 2 by peah@chromium.org, Oct 20 2017

Labels: Merge-Request-63
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 21 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 24 2017

Labels: merge-merged-63
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/31f1beeaef7096473b8e5e20643d9c4dda30f900

commit 31f1beeaef7096473b8e5e20643d9c4dda30f900
Author: Per Åhgren <peah@webrtc.org>
Date: Tue Oct 24 20:50:41 2017

Merge of Transparency improvements for AEC3 during call start and after resets

This CL changes the AEC3 behavior to be more transparent when there
is uncertainty about the amount of echo in the microphone signal.

TBR=henrik.lundin@webrtc.org
(cherry picked from commit 1b4059e84f5f58c68844cb1b91ce23390c03348a)

Bug:  webrtc:8398 ,  chromium:774868 
Change-Id: I88e681f8decd892f44397b753df371a1c4b90af0
Reviewed-on: https://webrtc-review.googlesource.com/10801
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Original-Commit-Position: refs/heads/master@{#20319}
Reviewed-on: https://webrtc-review.googlesource.com/15100
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/branch-heads/63@{#5}
Cr-Branched-From: bef8a5d2ca5413c680995584b8c0976852ba5f25-refs/heads/master@{#20237}
[modify] https://crrev.com/31f1beeaef7096473b8e5e20643d9c4dda30f900/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc
[modify] https://crrev.com/31f1beeaef7096473b8e5e20643d9c4dda30f900/modules/audio_processing/aec3/aec3_common.h
[modify] https://crrev.com/31f1beeaef7096473b8e5e20643d9c4dda30f900/modules/audio_processing/aec3/aec_state.cc
[modify] https://crrev.com/31f1beeaef7096473b8e5e20643d9c4dda30f900/modules/audio_processing/aec3/aec_state.h
[modify] https://crrev.com/31f1beeaef7096473b8e5e20643d9c4dda30f900/modules/audio_processing/aec3/aec_state_unittest.cc
[modify] https://crrev.com/31f1beeaef7096473b8e5e20643d9c4dda30f900/modules/audio_processing/aec3/echo_remover.cc
[modify] https://crrev.com/31f1beeaef7096473b8e5e20643d9c4dda30f900/modules/audio_processing/aec3/main_filter_update_gain_unittest.cc
[modify] https://crrev.com/31f1beeaef7096473b8e5e20643d9c4dda30f900/modules/audio_processing/aec3/render_delay_buffer.cc
[modify] https://crrev.com/31f1beeaef7096473b8e5e20643d9c4dda30f900/modules/audio_processing/aec3/residual_echo_estimator.cc
[modify] https://crrev.com/31f1beeaef7096473b8e5e20643d9c4dda30f900/modules/audio_processing/aec3/residual_echo_estimator.h
[modify] https://crrev.com/31f1beeaef7096473b8e5e20643d9c4dda30f900/modules/audio_processing/aec3/residual_echo_estimator_unittest.cc
[modify] https://crrev.com/31f1beeaef7096473b8e5e20643d9c4dda30f900/modules/audio_processing/aec3/subtractor.cc
[modify] https://crrev.com/31f1beeaef7096473b8e5e20643d9c4dda30f900/modules/audio_processing/aec3/subtractor.h
[modify] https://crrev.com/31f1beeaef7096473b8e5e20643d9c4dda30f900/modules/audio_processing/aec3/subtractor_unittest.cc
[modify] https://crrev.com/31f1beeaef7096473b8e5e20643d9c4dda30f900/modules/audio_processing/include/audio_processing.h

Comment 5 by peah@chromium.org, Oct 24 2017

Status: Fixed (was: Assigned)

Comment 6 by gov...@chromium.org, Oct 24 2017

Labels: -Merge-Approved-63
Per comment #4, this is already merged to M63. So removing "Merge-Approved-63" label.
►

Sign in to add a comment