New issue
Advanced search Search tips

Issue 774867 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

AEC3 sometimes fails to detect a valid linear filter estimate in reverberant environments

Project Member Reported by peah@chromium.org, Oct 15 2017

Issue description

For some reverberant environments the analysis of the adaptive filter estimate done by AEC3 falsely detects the estimate to be poor due to strong echo reflections.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/40659c3eaf3764b6eb2720e0454c98a1f3075df4

commit 40659c3eaf3764b6eb2720e0454c98a1f3075df4
Author: Per Åhgren <peah@webrtc.org>
Date: Tue Oct 17 11:30:50 2017

Corrected and robustified the detection of the delay in the AEC3 filter

This CL changes the filter delay detection to rely on the largest peak
while the correctness of the filter is changed to be based on the
performance achieved by the filter.

Bug:  webrtc:8397 , chromium:774867 
Change-Id: I70c953815192478f9a8e0da9f2b8fd9edac3f481
Reviewed-on: https://webrtc-review.googlesource.com/10803
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20321}
[modify] https://crrev.com/40659c3eaf3764b6eb2720e0454c98a1f3075df4/modules/audio_processing/aec3/aec_state.cc
[modify] https://crrev.com/40659c3eaf3764b6eb2720e0454c98a1f3075df4/modules/audio_processing/aec3/aec_state_unittest.cc

Comment 2 by peah@chromium.org, Oct 20 2017

Labels: Merge-Request-63
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 21 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 24 2017

Labels: merge-merged-63
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/1fadc32e12c827ff16d43579558ab7676f2d72fa

commit 1fadc32e12c827ff16d43579558ab7676f2d72fa
Author: Per Åhgren <peah@webrtc.org>
Date: Tue Oct 24 21:17:19 2017

Merge of Corrected and robustified the detection of the delay in the AEC3 filter

This CL changes the filter delay detection to rely on the largest peak
while the correctness of the filter is changed to be based on the
performance achieved by the filter.

TBR=henrik.lundin@webrtc.org
(cherry picked from commit 40659c3eaf3764b6eb2720e0454c98a1f3075df4)

Bug:  webrtc:8397 , chromium:774867 
Change-Id: I70c953815192478f9a8e0da9f2b8fd9edac3f481
Reviewed-on: https://webrtc-review.googlesource.com/10803
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Original-Commit-Position: refs/heads/master@{#20321}
Reviewed-on: https://webrtc-review.googlesource.com/15140
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/branch-heads/63@{#6}
Cr-Branched-From: bef8a5d2ca5413c680995584b8c0976852ba5f25-refs/heads/master@{#20237}
[modify] https://crrev.com/1fadc32e12c827ff16d43579558ab7676f2d72fa/modules/audio_processing/aec3/aec_state.cc
[modify] https://crrev.com/1fadc32e12c827ff16d43579558ab7676f2d72fa/modules/audio_processing/aec3/aec_state_unittest.cc

Comment 5 by peah@chromium.org, Oct 24 2017

Status: Fixed (was: Assigned)

Comment 6 by gov...@chromium.org, Oct 24 2017

Labels: -Merge-Approved-63
Per comment #9, this is already merged to M63. So removing "Merge-Approved-63" label.

Sign in to add a comment