New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774809 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on:
issue 768572



Sign in to add a comment

pixel_test failures on Mac Experimental Release (Intel)

Project Member Reported by ynovikov@chromium.org, Oct 14 2017

Issue description

After upgrade to 10.13 Mac OS in issue 768572 the following tests started failing:
Pixel_OffscreenCanvas2DResizeOnWorker
Pixel_OffscreenCanvasAccelerated2D
Pixel_OffscreenCanvasAccelerated2DWorker
Pixel_Video_MP4
Pixel_Video_VP9
Pixel_WebGLGreenTriangle_NonChromiumImage_NoAA_NoAlpha

Going to suppress them.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ec0c4b2297ea4bcc2c02a5a52d210ba2c7bc963

commit 3ec0c4b2297ea4bcc2c02a5a52d210ba2c7bc963
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Sun Oct 15 03:46:21 2017

Skip some pixel_test on Nexus 5 and Mac Intel HighSierra

Pixel_WebGL2_ClearBufferfv_Result_Displayed on Nexus 5

Pixel_OffscreenCanvas2DResizeOnWorker
Pixel_OffscreenCanvasAccelerated2D
Pixel_OffscreenCanvasAccelerated2DWorker
Pixel_Video_MP4
Pixel_Video_VP9
Pixel_WebGLGreenTriangle_NonChromiumImage_NoAA_NoAlpha

on Mac Intel HighSierra

BUG= 773293 ,774809
TBR=kbr@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I00c8051302de94a599b8d3ed974bd32a2f6c2946
Reviewed-on: https://chromium-review.googlesource.com/720164
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508946}
[modify] https://crrev.com/3ec0c4b2297ea4bcc2c02a5a52d210ba2c7bc963/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/3ec0c4b2297ea4bcc2c02a5a52d210ba2c7bc963/content/test/gpu/gpu_tests/test_expectations.py

Actually, these were failing in https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Experimental%20Release%20%28Intel%29/builds/1629,
but in https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Experimental%20Release%20%28Intel%29/builds/1652 I see only these are failing:

Pixel_Video_MP4
Pixel_Video_VP9
Pixel_WebGLGreenTriangle_NonChromiumImage_NoAA_NoAlpha

Going to remove suppression for the rest.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31b0367a9b76e6892404c4757629018eaf0aebdb

commit 31b0367a9b76e6892404c4757629018eaf0aebdb
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Sun Oct 15 06:03:30 2017

Skip some webgl2_conformance_tests on Mac High Sierra

And remove some pixel_test suppressions.

Suppress on Intel High Sierra:
WebglConformance_deqp_functional_gles3_fbocolorbuffer_tex2d_00
WebglConformance_deqp_functional_gles3_fboinvalidate_format_00
WebglConformance_deqp_functional_gles3_framebufferblit_default_framebuffer_05

Suppress on Nvidia High Sierra:
WebglConformance_conformance2_glsl3_array_assign
WebglConformance_deqp_functional_gles3_fborender_resize_03
WebglConformance_deqp_functional_gles3_shaderindexing_mat_00
WebglConformance_deqp_functional_gles3_shaderindexing_mat_02
WebglConformance_deqp_functional_gles3_texturespecification_teximage2d_pbo_cube_00

Unsuppress on Intel High Sierra:
Pixel_OffscreenCanvas2DResizeOnWorker
Pixel_OffscreenCanvasAccelerated2D
Pixel_OffscreenCanvasAccelerated2DWorker

BUG=774809,774826,774827
TBR=kbr@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I3bd2b5dbfb48bd93b006ed87cc3efdad1bd46387
Reviewed-on: https://chromium-review.googlesource.com/720458
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508951}
[modify] https://crrev.com/31b0367a9b76e6892404c4757629018eaf0aebdb/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/31b0367a9b76e6892404c4757629018eaf0aebdb/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Comment 4 by kbr@chromium.org, Oct 16 2017

Cc: yunchao...@intel.com yang...@intel.com
Status: Available (was: Unconfirmed)
Looking at the failure results from one of the failing builds:
http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/view_test_results.html?92473bf9064cc84b6eceaf9b4c87d50ec27e20d2_Mac_Experimental_Release_Intel__telemetry

The Pixel_Video_MP4 and Pixel_Video_VP9 failures look like they just need a slightly increased tolerance. (Ideally we'd rebaseline them but we don't keep OS-specific baselines right now.)

The Pixel_WebGLGreenTriangle_NonChromiumImage_NoAA_NoAlpha failure's a little concerning because that should be taking a pretty standard code path through the driver. CC'ing Yang and Yunchao from Intel as FYI. Hopefully something's not broken with RGB textures in High Sierra.

Comment 5 by kbr@chromium.org, Nov 25 2017

Blocking: -768572

Comment 6 by kbr@chromium.org, Nov 25 2017

Blockedon: 768572
Cc: yizhou.j...@intel.com
Yizhou, please take a look at this issue.
Hi Yuly, I have tested the deqp cases but couldn't reproduce the failure yet. My environment is Mac OS High Sierra 10.13, Intel HD Graphics 515, skylake.
And I don't know how to test these gpu tests like Pixel_Video_MP4. Could you provide more information about how to reproduce the failure and your environment information?
This bug is about
Pixel_Video_MP4
Pixel_Video_VP9
Pixel_WebGLGreenTriangle_NonChromiumImage_NoAA_NoAlpha

webgl failures are issue 774826.

To run pixel tests, the instructions are in here: https://www.chromium.org/developers/testing/gpu-testing#TOC-Running-the-GPU-Tests-Locally

Bot builds Chrome with these args.gn:
dcheck_always_on = true
ffmpeg_branding = "Chrome"
is_component_build = false
is_debug = false
proprietary_codecs = true
strip_absolute_paths_from_debug_symbols = true
symbol_level = 1

Bot's arguments to pixel tests are:
run_gpu_integration_test.py pixel --show-stdout --browser=release --passthrough -v --extra-browser-args="--enable-logging=stderr --js-flags=--expose-gc" --dont-restore-color-profile-after-test --refimg-cloud-storage-bucket chromium-gpu-archive/reference-images --os-type mac --download-refimg-from-cloud-storage

Make sure you revert my CLs in #1 and #3 to see the failures.
Hi Yuly, these test cases has passed on my side, could you provide your mac environment info on fyi about which IA platform is used such as broadwell, skylake, kabylake or hasswell and gpu infos in chrome://gpu ?
CPU is i7-4578U

GPU info you can find in the logs, https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.gpu.fyi%2FMac_Experimental_Release__Intel_%2F2525%2F%2B%2Frecipes%2Fsteps%2Fwebgl2_conformance_tests_on_Intel_GPU_on_Mac_on_Mac-10.13.2%2F0%2Fstdout

INFO:root:OS: mac highsierra
INFO:root:Detailed OS version: 10.13.2 17C83a
INFO:root:Model: Macmini 7.1
INFO:root:Browser command line: /b/s/w/ir/out/Release/Chromium.app/Contents/MacOS/Chromium --disable-gpu-watchdog --disable-domain-blocking-for-3d-apis --ignore-autoplay-restrictions --disable-gpu-process-crash-limit --test-type=gpu --enable-experimental-canvas-features --js-flags=--expose-gc --enable-logging=stderr --use-cmd-decoder=validating --enable-net-benchmarking --metrics-recording-only --no-default-browser-check --no-first-run --enable-gpu-benchmarking --disable-background-networking --proxy-server=socks://localhost:60703 --ignore-certificate-errors-spki-list=PhrPvGIaAMmd29hj8BCZOq096yj7uMpRNHpn5PDxI6I= --disable-component-extensions-with-background-pages --disable-default-apps --disable-search-geolocation-disclosure --remote-debugging-port=0 --enable-crash-reporter-for-testing --disable-component-update --window-size=1280,1024 --user-data-dir=/b/s/w/itlFTNJR/tmpMnG4YS --flag-switches-begin --flag-switches-end about:blank
INFO:root:GPU device 0: VENDOR = 0x8086 (Intel), DEVICE = 0xa2e
INFO:root:GPU Attributes:
INFO:root:  amd_switchable      : False
INFO:root:  basic_info_state    : 1
INFO:root:  can_support_threaded_texture_mailbox: False
INFO:root:  context_info_state  : 1
INFO:root:  direct_rendering    : True
INFO:root:  driver_date         : 
INFO:root:  driver_vendor       : 
INFO:root:  driver_version      : 10.30.12
INFO:root:  encrypted_only      : False
INFO:root:  gl_extensions       : GL_ARB_blend_func_extended GL_ARB_draw_buffers_blend GL_ARB_draw_indirect GL_ARB_ES2_compatibility GL_ARB_explicit_attrib_location GL_ARB_gpu_shader_fp64 GL_ARB_gpu_shader5 GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_occlusion_query2 GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding GL_ARB_shader_subroutine GL_ARB_shading_language_include GL_ARB_tessellation_shader GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_texture_storage GL_ARB_texture_swizzle GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_ARB_vertex_attrib_64bit GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_EXT_debug_label GL_EXT_debug_marker GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_texture_compression_s3tc GL_EXT_texture_filter_anisotropic GL_EXT_texture_sRGB_decode GL_APPLE_client_storage GL_APPLE_container_object_shareable GL_APPLE_flush_render GL_APPLE_object_purgeable GL_APPLE_rgb_422 GL_APPLE_row_bytes GL_APPLE_texture_range GL_ATI_texture_mirror_once GL_NV_texture_barrier
INFO:root:  gl_renderer         : Intel Iris OpenGL Engine
INFO:root:  gl_reset_notification_strategy: 0
INFO:root:  gl_vendor           : Intel Inc.
INFO:root:  gl_version          : 4.1 INTEL-10.30.12
INFO:root:  gl_ws_extensions    : 
INFO:root:  gl_ws_vendor        : 
INFO:root:  gl_ws_version       : 
INFO:root:  in_process_gpu      : False
INFO:root:  initialization_time : 0.052293
INFO:root:  jpeg_decode_accelerator_supported: False
INFO:root:  max_framerate_denominator: 1
INFO:root:  max_framerate_numerator: 30
INFO:root:  max_msaa_samples    : 8
INFO:root:  max_resolution_height: 2160
INFO:root:  max_resolution_width: 4096
INFO:root:  min_resolution_height: 16
INFO:root:  min_resolution_width: 16
INFO:root:  optimus             : False
INFO:root:  passthrough_cmd_decoder: False
INFO:root:  pixel_shader_version: 4.10
INFO:root:  process_crash_count : 0
INFO:root:  profile             : 3
INFO:root:  sandboxed           : True
INFO:root:  software_rendering  : False
INFO:root:  supports_overlays   : False
INFO:root:  vertex_shader_version: 4.10
INFO:root:  video_decode_accelerator_flags: 0
INFO:root:Feature Status:
INFO:root:  2d_canvas           : enabled
INFO:root:  checker_imaging     : enabled_on
INFO:root:  flash_3d            : enabled
INFO:root:  flash_stage3d       : enabled
INFO:root:  flash_stage3d_baseline: enabled
INFO:root:  gpu_compositing     : enabled
INFO:root:  multiple_raster_threads: enabled_on
INFO:root:  native_gpu_memory_buffers: enabled
INFO:root:  rasterization       : enabled
INFO:root:  video_decode        : enabled
INFO:root:  webgl               : enabled
INFO:root:  webgl2              : enabled
INFO:root:Driver Bug Workarounds:
INFO:root:  add_and_true_to_loop_condition
INFO:root:  adjust_src_dst_region_for_blitframebuffer
INFO:root:  avoid_stencil_buffers
INFO:root:  decode_encode_srgb_for_generatemipmap
INFO:root:  disable_framebuffer_cmaa
INFO:root:  disable_webgl_rgb_multisampling_usage
INFO:root:  emulate_abs_int_function
INFO:root:  get_frag_data_info_bug
INFO:root:  init_two_cube_map_levels_before_copyteximage
INFO:root:  msaa_is_slow
INFO:root:  pack_parameters_workaround_with_pack_buffer
INFO:root:  rebind_transform_feedback_before_resume
INFO:root:  regenerate_struct_names
INFO:root:  remove_invariant_and_centroid_for_essl3
INFO:root:  reset_teximage2d_base_level
INFO:root:  rewrite_texelfetchoffset_to_texelfetch
INFO:root:  scalarize_vec_and_mat_constructor_args
INFO:root:  set_zero_level_before_generating_mipmap
INFO:root:  unfold_short_circuit_as_ternary_operation
INFO:root:  unpack_alignment_workaround_with_unpack_buffer
INFO:root:  unpack_image_height_workaround_with_unpack_buffer
INFO:root:  use_intermediary_for_copy_texture_image
INFO:root:  use_unused_standard_shared_blocks
Cc: zmo@chromium.org kbr@chromium.org
Hi Ken, Zhenyao, RGB8 format pixel test fails after MacOS upgrading to 10.13.2 on Intel Haswell devices. The cts deqp tests could pass on SkyLake and KabyLake. I've wrote a radar describing the bug. Please help review the report, thanks.
https://docs.google.com/document/d/1uSqgzO0qIZTi-X7p6efk5cg0SXuquo0-hrGUacQ5Duo/edit

Comment 14 by kbr@chromium.org, Apr 11 2018

Thanks for the report. Filed Radar 39334920 and informed Apple about it, asking them to route it to Intel.

Project Member

Comment 15 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e483dd657388cfdb2ff553764483ec0ee2b889c

commit 4e483dd657388cfdb2ff553764483ec0ee2b889c
Author: James Darpinian <jdarpinian@chromium.org>
Date: Wed Oct 10 00:04:28 2018

Extend mac webgl failure expectations from 10.13 to 10.14

This should make the new 10.14 bots green.

TBR: kbr@chromium.org
Bug: 774826,774827,774809,871872
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7163bfeb7fc445f4d8ce78f4d6e74a87da2533ba
Reviewed-on: https://chromium-review.googlesource.com/c/1272025
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598137}
[modify] https://crrev.com/4e483dd657388cfdb2ff553764483ec0ee2b889c/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/4e483dd657388cfdb2ff553764483ec0ee2b889c/content/test/gpu/gpu_tests/test_expectations.py
[modify] https://crrev.com/4e483dd657388cfdb2ff553764483ec0ee2b889c/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 16 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a9264ddffb97e645ae936840846a741dfefee24

commit 1a9264ddffb97e645ae936840846a741dfefee24
Author: Sunny Sachanandani <sunnyps@chromium.org>
Date: Tue Dec 11 00:52:48 2018

Re-enable video pixel tests after rebaselining

The tests were marked as failing and version numbers were incremented in
https://crrev.com/c/1182222, but I forgot to re-enable the tests.

Bug: 869677, 913138, 858826, 819635, 774809
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7fdb28c3dbaa7aad4137b16d8f9bf8fe15fe9a08
Reviewed-on: https://chromium-review.googlesource.com/c/1214364
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615353}
[modify] https://crrev.com/1a9264ddffb97e645ae936840846a741dfefee24/content/test/gpu/gpu_tests/pixel_expectations.py

Project Member

Comment 17 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b188cd82b0f877078b2a7f87169a4a16a1f9507d

commit b188cd82b0f877078b2a7f87169a4a16a1f9507d
Author: Jamie Madill <jmadill@chromium.org>
Date: Tue Dec 11 16:38:53 2018

Revert "Re-enable video pixel tests after rebaselining"

This reverts commit 1a9264ddffb97e645ae936840846a741dfefee24.

Reason for revert: rebaseline didn't seem to work.

Failing builds:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20%28AMD%29/3655
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20%28NVIDIA%29/3470
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28Intel%20HD%20630%29/2954

Failing tests:

gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_DirectComposition_Video_VP9
gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_Video_VP9
gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_DirectComposition_Video_MP4
gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_Video_MP4

Original change's description:
> Re-enable video pixel tests after rebaselining
> 
> The tests were marked as failing and version numbers were incremented in
> https://crrev.com/c/1182222, but I forgot to re-enable the tests.
> 
> Bug: 869677, 913138, 858826, 819635, 774809
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I7fdb28c3dbaa7aad4137b16d8f9bf8fe15fe9a08
> Reviewed-on: https://chromium-review.googlesource.com/c/1214364
> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615353}

TBR=kbr@chromium.org,sunnyps@chromium.org

Change-Id: I553c10ca8022a90a0afa73ffafa44aa5bbf4e2d1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 869677, 913138, 858826, 819635, 774809
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1372234
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615553}
[modify] https://crrev.com/b188cd82b0f877078b2a7f87169a4a16a1f9507d/content/test/gpu/gpu_tests/pixel_expectations.py

Owner: sunn...@chromium.org
Status: Assigned (was: Available)
Sunny: could you look into the nature of the pixel test rebaselining failures and tell me if it looks like something's wrong with the harness?

Sign in to add a comment